Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932486AbVL1HmX (ORCPT ); Wed, 28 Dec 2005 02:42:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932495AbVL1HmX (ORCPT ); Wed, 28 Dec 2005 02:42:23 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:19400 "EHLO mx3.mail.elte.hu") by vger.kernel.org with ESMTP id S932486AbVL1HmW (ORCPT ); Wed, 28 Dec 2005 02:42:22 -0500 Date: Wed, 28 Dec 2005 08:41:54 +0100 From: Ingo Molnar To: Nicolas Pitre Cc: lkml , Arjan van de Ven , Russell King Subject: Re: [patch 2/3] mutex subsystem: fastpath inlining Message-ID: <20051228074154.GA4442@elte.hu> References: <20051223161649.GA26830@elte.hu> <20051227115525.GC23587@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i X-ELTE-SpamScore: 0.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=0.0 required=5.9 tests=AWL autolearn=no SpamAssassin version=3.0.3 0.0 AWL AWL: From: address is in the auto white-list X-ELTE-VirusStatus: clean Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1240 Lines: 29 * Nicolas Pitre wrote: > > * Nicolas Pitre wrote: > > > > > Some architectures, notably ARM for instance, might benefit from > > > inlining the mutex fast paths. [...] > > > > what is the effect on text size? Could you post the before- and > > after-patch vmlinux 'size kernel/test.o' output in the nondebug case, > > with Arjan's latest 'convert a couple of semaphore users to mutexes' > > patch applied? [make sure you've got enough of those users compiled in, > > so that the inlining cost is truly measured. Perhaps also do > > before/after 'size' output of a few affected .o files, without mixing > > kernel/mutex.o into it, like vmlinux does.] > > Theory should be convincing enough. [...] please provide actual measurements (just a simple pre-patch and post-patch 'size' output of vmlinux is enough), so that we can see the inlining cost. Note that x86 went to a non-inlined fastpath _despite_ having a compact CISC semaphore fastpath. Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/