From: Denis Vlasenko <vda@ilport.com.ua>
To: Matt Mackall <mpm@selenic.com>
Subject: Re: [PATCH 2 of 3] memcpy32 for x86_64
Date: Wed, 28 Dec 2005 09:54:45 +0200
User-Agent: KMail/1.8.2
Cc: "Bryan O'Sullivan" <bos@pathscale.com>, linux-kernel@vger.kernel.org,
       akpm@osdl.org, hch@infradead.org
References: <patchbomb.1135726914@eng-12.pathscale.com> <042b7d9004acd65f6655.1135726916@eng-12.pathscale.com> <20051228042232.GC3356@waste.org>
In-Reply-To: <20051228042232.GC3356@waste.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200512280954.45705.vda@ilport.com.ua>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 709
Lines: 29

> > +
> > + 	.globl memcpy32
> > +memcpy32:
> > +	movl %edx,%ecx
> > +	shrl $1,%ecx
> > +	andl $1,%edx
> > +	rep
> > +	movsq

Does this one really do 32-bit stores?! I doubt so...

> > +	movl %edx,%ecx
> > +	rep
> > +	movsd
> > +	ret
> 
> Any reason this needs its own .S file? One wonders if the
> 
>         .p2align 4
> 
> in memcpy.S is appropriate here too. Splitting rep movsq across two
> lines is a little weird to me too, but I see Andi did it too.
--
vda
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/