Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp4573803ybe; Mon, 16 Sep 2019 14:44:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqymY5NRe5psZX3WeAN+EIyUFxyGMH+gWDH7a8eIGsRJf2wV9a9B2uso/mWSeg5glSCy6Luo X-Received: by 2002:a50:fd83:: with SMTP id o3mr1476747edt.67.1568670249041; Mon, 16 Sep 2019 14:44:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568670249; cv=none; d=google.com; s=arc-20160816; b=yPNnMV0iF2ulxeHrUDe3t370RVapg2VtPPWcA0DmuiAjGiQ1SfymCqsDkYf1juc8TU 5Mh0gk9BHSHhxIrSvCSjs59UyOeUlQ2ylYuD2c/vLcpIen4AoNDtQmaIKs0WXOdfdz39 BfC8L/jOZpwmbToDvrpR3sKK/yzyGqvCr2IU5JiPBKMhQ8t3piA80x2MRg2/PjzuPckN k+V/gaGK2s5pa2XJrtHGjstY99dlL8COY3ZDYS/tI5bNnBubzUrx94i4EUK4KD683PpS HA5EFIVcWwKSE+Nh1kuwNjHitUISgRSDtiFNda8G66kUSHMGCDiv0bYo4coknYTxCs11 QSFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature; bh=DzSndrAt3W5Qpn/Z0ZHFWHP+YFwM5pnaWCeVZxGk0sY=; b=TiNlc0TZ3qH6Dfpqt2kubjDQ6y2KT2gEPtxr5AOKTDUV6C7wDOED1RMvjTpzwce9D9 xhp+GKKO3QMJu9La4mtakTDIcPKnV8tUc3B2hBgePt2D77XeAMeAttwoeCDc7Se7Dqkc eNaFPNQN3I3x/H8vqCgd29LiK5qlXHmmRXkFGNCrpPg7KksYEL8uw2Kc+Asd8knKAg+z S7vpbTTGjqLtABt/08+VsxS+MvXXs6baiJB5HusadmKx31/SjhStGMTAf8o9U05UKCAr +L7k5xVHgpvdyLJ4ePPZffXY1fPVxR+VcWIJHImerVixvuy77W4enk7hXkyZUTZLo98z MSyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Fl/lu1AW"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b42si180273eda.367.2019.09.16.14.43.45; Mon, 16 Sep 2019 14:44:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Fl/lu1AW"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732672AbfIPS7J (ORCPT + 99 others); Mon, 16 Sep 2019 14:59:09 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:42839 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727917AbfIPS7J (ORCPT ); Mon, 16 Sep 2019 14:59:09 -0400 Received: by mail-pl1-f195.google.com with SMTP id e5so298702pls.9; Mon, 16 Sep 2019 11:59:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=DzSndrAt3W5Qpn/Z0ZHFWHP+YFwM5pnaWCeVZxGk0sY=; b=Fl/lu1AW2AU8GF/kHqNLOJrGi83gqhB5xB5qlXB/KthNnSLzz5EYA4ukoHaafGNFie GjteLbBxdSWqul4vNC7SWnAjX8l27OP/TnTKXrn9n/33TMu+5L2siDJtgBmRVmdErxCd kB+U8yAhJYLMHNZsaAvxW0QNNWVt1raRY7RHiGi8Wh02RRLUNgaEryBxIh21loZ+EWz3 n4jSWd/5kEe1mQ9RSzozRakqNFuhd6iuCb4/SKppjbvFBmmvz9FMhD1sk6ouTM83aHzo wLKyRX+1FDZ72/LapQ1mbMTBA/xF9wz8WaiDhiwRnFXQ13vetbAGl948H7IPAyPCqXIJ ZUTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=DzSndrAt3W5Qpn/Z0ZHFWHP+YFwM5pnaWCeVZxGk0sY=; b=RcDLAXbsqwJQMFgRSC81O1vuimPYZGbrHJKsTBSCzpedV4q1ElwP2fQUH90RMVT4wy bTx5QmhwKHZ7FaWX4pY9dFvbfE1dx3B5CUtMcYK6O9Njsxej+xMVrogriIgUdoVNStYu u5Wv2VyZThAtr4D1A4YYTca1xCSeLppdv6R0+h3i8GLqYEfugwl0Y4c6UBRucGQaLMds IvcW09H9s7+l0lxw1NMdE5E65JayqixlTIPw48+29hiZ+mCkIac2qRgWIWPCIZxd5m/p lOaGJxVqrZcxmtkM35MMj+1pw/D2giCCPkG3QT+fpCSO51pUx+yhQZzJ63NPIXVR04Yh OsOA== X-Gm-Message-State: APjAAAU0cnr2MIonZu5TIZSFv7p7QJCGZECMcZAzTzGMmJh9lP7Pscd3 /HHix80w/MDyBaWWh1LBEKo= X-Received: by 2002:a17:902:b688:: with SMTP id c8mr1244877pls.98.1568660349002; Mon, 16 Sep 2019 11:59:09 -0700 (PDT) Received: from SD ([2405:204:828a:aaec:8514:49dd:92d4:793d]) by smtp.gmail.com with ESMTPSA id x8sm37279153pfm.35.2019.09.16.11.59.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Sep 2019 11:59:08 -0700 (PDT) Date: Tue, 17 Sep 2019 00:28:58 +0530 From: Saiyam Doshi To: agross@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] i2c: qup: Remove dev_err() log after platform_get_irq*() failure Message-ID: <20190916185857.GA14093@SD> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The debug message after platform_get_irq() failure is redundant because platform_get_irq() already prints an error. Thus remove it. The semantic patch that makes this report is available in scripts/coccinelle/api/platform_get_irq.cocci. Found using - http://coccinelle.lip6.fr/ Signed-off-by: Saiyam Doshi --- drivers/i2c/busses/i2c-qup.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c index 5519c19bfd9c..23c4893512b2 100644 --- a/drivers/i2c/busses/i2c-qup.c +++ b/drivers/i2c/busses/i2c-qup.c @@ -1767,7 +1767,6 @@ static int qup_i2c_probe(struct platform_device *pdev) qup->irq = platform_get_irq(pdev, 0); if (qup->irq < 0) { - dev_err(qup->dev, "No IRQ defined\n"); return qup->irq; } -- 2.20.1