Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp4579914ybe; Mon, 16 Sep 2019 14:51:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqxn+3IN5pyJxXagF8HHNJqt36+ZT98ziHhlL8lQIafzhktVj3M/C0Vq2pM0T0vqHFSB5mOc X-Received: by 2002:a17:906:c72d:: with SMTP id fj13mr2080990ejb.36.1568670711020; Mon, 16 Sep 2019 14:51:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568670711; cv=none; d=google.com; s=arc-20160816; b=QODJrebu7MDptBn9yJ8smqTmVY+6KrSNsia+CWvI9MY0MBmjoTGXpUtespbyXB8R1F 4EGec0YvLxGkFgn5RW4VyZVruGeAKW2MP23n/G+lEA+yHHn9i4KqK9nH6XTPNCr86VzV egFCoP5JdX0LfsXaKz+54AFaA2YQdCL+Y5jjY0hv9vG/ePtNd1VsBBC5TpWZ5/A09neT 46+gQl6yfsJZ6tpqZ7qAPQLPaLr7CESXQcg4ENBm8zTKMVSLcwpVV9f3talFlgM/Y3OJ 0mbGJzkCHj3JBhMeaKwSGEHmkGsiF01nPUFE8vroy2C14F2jGnos0uRO30NQBGAofk/g Nnww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=K9MMfXShmXoSvIjhKLQWDRDFiDu3n+MfJTN+sGiQ2k4=; b=dRN+5QeMjau7Mry43y3uuTFf8NiDyUrQMS5eYjfUPUOcsOlfzL7lQWohSsyL4yOEdg KXdu4sZxHd6U1k1Sgs7L2mxUC+eSKrc0wMN02JVqIHmz6K9DkaNOr9qbh50GZadbuNyE eXrtZGwXLZfx6LJOu55EWiNdid1oplV2JEEz2gDybEVNOK4HdbnBI9p+cxM1nLs9zWuJ wKwQ/zHVbfKTjaC9brNgyEE3tG4JTW5JP2PHN5W+N3Z+un7h5M8s2ry35cHqbN3E3egN WQoRDBruEDPqr4LMu7F63VITOVpP2Pv8vWfNXiAxN4u+n6fl/Nbny9ERW3hV2kOjg+za 1uXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=bGnQvSym; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o25si175448edr.362.2019.09.16.14.51.27; Mon, 16 Sep 2019 14:51:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=bGnQvSym; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391197AbfIPUD0 (ORCPT + 99 others); Mon, 16 Sep 2019 16:03:26 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:42433 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391188AbfIPUD0 (ORCPT ); Mon, 16 Sep 2019 16:03:26 -0400 Received: by mail-pg1-f195.google.com with SMTP id z12so592392pgp.9 for ; Mon, 16 Sep 2019 13:03:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=K9MMfXShmXoSvIjhKLQWDRDFiDu3n+MfJTN+sGiQ2k4=; b=bGnQvSymIpD+YH+h6yIfRstItOuZOXuFiK941OC9tY+hPxaJDajaYGxSTWmEyJ59JO edv2IMlDsI1aPpPImp4JWxmWc3BNIa/nepq4odIZlM/zb+8bhVhdyaLI37PjRJeuTnuO eJORufmtBiEY4HcYLTPLTJ+aCpVwXDPWAgudDlK/IMDXSRk+qefqWqD19nt7pOm7lmiX J0zvC5m6FNtvofEi14S8wb+u/oC6j0mGdyWyx4DHZc9qSlnNmEYk3S0yNrSp3RLlIBLn X8hNK1p4n+UzumvJ2B/H0n+Ar45St37qsXtGRO7jQU2hEIKRyA1GqUbJ79ncnBgyXful Ocuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=K9MMfXShmXoSvIjhKLQWDRDFiDu3n+MfJTN+sGiQ2k4=; b=j+jqRyTaV0YDa/HgGoZ0rxmBfxW3xhfNjaiZbGTVPIK7BX72H3ovRaI8EAy9Fqmro6 4UAiGX4awsf9n976dZjQFEPP4aNPI699traCHpmo05qRojJAFe5CwqBj3X5TkcfGpIvH kwHf/2IbuCydA5DYqIguws3JWO7GW/v15CcSrs8uBx35GV9OWHeslOb1+dvGQHNNaAEa jDxg6Kon9nnfiLq5iFv/HokkqrmxEjmwp34W8/Imm3j7Lb/uESon4MlSEhzM0QefxdOI +7LVV2CGdc9Fo3dc1KIlaixu1OfAcyuXnQ1goYhHZszfLoaDFG60YtTx9qAJJFSH5UVW CrzQ== X-Gm-Message-State: APjAAAXHp1bhB2HomNDRSAtJ+BmJeDVi0jWOubNaJMVuoPSdbVAsF7aC RBtHTonp6T2KDaNyfjm8qkPOIg== X-Received: by 2002:a63:161b:: with SMTP id w27mr853320pgl.38.1568664204886; Mon, 16 Sep 2019 13:03:24 -0700 (PDT) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id u18sm11141860pge.69.2019.09.16.13.03.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Sep 2019 13:03:24 -0700 (PDT) Date: Mon, 16 Sep 2019 13:03:23 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: syzbot cc: andreyknvl@google.com, benjamin.tissoires@redhat.com, jikos@kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: WARNING in implement In-Reply-To: <0000000000002b27c60592b00f38@google.com> Message-ID: References: <0000000000002b27c60592b00f38@google.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 Sep 2019, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit: f0df5c1b usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb-fuzzer > console output: https://syzkaller.appspot.com/x/log.txt?x=170b213e600000 > kernel config: https://syzkaller.appspot.com/x/.config?x=5c6633fa4ed00be5 > dashboard link: https://syzkaller.appspot.com/bug?extid=38e7237add3712479d65 > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16830dc1600000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=11f2d3fa600000 > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > Reported-by: syzbot+38e7237add3712479d65@syzkaller.appspotmail.com > > keytouch 0003:0926:3333.0001: implement() called with too large value 32769 > (n: 1)! (kworker/0:1) > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 12 at drivers/hid/hid-core.c:1370 > implement.cold+0x40/0x81 drivers/hid/hid-core.c:1370 > Kernel panic - not syncing: panic_on_warn set ... > CPU: 0 PID: 12 Comm: kworker/0:1 Not tainted 5.3.0-rc7+ #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google > 01/01/2011 > Workqueue: events hidinput_led_worker > Call Trace: > __dump_stack lib/dump_stack.c:77 [inline] > dump_stack+0xca/0x13e lib/dump_stack.c:113 > panic+0x2a3/0x6da kernel/panic.c:219 > __warn.cold+0x20/0x4a kernel/panic.c:576 > report_bug+0x262/0x2a0 lib/bug.c:186 > fixup_bug arch/x86/kernel/traps.c:179 [inline] > fixup_bug arch/x86/kernel/traps.c:174 [inline] > do_error_trap+0x12b/0x1e0 arch/x86/kernel/traps.c:272 > do_invalid_op+0x32/0x40 arch/x86/kernel/traps.c:291 > invalid_op+0x23/0x30 arch/x86/entry/entry_64.S:1028 > RIP: 0010:implement.cold+0x40/0x81 drivers/hid/hid-core.c:1370 > Code: 00 ef 01 00 48 c7 c2 a0 ac 52 86 48 c7 c6 c0 8a 52 86 4c 8d 88 70 06 00 > 00 e8 3f 3b 1a fe 48 c7 c7 20 8b 52 86 e8 fc 4e d7 fc <0f> 0b 44 21 e5 e9 06 > 3a ff ff e8 64 ad ec fc 49 8d bd 28 19 00 00 > RSP: 0018:ffff8881da20fb88 EFLAGS: 00010082 > RAX: 0000000000000024 RBX: 0000000000000000 RCX: 0000000000000000 > RDX: 0000000000000000 RSI: ffffffff81288ddd RDI: ffffed103b441f63 > RBP: 0000000000008001 R08: 0000000000000024 R09: ffffed103b643ee7 > R10: ffffed103b643ee6 R11: ffff8881db21f737 R12: 0000000000000001 > R13: ffff8881d28d8000 R14: 0000000000000001 R15: 0000000000000001 > hid_output_field drivers/hid/hid-core.c:1543 [inline] > hid_output_report+0x2dc/0x4c0 drivers/hid/hid-core.c:1562 > __usbhid_submit_report drivers/hid/usbhid/hid-core.c:593 [inline] > usbhid_submit_report+0x65c/0xde0 drivers/hid/usbhid/hid-core.c:638 > usbhid_request+0x3c/0x70 drivers/hid/usbhid/hid-core.c:1252 > hidinput_led_worker+0xbd/0x360 drivers/hid/hid-input.c:1495 > process_one_work+0x92b/0x1530 kernel/workqueue.c:2269 > worker_thread+0x96/0xe20 kernel/workqueue.c:2415 > kthread+0x318/0x420 kernel/kthread.c:255 > ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 I assume this is the same issue as https://marc.info/?l=linux-kernel&m=156865976021549 and any fix for that issue would apply to this one as well. Looks like syzbot found Benjamin and Jiri already.