Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp4644475ybe; Mon, 16 Sep 2019 16:09:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqzUdk0QvGNyPt5r2fd7VYTC/bIeixOsHSkqUo4TrqiQn2Bue9c3YjxMIYDg9/wkSCW/TE49 X-Received: by 2002:aa7:c71a:: with SMTP id i26mr1842912edq.68.1568675378575; Mon, 16 Sep 2019 16:09:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568675378; cv=none; d=google.com; s=arc-20160816; b=AfSVSttE3mmJt3XQOsbDdfw7Krx2aM8kc8a7Nz9LUEMKKVyXe2fP8n92TFwa6cIrK8 fRv8RTBh8JpcBmPecEKslw75bFERosmugjgfBCeVJmgisa9c/cSocatfqKV1MambRz8g LYN9ZGD4/KRhCWMZ8FQ2khxMMC8ygJMCYmqJa3+Zh06y/R8HcxCkCAt5WDTn24pEKZXZ s6vto6xe07j5sxyfxITGcqh4Qs7gW5i/FDCyVv0DyiiiHkr/aBLiRf8OxtpUv0noujkR r5ndBdl8woSzcfu9wjmm//qLVyEmOV6NfH/bj1sF8+0uTnDVVufteH0UBSsa6mlH9zNR 2FfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=5s0xpZGS83FwiMvCo1TIQP0cn/VBzbnyICFgBZ0OB8Y=; b=HirXywi6WWHvjynCnZP4Uo72tWR8anEBcSmFUS/ClEvBwOSg1ExssKY6jGWsp/+AGI weQsijQvc2oIOZ90v2eqbWBqv4pwREuX58s7YOS1wl0Sk8gYNyYgwfprKBp2DWzq0aDP ffjLnnMI6pGRCgWadvrncL81BvbBm4A7GY9LxgMHCDclXvT/vjLFM1rJLUrrXBknlpnm Rx8BTnYtRvWctfMhrK6JZycMp3NdR2ArNgIJkzJjMpfGiSnlO3tZPJbwOij+6RI8IvBS 1lMPVP5d3AADqQ8t+ZdDNqlP5JU7sFNxT5+yIZBvAxbm+7DugL3eKV3a4vgwmtXmo89I t9fg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=oRZloT25; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n2si298453edt.408.2019.09.16.16.09.15; Mon, 16 Sep 2019 16:09:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=oRZloT25; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732993AbfIPWTf (ORCPT + 99 others); Mon, 16 Sep 2019 18:19:35 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:38251 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728917AbfIPWTe (ORCPT ); Mon, 16 Sep 2019 18:19:34 -0400 Received: by mail-pl1-f196.google.com with SMTP id w10so524503plq.5 for ; Mon, 16 Sep 2019 15:19:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5s0xpZGS83FwiMvCo1TIQP0cn/VBzbnyICFgBZ0OB8Y=; b=oRZloT25WgrG1A2E2/rG1KEJTsek/VSatAe1mECK70Mcns8rFB4oQSbaFfzWOC5w+M Xag6HGDZ5qz6fjMSOpYUmXJmJou5XfUcqmOTGP6pBjRziIzzNqZaUy3miVy+F4viGeqf GvJ+WpgDdjCraSnaMKdWGwKfJf5MQwf0ojIHE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5s0xpZGS83FwiMvCo1TIQP0cn/VBzbnyICFgBZ0OB8Y=; b=CcgiDo9k1J3BBuD/4NpMikvbePTHRJLYgzerB2huV5l8dCYyZbmUBIcqcIvH8VP3n1 3U5jTmqA8MianFqZB+DCCZgsd2GngIZ5DWZkDwJqhS1ff7DfJ8iMROAP3IC/zBiBhbjJ i2zrAT1bxLbNpgsf1cdr0GEuUeM/FctrFKHUBj3xjjUqTYCk3gNcZYLCfds80A+LU1Ic N5c5cDaNDk9L1DwL0NrjUrlG3vMjTTG+DVWm0orcPBuVeONUIpG0bUq2vfoI/cME/MWw +vckk0vbs8Z+BZ215Q0UpTi3w8RO9Cd2ZJ0cL2qSoIJViehHzv89XtkLJX0cWnEeHwla 6u+w== X-Gm-Message-State: APjAAAU/aBj2qEwLBEHcblHjTcaTahgbgoJpCN6ZTIXa9yD6iA52J8jR 1UcbcTJZynGdI7EqPCBY/eLSyg== X-Received: by 2002:a17:902:8f8e:: with SMTP id z14mr397883plo.3.1568672374134; Mon, 16 Sep 2019 15:19:34 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id k5sm113363pfp.109.2019.09.16.15.19.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Sep 2019 15:19:33 -0700 (PDT) Date: Mon, 16 Sep 2019 15:19:32 -0700 From: Kees Cook To: Joe Perches Cc: hpa@zytor.com, Peter Zijlstra , Pavel Machek , Linus Torvalds , Miguel Ojeda , Borislav Petkov , Thomas Gleixner , Ingo Molnar , "Gustavo A . R . Silva" , Arnaldo Carvalho de Melo , Kan Liang , Namhyung Kim , Jiri Olsa , Alexander Shishkin , Shawn Landden , x86@kernel.org, linux-kernel@vger.kernel.org Subject: treewide replacement of fallthrough comments with "fallthrough" macro (was Re: [RFC PATCH] compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use) Message-ID: <201909161516.A68C8239A@keescook> References: <1d2830aadbe9d8151728a7df5b88528fc72a0095.1564549413.git.joe@perches.com> <20190731171429.GA24222@amd> <765E740C-4259-4835-A58D-432006628BAC@zytor.com> <20190731184832.GZ31381@hirez.programming.kicks-ass.net> <201907311301.EC1D84F@keescook> <201908151049.809B9AFBA9@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201908151049.809B9AFBA9@keescook> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 15, 2019 at 11:15:53AM -0700, Kees Cook wrote: > With that out of the way, yes, let's do a mass conversion. As mentioned > before, I think "fallthrough;" should be used here (to match "break;"). > Let's fork the C language. :) FWIW, last week I asked Linus at the maintainer's summit which he preferred ("__fallthrough" or "fallthrough") and he said "fallthrough". Joe, if you've still got the series ready, do you want to send it for this merge window before -rc1 gets cut? -- Kees Cook