Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp4667614ybe; Mon, 16 Sep 2019 16:38:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqwq3qOq5T8/YzXztMTFn4XO7MlrEU214w3ht5bMl4ftxQOjRgx4I6cQjzux7l6VIhJeRkuY X-Received: by 2002:aa7:c995:: with SMTP id c21mr1892435edt.129.1568677104957; Mon, 16 Sep 2019 16:38:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568677104; cv=none; d=google.com; s=arc-20160816; b=rQRx8SZ7zEu5buUxi90PLfEtYCPkNSZorFtY423MGVu9+h38xPThF5DkqEGOAOJlxr nxZpGFU5xXECdEH9MzVgvKnOMQ61Qwt3sQ9UDC49kq189DgFAMWz0/RkNHCLieKxA/bg eJBAMnD4L0qGVi489PO3RGqjsPMkWzXYWfGIuCaWkRzDEPHMGc2u6E9xOhmW7rRq3psg v+cxcVeq/pY6j4kg0qhBtK/HjSeJ50A61muDe2Aw6vTnbGE7Bcc/MTdYKunWrj6a8j2g 3WBEINV4SQZi6xDLNR/zKRSelUOzQvILx0kbrQAqxb9QcBVjQ4hKJd9agwRwa88jRQdu ji5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=iWvWv1HPrQnQjyUk9XeD2lLbQAyjylL6kEmzCwJ3gPc=; b=TpstFEUY6ZZI8NsMwSEYzUy2t5v4ESK3HU2AWqjVEALq/+8UVbDyjdY5YktmsGp+j/ dg28NkIaOY9EPL7b4ao7VUZ4S7uGsfeUOBvdZuANAwO/MWZR6KQV/066Zuyfx7Wun2Dd Djl/PTnDV7m912tAk7+1UDQHc3gHuMsSvZSuvl/QbBASG9I5CWknc0RHz+kcJPGJCoNi Ux3vBMOC59a5wwvAVkSnd0C/z7QJ3jMZYbPnQkdxHUi2ixVnvUfeA93AUqoGHJwNktaf MyTzNPGoqQNBg9cDh5CacwdhbUl3E8gnHmYOuT+ogx8SbZ18QGSa/mChkrGnKJM6m75j d0hA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u8si354581edq.84.2019.09.16.16.38.00; Mon, 16 Sep 2019 16:38:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388499AbfIPOJU (ORCPT + 99 others); Mon, 16 Sep 2019 10:09:20 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:57166 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728149AbfIPOJU (ORCPT ); Mon, 16 Sep 2019 10:09:20 -0400 Received: from turingmachine.home (unknown [IPv6:2804:431:c7f4:d32a:d711:794d:1c68:5ed3]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tonyk) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 510EB28D456; Mon, 16 Sep 2019 15:09:16 +0100 (BST) From: =?UTF-8?q?Andr=C3=A9=20Almeida?= To: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: axboe@kernel.dk, kernel@collabora.com, krisman@collabora.com, =?UTF-8?q?Andr=C3=A9=20Almeida?= , Chaitanya Kulkarni Subject: [PATCH v3 2/3] null_blk: match the type of parameter nr_devices Date: Mon, 16 Sep 2019 11:07:58 -0300 Message-Id: <20190916140759.52491-3-andrealmeid@collabora.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190916140759.52491-1-andrealmeid@collabora.com> References: <20190916140759.52491-1-andrealmeid@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since the variable nr_devices is an unsigned int, the module_param() should also use this type. Change the type so they can match. Fixes: f7c4ce890dd2 ("null_blk: validate the number of devices") Reviewed-by: Chaitanya Kulkarni Signed-off-by: André Almeida --- Changes since v2: - None Changes since v1: - Add "Fixes" tag --- drivers/block/null_blk_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/null_blk_main.c b/drivers/block/null_blk_main.c index be32cb5ed339..5d20d65041bd 100644 --- a/drivers/block/null_blk_main.c +++ b/drivers/block/null_blk_main.c @@ -142,7 +142,7 @@ module_param_named(bs, g_bs, int, 0444); MODULE_PARM_DESC(bs, "Block size (in bytes)"); static unsigned int nr_devices = 1; -module_param(nr_devices, int, 0444); +module_param(nr_devices, uint, 0444); MODULE_PARM_DESC(nr_devices, "Number of devices to register"); static bool g_blocking; -- 2.23.0