Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp4668522ybe; Mon, 16 Sep 2019 16:39:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqzP3tWDeHfyCClrvateMg77DDqul+LJDbBANk5cdbxCEQfk6tXz91DHeC9KjQtLLnF47Sqk X-Received: by 2002:a50:99d5:: with SMTP id n21mr1913969edb.50.1568677178244; Mon, 16 Sep 2019 16:39:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568677178; cv=none; d=google.com; s=arc-20160816; b=GpPO6beQNzvL/PpVIpL92ibwedaImNnnIb47A0w45illJf1RiSxhOaEl1roERxq/4V U29D7a9zb86Ev6BQbG/Jt583ju2kdJl6unsgM3bP/fNdAPl3MlgxthopKfcoSMKYxIOZ +TF/wl3oYDMFm6j0S7HrKV1rAbUAQr91uQxqFBI64bxgCPq4+zT7cCGydEueGemQGS60 eQHbWKAYLYl1q4q7q8A8/BZMJPrBuwDo2/jxtrlOFamuE4Jje8QPRge8ibjE+Dmr/8yU +J/o0Psu0ssnB7Yxw6kzg71l7gcqN7DGTNypimT3qtcrU5eEs0VljDtRyWNcp3RlpL0F BNZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=9Oh32om0eV3j31nJG2VS51JVQa8emQTwkRPDSxkpg4o=; b=wSsdF8KasUI1kc+iDIx7XUEt775d9w3z6wTQYNuHYwDDd/zEiNN9uXq16eHg2e0wyJ lJXFsT0I8/t/7s4HgrG+aJliHO6OPmLlkAsTN6LwyWNXxj0/Y1bIchOkEIFoM0PIwd2o n7eSOUCqZjnr10NNxxczXgWz/m72nxMe/UZtM0kaWvZHZclSQxH+s3cWL3BdcaBnCK+1 Vj4oWrqlWDhGcykJLDl6JqlYd/2ngKgLkBrUL12pIuGslWWBQarBTQHwRx8G77BiAKw9 a4Lu6unvzBJJ1yAXFevzvA42oES3DTz1/EmBsoET52jjzkXrA93WuwS3L/ZXNOtZoxHu sANw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id hh22si222270ejb.61.2019.09.16.16.39.14; Mon, 16 Sep 2019 16:39:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388600AbfIPOZw (ORCPT + 99 others); Mon, 16 Sep 2019 10:25:52 -0400 Received: from mga14.intel.com ([192.55.52.115]:27569 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726657AbfIPOZw (ORCPT ); Mon, 16 Sep 2019 10:25:52 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Sep 2019 07:25:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,512,1559545200"; d="scan'208";a="216219933" Received: from mataylo1-mobl2.amr.corp.intel.com (HELO [10.254.92.190]) ([10.254.92.190]) by fmsmga002.fm.intel.com with ESMTP; 16 Sep 2019 07:25:50 -0700 Subject: Re: [PATCH] x86/boot/64: Make level2_kernel_pgt pages invalid outside kernel area. To: "Kirill A. Shutemov" , Steve Wahl , Dave Hansen Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, Juergen Gross , Brijesh Singh , Jordan Borgner , Feng Tang , linux-kernel@vger.kernel.org, Baoquan He , russ.anderson@hpe.com, dimitri.sivanich@hpe.com, mike.travis@hpe.com References: <20190906212950.GA7792@swahl-linux> <20190909081414.5e3q47fzzruesscx@box> <20190910142810.GA7834@swahl-linux> <20190911002856.mx44pmswcjfpfjsb@box.shutemov.name> <20190911200835.GD7834@swahl-linux> <20190912101917.mbobjvkxhfttxddd@box> <20190913151415.GG7834@swahl-linux> <20190916090058.mteofmkkl37ob47k@box.shutemov.name> From: Dave Hansen Openpgp: preference=signencrypt Autocrypt: addr=dave.hansen@intel.com; keydata= mQINBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABtEVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT6JAjgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lcuQINBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABiQIfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y Message-ID: <4de3e0c2-7b59-c325-8d88-58220d721f71@intel.com> Date: Mon, 16 Sep 2019 07:25:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190916090058.mteofmkkl37ob47k@box.shutemov.name> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/16/19 2:00 AM, Kirill A. Shutemov wrote: >>> I think we also need to make it clear that this is workaround for a broken >>> hardware: speculative execution must not trigger a halt. >> I think the word broken is a bit loaded here. According to the UEFI >> spec (version 2.8, page 167), "Regions that are backed by the physical >> hardware, but are not supposed to be accessed by the OS, must be >> returned as EfiReservedMemoryType." Our interpretation is that >> includes speculative accesses. > +Dave. > > I don't think it is. Speculative access is done by hardware, not OS. > > BTW, isn't it a BIOS issue? > > I believe it should have a way to hide a range of physical address space > from OS or force a caching mode on to exclude it from speculative > execution. Like setup MTRRs or something. Ugh. I bet that was a fun one to chase down. Have the hardware engineers learned a lesson or are they hiding behind the EFI spec in an act of pure cowardice? ;) The patch is small and fixes a real problem. The changelog is OK, although I'd prefer some differentiation between "occupied by the kernel" and the kernel *image*. The code is also gloriously free of any comments about what it's doing or why. But, I'm left with lots of questions: Why do PMD-level changes fix this? Is it because we 2MB pad the kernel image? Why can't we still get within 2MB of the memory address in question? Is it in the lower 1MB, by chance? If this is all about avoiding EFI reserved ranges, why doesn't the patch *LOOK* At EFI reserved ranges?