Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964785AbVL1LCD (ORCPT ); Wed, 28 Dec 2005 06:02:03 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964787AbVL1LCB (ORCPT ); Wed, 28 Dec 2005 06:02:01 -0500 Received: from cantor2.suse.de ([195.135.220.15]:4310 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S964785AbVL1LCA (ORCPT ); Wed, 28 Dec 2005 06:02:00 -0500 To: "Bryan O'Sullivan" Cc: Matt Mackall , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [RFC] [PATCH] Add memcpy32 function References: <1135301759.4212.76.camel@serpentine.pathscale.com> From: Andi Kleen Date: 28 Dec 2005 12:01:49 +0100 In-Reply-To: <1135301759.4212.76.camel@serpentine.pathscale.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 695 Lines: 12 Bryan O'Sullivan writes: > In response to the comments that followed Roland Dreier posting our > InfiniPath driver for review last week, we've been making some cleanups > to our driver code. What irritates me is that the original author said this copy would happen from user space in ipath. In that case you would need exception handling for all memory accesses to return EFAULT, otherwise everybody can crash the kernel. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/