Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5d7fe5d1.1c69fb81.eca3b.1121@mx.google.com>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20190912091019.5334-1-srinivas.kandagatla@linaro.org>
References: <20190912091019.5334-1-srinivas.kandagatla@linaro.org>
Cc:     linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        andy.gross@linaro.org, bjorn.andersson@linaro.org
From:   Stephen Boyd <swboyd@chromium.org>
Subject: Re: [PATCH] soc: qcom: socinfo: add missing soc_id sysfs entry
User-Agent: alot/0.8.1
Date:   Mon, 16 Sep 2019 12:43:11 -0700
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Srinivas Kandagatla (2019-09-12 02:10:19)
> looks like SoC ID is not exported to sysfs for some reason.
> This patch adds it!
>=20
> This is mostly used by userspace libraries like SNPE.

What is SNPE?

>=20
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
>  drivers/soc/qcom/socinfo.c | 2 ++
>  1 file changed, 2 insertions(+)

Hmm I wasn't aware this driver was merged.

>=20
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index 8dc86a74559b..876a3f6612a3 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -422,6 +422,8 @@ static int qcom_socinfo_probe(struct platform_device =
*pdev)
>         qs->attr.family =3D "Snapdragon";
>         qs->attr.machine =3D socinfo_machine(&pdev->dev,
>                                            le32_to_cpu(info->id));
> +       qs->attr.soc_id =3D devm_kasprintf(&pdev->dev, GFP_KERNEL, "%u",
> +                                        le32_to_cpu(info->id));
>         qs->attr.revision =3D devm_kasprintf(&pdev->dev, GFP_KERNEL, "%u.=
%u",
>                                            SOCINFO_MAJOR(le32_to_cpu(info=
->ver)),
>                                            SOCINFO_MINOR(le32_to_cpu(info=
->ver)));