Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 2/2] powerpc/83xx: map IMMR with a BAT.
To:     Scott Wood <oss@buserror.net>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        galak@kernel.crashing.org
Cc:     linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
References: <966e6d6a226f9786098d296239a6c65064e73a41.1568616151.git.christophe.leroy@c-s.fr>
 <7f8f9747ef1ab2e1261cf83b03c1da321d47f7b7.1568616151.git.christophe.leroy@c-s.fr>
 <71490f3b94b851106eb48c8909239f401d0018d1.camel@buserror.net>
From:   Christophe Leroy <christophe.leroy@c-s.fr>
Message-ID: <faa12987-1c3d-b554-de03-cb1be34112ad@c-s.fr>
Date:   Mon, 16 Sep 2019 22:18:05 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <71490f3b94b851106eb48c8909239f401d0018d1.camel@buserror.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: fr
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Le 16/09/2019 à 17:04, Scott Wood a écrit :
> On Mon, 2019-09-16 at 06:42 +0000, Christophe Leroy wrote:
>> @@ -145,6 +147,15 @@ void __init mpc83xx_setup_arch(void)
>>   	if (ppc_md.progress)
>>   		ppc_md.progress("mpc83xx_setup_arch()", 0);
>>   
>> +	if (!__map_without_bats) {
>> +		phys_addr_t immrbase = get_immrbase();
>> +		int immrsize = IS_ALIGNED(immrbase, SZ_2M) ? SZ_2M : SZ_1M;
>> +		unsigned long va = __fix_to_virt(FIX_IMMR_BASE);
> 
> Why __fix_to_virt() and not fix_to_virt()?
> 

Euh ... because I copy/pasted it from 
/arch/powerpc/include/asm/nohash/32/mmu-8xx.h

But yes I can do fix_to_virt() instead.

Christophe