Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp5059855ybe; Tue, 17 Sep 2019 01:47:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqxclsmE+YHbjCqcBztqqTG8+fESKuF47HdQj71yZqevukKXEQkDiau5A8ngd/Oyer9A4Fau X-Received: by 2002:aa7:d40d:: with SMTP id z13mr3307423edq.229.1568710024617; Tue, 17 Sep 2019 01:47:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568710024; cv=none; d=google.com; s=arc-20160816; b=I4A7zgddDUvOsU9EWvhVJAeWCiCjoHwgBYfScvgv5AYgz3QHsJ0yjCtY3c5s0SFtx9 UbhZhAgOLjrUN69OhtFGBDfdCRR/NRwYhpTAgQXBtg1rbdPk/hO6pnF8vODqpHFkKVzW R6EJm/aWnxZbnSlrBOC1dmWD3cRO6Gh6EznaTbz8VS3NT39Asrz0pL5VvwaRgTqB4D/0 Peti488hqWc9Vf24PQvLzAuyN0L/xeImq7s9/8uugb5+Nz9gZPQ4uas0Ip2OqGskQuNJ dmQ0mpgsxUrSWcKzIwtFi4hhZAoO9SV/f1U2q8qmfuFGf9M7BB8ne3uEvI7buOl2WYcw xy2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=110YKEIdeUHUxrvbKP61OTrEG72EywPL0kpLDzCelKA=; b=STh2YEjwpbdPDU02dvWXEIEq0SVEhM6kM6PTHwBv59xfJ5owdksRxVQdifP8Vptsjn nZyLvJ4bBJq6YjI9NzgmF0zNl37bJsoI0BpQM+3xzlZlgrscCeB6S784TScDWTxfKNRl wDwxUmVFERJm8mcSEKvkGrKqEs4kAHH2rStPOZPyk+QwtABx60hRVTAUE0ZDGdSVVYu9 bpihU6mnHmtx7shaF+/qadABM3nmfrlll1LnPBVTWUk7pqCii96vQaiT5HUowcHRCwPg dkbFR0FckwTukd+IPpe+95jOKieeDp9VadMH4kchCSCKRt7kAgHFgGljBqMctVHHnLdR +haw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x30si923915edi.351.2019.09.17.01.46.41; Tue, 17 Sep 2019 01:47:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733077AbfIPWTr (ORCPT + 99 others); Mon, 16 Sep 2019 18:19:47 -0400 Received: from mga17.intel.com ([192.55.52.151]:56687 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728917AbfIPWTr (ORCPT ); Mon, 16 Sep 2019 18:19:47 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Sep 2019 15:19:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,514,1559545200"; d="scan'208";a="198489056" Received: from ray.jf.intel.com (HELO [10.7.201.140]) ([10.7.201.140]) by orsmga002.jf.intel.com with ESMTP; 16 Sep 2019 15:19:45 -0700 Subject: Re: [PATCH] x86/boot/64: Make level2_kernel_pgt pages invalid outside kernel area. To: Steve Wahl Cc: "Kirill A. Shutemov" , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, Juergen Gross , Brijesh Singh , Jordan Borgner , Feng Tang , linux-kernel@vger.kernel.org, Baoquan He , russ.anderson@hpe.com, dimitri.sivanich@hpe.com, mike.travis@hpe.com References: <20190906212950.GA7792@swahl-linux> <20190909081414.5e3q47fzzruesscx@box> <20190910142810.GA7834@swahl-linux> <20190911002856.mx44pmswcjfpfjsb@box.shutemov.name> <20190911200835.GD7834@swahl-linux> <20190912101917.mbobjvkxhfttxddd@box> <20190913151415.GG7834@swahl-linux> <20190916090058.mteofmkkl37ob47k@box.shutemov.name> <4de3e0c2-7b59-c325-8d88-58220d721f71@intel.com> <20190916171455.GJ7834@swahl-linux> From: Dave Hansen Openpgp: preference=signencrypt Autocrypt: addr=dave.hansen@intel.com; keydata= mQINBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABtEVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT6JAjgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lcuQINBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABiQIfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y Message-ID: Date: Mon, 16 Sep 2019 15:19:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190916171455.GJ7834@swahl-linux> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/16/19 10:14 AM, Steve Wahl wrote: > I'm intending to add something like this in the next version: > > /* > * Only the region occupied by the kernel image has so far been checked against > * the table of usable memory regions provided by the firmware, so > * invalidate pages outside that region. A page table entry that maps to > * a reserved area of memory would allow processor speculation into that > * area, and on some hardware (particularly the UV platform) speculation > * into reserved areas can cause a system halt. > */ This is a good start, but it's a bit imprecise. The KASLR code ensures that the kernel image itself doesn't overlap a reserved area, but it appears that we're mapping more than strictly just the kernel image. >> But, I'm left with lots of questions: >> >> Why do PMD-level changes fix this? Is it because we 2MB pad the kernel >> image? Why can't we still get within 2MB of the memory address in >> question? > > This fix works for our hardware because the problematic reserved > regions are 64M aligned, and going up to the next 2MB boundary from > _end is not going to cross the next 64M boundary. I'd really prefer that we fix this once and for all rather than kicking the can down the road to the next hardware manufacturer that changes the alignment. > One could argue the next step would be going into > boot/compressed/{kaslr.c, misc.c} and rounding the size of the kernel > up to the next 2MB boundary to ensure the chosen random location is > covered by usable RAM up to the next PMD-level boundary. I did not go > there because for us it is not necessary. Doing this would *fully* fix this issue, right? Seems like the right thing to do to me. >> If this is all about avoiding EFI reserved ranges, why doesn't the >> patch *LOOK* At EFI reserved ranges? > > Because the range the kernel image is located in is already checked > against them in boot/compressed/kaslr.c. This will now be explained > in the comment I mention above, which you had not yet seen. Ahh, thanks for the explanation. This will make for good changelog material.