Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roman Gushchin <guro@fb.com>
To:     Johannes Weiner <hannes@cmpxchg.org>
CC:     "linux-mm@kvack.org" <linux-mm@kvack.org>,
        Michal Hocko <mhocko@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kernel Team <Kernel-team@fb.com>,
        "Shakeel Butt" <shakeelb@google.com>,
        Vladimir Davydov <vdavydov.dev@gmail.com>,
        "Waiman Long" <longman@redhat.com>
Subject: Re: [PATCH RFC 01/14] mm: memcg: subpage charging API
Thread-Topic: [PATCH RFC 01/14] mm: memcg: subpage charging API
Thread-Index: AQHVZDNmLHUfmxN6PU+s0PWXiLpdV6cuU9OAgADimoA=
Date:   Tue, 17 Sep 2019 02:27:19 +0000
Message-ID: <20190917022713.GB8073@castle.DHCP.thefacebook.com>
References: <20190905214553.1643060-1-guro@fb.com>
 <20190905214553.1643060-2-guro@fb.com> <20190916125611.GB29985@cmpxchg.org>
In-Reply-To: <20190916125611.GB29985@cmpxchg.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [2620:10d:c090:180::f4fb]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9cee9a43-2d5e-411a-faed-08d73b168fa2
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600167)(711020)(4605104)(1401327)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);SRVR:BYAPR15MB3270;
x-ms-traffictypediagnostic: BYAPR15MB3270:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BYAPR15MB327027A6F2A3F254413E6A13BE8F0@BYAPR15MB3270.namprd15.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 01630974C0
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(136003)(39860400002)(376002)(346002)(396003)(199004)(189003)(71190400001)(6436002)(476003)(446003)(46003)(256004)(478600001)(14444005)(386003)(6506007)(6916009)(316002)(52116002)(71200400001)(76176011)(99286004)(6486002)(33656002)(186003)(102836004)(6512007)(6246003)(229853002)(7736002)(305945005)(81166006)(54906003)(14454004)(11346002)(6116002)(5660300002)(8676002)(81156014)(4326008)(25786009)(66946007)(66446008)(86362001)(8936002)(9686003)(2906002)(66476007)(66556008)(64756008)(1076003)(486006);DIR:OUT;SFP:1102;SCL:1;SRVR:BYAPR15MB3270;H:BYASPR01MB0023.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: 5rEVywGbj+F/PcDJV6aI+IJ4PFo087E/zyQVjiu9lQSjqGt7YWTW/CBEKaD/ohHQp40Z9wXFOvooCqAHMSQK1N+fCMSwXS9VvCNuacUuphW+AASooiYuiTy2lKhRS7uxIjqT7raQzfmC3ePxFhg03pX9ZA5QXo5FIpc9O/C9vuZSN/YTzBD+EeL94LI31/RNxchDrS19lVpMGZtwqItEhNQV7zxrFBlCGS29js+pkEPk/abUXH1kxc8hdjPVWQ4uP381BzsZayU3SnQAV8FgCXkUtMUR8u9rAzK1lAjTXrxc7oo3vzBKM13Q+N4HkX0X3wh+H/WgIBWo7EwX8qFDxMcysIxJk6kOZpOSvmhDroGpLWaP+iaw/Xq5J1xxEbHO8fJd7SRRj/MqoQGDQWKZHZyWEO0KNAmg/tf6uSpocNg=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D1B9D466394C5F4994BD39812EE0C5F9@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9cee9a43-2d5e-411a-faed-08d73b168fa2
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Sep 2019 02:27:20.5802
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: j/SiwhMxuYf9qn/16GbQbt2nlSB2I5DVkj4cFFTfx0zxvx7C4m4Ms7EVAYlAoQ5t
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3270
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8
 definitions=2019-09-17_01:2019-09-11,2019-09-17 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 bulkscore=0
 mlxlogscore=999 malwarescore=0 spamscore=0 clxscore=1015 impostorscore=0
 mlxscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 adultscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-1908290000 definitions=main-1909170026
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Sep 16, 2019 at 02:56:11PM +0200, Johannes Weiner wrote:
> On Thu, Sep 05, 2019 at 02:45:45PM -0700, Roman Gushchin wrote:
> > Introduce an API to charge subpage objects to the memory cgroup.
> > The API will be used by the new slab memory controller. Later it
> > can also be used to implement percpu memory accounting.
> > In both cases, a single page can be shared between multiple cgroups
> > (and in percpu case a single allocation is split over multiple pages),
> > so it's not possible to use page-based accounting.
> >=20
> > The implementation is based on percpu stocks. Memory cgroups are still
> > charged in pages, and the residue is stored in perpcu stock, or on the
> > memcg itself, when it's necessary to flush the stock.
>=20
> Did you just implement a slab allocator for page_counter to track
> memory consumed by the slab allocator?

:)

>=20
> > @@ -2500,8 +2577,9 @@ void mem_cgroup_handle_over_high(void)
> >  }
> > =20
> >  static int try_charge(struct mem_cgroup *memcg, gfp_t gfp_mask,
> > -		      unsigned int nr_pages)
> > +		      unsigned int amount, bool subpage)
> >  {
> > +	unsigned int nr_pages =3D subpage ? ((amount >> PAGE_SHIFT) + 1) : am=
ount;
> >  	unsigned int batch =3D max(MEMCG_CHARGE_BATCH, nr_pages);
> >  	int nr_retries =3D MEM_CGROUP_RECLAIM_RETRIES;
> >  	struct mem_cgroup *mem_over_limit;
> > @@ -2514,7 +2592,9 @@ static int try_charge(struct mem_cgroup *memcg, g=
fp_t gfp_mask,
> >  	if (mem_cgroup_is_root(memcg))
> >  		return 0;
> >  retry:
> > -	if (consume_stock(memcg, nr_pages))
> > +	if (subpage && consume_subpage_stock(memcg, amount))
> > +		return 0;
> > +	else if (!subpage && consume_stock(memcg, nr_pages))
> >  		return 0;
>=20
> The layering here isn't clean. We have an existing per-cpu cache to
> batch-charge the page counter. Why does the new subpage allocator not
> sit on *top* of this, instead of wedged in between?
>=20
> I think what it should be is a try_charge_bytes() that simply gets one
> page from try_charge() and then does its byte tracking, regardless of
> how try_charge() chooses to implement its own page tracking.
>=20
> That would avoid the awkward @amount + @subpage multiplexing, as well
> as annotating all existing callsites of try_charge() with a
> non-descript "false" parameter.
>=20
> You can still reuse the stock data structures, use the lower bits of
> stock->nr_bytes for a different cgroup etc., but the charge API should
> really be separate.

Hm, I kinda like the idea, however there is a complication: for the subpage
accounting the css reference management is done in a different way, so that
all existing code should avoid changing the css refcounter. So I'd need
to pass a boolean argument anyway.

But let me try to write this down, hopefully v2 will be cleaner.

Thank you!