Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <5ca714b7bbd12ce24a6e8cc278eb438c576fa75d.1568627608.git.baolin.wang@linaro.org>
In-Reply-To: <5ca714b7bbd12ce24a6e8cc278eb438c576fa75d.1568627608.git.baolin.wang@linaro.org>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Tue, 17 Sep 2019 10:09:07 +0200
Message-ID: <CAMpxmJVBzOwZ7JaySzq1bZkEtwEfMSu_e8dGTSEiY6wG0d=KiQ@mail.gmail.com>
Subject: Re: [PATCH] gpio: eic: sprd: Fix the incorrect EIC offset when toggling
To:     Baolin Wang <baolin.wang@linaro.org>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Orson Zhai <orsonzhai@gmail.com>,
        Lyra Zhang <zhang.lyra@gmail.com>, bruce.chen@unisoc.com,
        linux-gpio <linux-gpio@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

pon., 16 wrz 2019 o 11:57 Baolin Wang <baolin.wang@linaro.org> napisa=C5=82=
(a):
>
> From: Bruce Chen <bruce.chen@unisoc.com>
>
> When toggling the level trigger to emulate the edge trigger, the
> EIC offset is incorrect without adding the corresponding bank index,
> thus fix it.
>
> Fixes: 7bf0d7f62282 ("gpio: eic: Add edge trigger emulation for EIC")
> Signed-off-by: Bruce Chen <bruce.chen@unisoc.com>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> ---
>  drivers/gpio/gpio-eic-sprd.c |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c
> index 7b9ac4a..090539f 100644
> --- a/drivers/gpio/gpio-eic-sprd.c
> +++ b/drivers/gpio/gpio-eic-sprd.c
> @@ -530,11 +530,12 @@ static void sprd_eic_handle_one_type(struct gpio_ch=
ip *chip)
>                 }
>
>                 for_each_set_bit(n, &reg, SPRD_EIC_PER_BANK_NR) {
> -                       girq =3D irq_find_mapping(chip->irq.domain,
> -                                       bank * SPRD_EIC_PER_BANK_NR + n);
> +                       u32 offset =3D bank * SPRD_EIC_PER_BANK_NR + n;
> +
> +                       girq =3D irq_find_mapping(chip->irq.domain, offse=
t);
>
>                         generic_handle_irq(girq);
> -                       sprd_eic_toggle_trigger(chip, girq, n);
> +                       sprd_eic_toggle_trigger(chip, girq, offset);
>                 }
>         }
>  }
> --
> 1.7.9.5
>

Queued for fixes.

Bart