Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190917085627.4562-1-mail@aurabindo.in>
In-Reply-To: <20190917085627.4562-1-mail@aurabindo.in>
From:   Baolin Wang <baolin.wang@linaro.org>
Date:   Tue, 17 Sep 2019 17:23:13 +0800
Message-ID: <CAMz4kuJczzjTPSohQ=kbZ0Pr7U_9-hzXk-jPgKk79PENOM1-dA@mail.gmail.com>
Subject: Re: [PATCH] spi: sifive: check return value for platform_get_resource()
To:     Aurabindo Jayamohanan <mail@aurabindo.in>
Cc:     Mark Brown <broonie@kernel.org>, palmer@sifive.com,
        paul.walmsley@sifive.com, linux-spi <linux-spi@vger.kernel.org>,
        linux-riscv@lists.infradead.org,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 17 Sep 2019 at 17:12, Aurabindo Jayamohanan <mail@aurabindo.in> wrote:
>
> platform_get_resource() may return NULL. If it is so, return -ENXIO
>
> Signed-off-by: Aurabindo Jayamohanan <mail@aurabindo.in>
> ---
>  drivers/spi/spi-sifive.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/spi/spi-sifive.c b/drivers/spi/spi-sifive.c
> index 93ec2c6cdbfd..67485067a694 100644
> --- a/drivers/spi/spi-sifive.c
> +++ b/drivers/spi/spi-sifive.c
> @@ -308,6 +308,12 @@ static int sifive_spi_probe(struct platform_device *pdev)
>         platform_set_drvdata(pdev, master);
>
>         res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +       if (!res) {
> +               dev_err(&pdev->dev, "no IOMEM resource found\n");
> +               ret = -ENXIO;
> +               goto put_master;
> +       }

Seems unnecessary, the devm_ioremap_resource() already validated if
the resource is available.

-- 
Baolin Wang
Best Regards