Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 17 Sep 2019 12:55:19 +0200
From:   Lars Poeschel <poeschel@lemonage.de>
To:     David Miller <davem@davemloft.net>
Cc:     allison@lohutok.net, keescook@chromium.org, opensource@jilayne.com,
        swinslow@gmail.com, gregkh@linuxfoundation.org,
        gustavo@embeddedor.com, tglx@linutronix.de,
        kstewart@linuxfoundation.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, johan@kernel.org
Subject: Re: [PATCH v7 6/7] nfc: pn533: Add autopoll capability
Message-ID: <20190917105519.GB18936@lem-wkst-02.lemonage>
References: <20190910093415.2186-1-poeschel@lemonage.de>
 <20190911.101759.1557703938346599792.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190911.101759.1557703938346599792.davem@davemloft.net>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Sep 11, 2019 at 10:17:59AM +0200, David Miller wrote:
> From: Lars Poeschel <poeschel@lemonage.de>
> Date: Tue, 10 Sep 2019 11:34:12 +0200
> 
> > +static int pn533_autopoll_complete(struct pn533 *dev, void *arg,
> > +			       struct sk_buff *resp)
> > +{
> > +	u8 nbtg;
> > +	int rc;
> > +	struct pn532_autopoll_resp *apr;
> > +	struct nfc_target nfc_tgt;
> 
> Need reverse christmas tree here.

See below.

> > @@ -1534,6 +1655,7 @@ static int pn533_start_poll(struct nfc_dev *nfc_dev,
> >  	struct pn533_poll_modulations *cur_mod;
> >  	u8 rand_mod;
> >  	int rc;
> > +	struct sk_buff *skb;
> 
> Likewise.

I will do a v8 with these changes soon.