Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 17 Sep 2019 12:56:09 +0200
From:   Lars Poeschel <poeschel@lemonage.de>
To:     David Miller <davem@davemloft.net>
Cc:     gregkh@linuxfoundation.org, tglx@linutronix.de,
        kstewart@linuxfoundation.org, swinslow@gmail.com,
        allison@lohutok.net, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, johan@kernel.org,
        Claudiu.Beznea@microchip.com
Subject: Re: [PATCH v7 5/7] nfc: pn533: add UART phy driver
Message-ID: <20190917105609.GC18936@lem-wkst-02.lemonage>
References: <20190910093359.2110-1-poeschel@lemonage.de>
 <20190911.101732.1453519960272118746.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190911.101732.1453519960272118746.davem@davemloft.net>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Sep 11, 2019 at 10:17:32AM +0200, David Miller wrote:
> From: Lars Poeschel <poeschel@lemonage.de>
> Date: Tue, 10 Sep 2019 11:33:50 +0200
> 
> > +static int pn532_uart_send_ack(struct pn533 *dev, gfp_t flags)
> > +{
> > +	struct pn532_uart_phy *pn532 = dev->phy;
> > +	/* spec 7.1.1.3:  Preamble, SoPC (2), ACK Code (2), Postamble */
> > +	static const u8 ack[PN533_STD_FRAME_ACK_SIZE] = {
> > +			0x00, 0x00, 0xff, 0x00, 0xff, 0x00};
> > +	int err;
> 
> Reverse christmas tree ordering for the local variables please.

See below.

> > +static int pn532_uart_rx_is_frame(struct sk_buff *skb)
> > +{
> > +	int i;
> > +	u16 frame_len;
> > +	struct pn533_std_frame *std;
> > +	struct pn533_ext_frame *ext;
> 
> Likewise.

Ok, I will do a v8 soon with these changes.