Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 17 Sep 2019 21:55:08 +0530
From:   Saiyam Doshi <saiyamdoshi.in@gmail.com>
To:     Markus Elfring <Markus.Elfring@web.de>
Cc:     Andy Gross <agross@kernel.org>, linux-arm-msm@vger.kernel.org,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/3] i2c: qup: Remove dev_err() log after
 platform_get_irq*() failure
Message-ID: <20190917162508.GB5388@SD>
References: <20190916185857.GA14093@SD>
 <f25a406d-9032-5db9-7136-6ff99c02f888@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f25a406d-9032-5db9-7136-6ff99c02f888@web.de>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Sep 17, 2019 at 05:28:47PM +0200, Markus Elfring wrote:
> > The semantic patch that makes this report is available
> > in scripts/coccinelle/api/platform_get_irq.cocci.
> >
> > Found using - http://coccinelle.lip6.fr/
> 
> Can a tag like “Generated by: scripts/coccinelle/api/platform_get_irq.cocci”
> be more helpful than the other description variant?
Okay, will update the changelog.

> >  	if (qup->irq < 0) {
> > -		dev_err(qup->dev, "No IRQ defined\n");
> >  		return qup->irq;
> >  	}
> How do you think about to omit the curly brackets here after only a single
> statement would be used in the if branch?
Completely missed that! I will update and resend.

-Saiyam