Date: Wed, 28 Dec 2005 20:57:41 +0100
From: Andi Kleen <ak@suse.de>
To: John Blackwood <john.blackwood@ccur.com>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@suse.de>, bugsy@ccur.com
Subject: Re: [PATCH] arch/x86_64/kernel/ptrace.c linux-2.6.14.4
Message-ID: <20051228195741.GA11515@wotan.suse.de>
References: <43AAC435.2090702@ccur.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <43AAC435.2090702@ccur.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 682
Lines: 17

> I suppose that the read_32bit_tls() code could be instead pulled into
> a header file such as asm-x86_64/desc.h and shared between process.c
> and ptrace.c instead of having the read_tls_array() code below, but I
> didn't do that in this version of the patch.

Please do that. But not as an inline - make it out of line.
And read_ldt also doesn't need to be copied, it's already
in ldt.c and can be exported from there.

Thanks,
-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/