Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 17 Sep 2019 15:12:04 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Petr Mladek <pmladek@suse.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        AndreaParri <parri.andrea@gmail.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Brendan Higgins <brendanhiggins@google.com>,
        Paul Turner <pjt@google.com>,
        Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
        Peter Zijlstra <peterz@infradead.org>,
        John Ogness <john.ogness@linutronix.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        LinusTorvalds <torvalds@linux-foundation.org>,
        Theodore Ts'o <tytso@mit.edu>,
        PraritBhargava <prarit@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: printk meeting at LPC
Message-ID: <20190917131204.GA745680@kroah.com>
References: <20190905143118.GP2349@hirez.programming.kicks-ass.net>
 <alpine.DEB.2.21.1909051736410.1902@nanos.tec.linutronix.de>
 <20190905121101.60c78422@oasis.local.home>
 <alpine.DEB.2.21.1909091507540.1791@nanos.tec.linutronix.de>
 <87k1acz5rx.fsf@linutronix.de>
 <cfc7b1fa-e629-19a6-154b-0dd4f5604aa7@I-love.SAKURA.ne.jp>
 <20190916104624.n3jh363z37ah2kxa@pathway.suse.cz>
 <20190916094314.6053f988@gandalf.local.home>
 <20190917075216.agzoy6cnol5eio6y@pathway.suse.cz>
 <20190917090254.46131564@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190917090254.46131564@gandalf.local.home>
User-Agent: Mutt/1.12.1 (2019-06-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Sep 17, 2019 at 09:02:54AM -0400, Steven Rostedt wrote:
> On Tue, 17 Sep 2019 09:52:16 +0200
> Petr Mladek <pmladek@suse.com> wrote:
> 
> > Heh, I did some grepping and the return value is actually used on
> > three locations:
> > 
> > $> git grep "= printk("  
> > drivers/scsi/aic7xxx/aic79xx_core.c:	printed = printk("%s[0x%x]", name, value);
> > drivers/scsi/aic7xxx/aic79xx_core.c:		printed += printk(" ");
> > drivers/scsi/aic7xxx/aic79xx_core.c:			printed += printk("%s%s",
> > drivers/scsi/aic7xxx/aic79xx_core.c:		printed += printk(") ");
> > drivers/scsi/aic7xxx/aic79xx_core.c:		printed += printk(" ");
> > drivers/scsi/aic7xxx/aic79xx_core.c:		cur_col = printk("\n%3d FIFO_USE[0x%x] ", SCB_GET_TAG(scb),
> > drivers/scsi/aic7xxx/aic79xx_core.c:		cur_col += printk("SHADDR = 0x%x%x, SHCNT = 0x%x ",
> > drivers/scsi/aic7xxx/aic79xx_core.c:		cur_col += printk("HADDR = 0x%x%x, HCNT = 0x%x ",
> > drivers/scsi/aic7xxx/aic7xxx_core.c:	printed  = printk("%s[0x%x]", name, value);
> > drivers/scsi/aic7xxx/aic7xxx_core.c:		printed += printk(" ");
> > drivers/scsi/aic7xxx/aic7xxx_core.c:			printed += printk("%s%s",
> > drivers/scsi/aic7xxx/aic7xxx_core.c:		printed += printk(") ");
> > drivers/scsi/aic7xxx/aic7xxx_core.c:		printed += printk(" ");
> > drivers/scsi/aic7xxx/aic7xxx_core.c:		cur_col  = printk("\n%3d ", i);
> > drivers/scsi/aic7xxx/aic7xxx_core.c:		cur_col  = printk("\n%3d ", scb->hscb->tag);

All of those can be removed as none of the returned values are used.
What a mess.

> > drivers/scsi/libsas/sas_ata.c:	r = printk("%s" SAS_FMT "ata%u: %s: %pV",

return value is also ignored, this can be fixed.

> > kernel/locking/lockdep.c:			len += printk("%*s   %s", depth, "", usage_str[bit]);
> > kernel/locking/lockdep.c:			len += printk(KERN_CONT " at:\n");

That seems to be the only semi-legitimate use, but if it _really_ needs
it, it can just create the string ahead of time, and use the length then
after it printks it out.

> > It is probably not a big deal. For example, lockdep uses the value
> > just for formatting (extra spaces) when printing backtrace.
> > 
> > I agree that it does not make sense to return the value if it
> > complicates the code too much. Well, we will need to count
> > the string length also from another reason (reservation).
> 
> Well, it's being used. I was thinking of dropping it if it was not.
> Let's keep it then.

I think it should be dropped, only one user of the kernel is using it in
a legitimate way, which kind of implies it isn't needed.

thanks,

greg k-h