Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp6228937ybe; Tue, 17 Sep 2019 23:23:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqwQANq+0sG3gir4V2owlR2be2Ms90AuiZYAyxjjiocPrH3/EiU+Q2NGhsVt2KrpL1HUI4vA X-Received: by 2002:a17:906:1e45:: with SMTP id i5mr8153179ejj.135.1568787804869; Tue, 17 Sep 2019 23:23:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568787804; cv=none; d=google.com; s=arc-20160816; b=ajnHHUrYPZ9n8ECZPzuHoTxzp5GoalgRC0IRZ5n3i65/i+NSwv5KeDpaDlS5jOG6qJ 9NWkpp7TjEJa2Oc2LoRNRvyHUKJsIHX+Afng51hmyPfyYuiqJUxgXgP9bSy1OaOuEkaN PoEv9VUbt3BWNv4+ldhQIK6CJf+gzedZ8tN1337qKw81l/aCbgpYiXsQTJmvTFKGcWGN Js9gOW/sElqOzz7CMcBeXxS71mfQn5a2ZTWfmirPDIIC0Z6fQ6BhJZ5cJLvDssBipgQm gS6nYKLmE1C22b6rbxTIg7Q+YuFdSDrL851u0NnOGD/CvwoIZozDcmJojqZT3lYNvjqg gNYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:user-agent:subject:from :to:cc:references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=AIGreTLnb6bk3q8joO9XO69tVeABHA7b5VsQxkJP7Qk=; b=DcaVSTSmMZL//1+wUp2Eu/GuG1H7w8x9HWHFrCdU9aHr6IOwLt7U+UI0s2N8dwt9ft LiE8Ivtzq998HSJH0DlKZB3P4uIv1MkiUeBVKT43JkHCyqDSRnoqgC1sHSXY582nifRW xMqNlzJ7GezL9zMCqUxj4b5YNPlVCJnN0mVjkm7ZX5gxHoQ//NQKVzeVNEuwXqrS5JyO wA4SpGp92JLDAM/zicNYsJ8K8E/GvpIHZY9HeUv21SWZz/mmclfZJhC8twGwoJNR7RCa OBYMOK8iqmiDIzJYdgiQO+r1wneSI6UbKKDHuW3gUtLmlgNTIHlGY1fm4o+gqwKsXy8n qZ0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PZgRV9uH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 64si2942902eda.384.2019.09.17.23.23.02; Tue, 17 Sep 2019 23:23:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PZgRV9uH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727880AbfIRGHY (ORCPT + 99 others); Wed, 18 Sep 2019 02:07:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:34718 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725820AbfIRGHY (ORCPT ); Wed, 18 Sep 2019 02:07:24 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 61E0120856; Wed, 18 Sep 2019 06:07:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568786843; bh=AIGreTLnb6bk3q8joO9XO69tVeABHA7b5VsQxkJP7Qk=; h=In-Reply-To:References:Cc:To:From:Subject:Date:From; b=PZgRV9uH68lZF9Yfar4tWWII27pZcPdHXgBuaRNuQVd1Cv+QPz6URLR2rzD/j6SpE IT0b6IeHE4Dt5kthLM1AdLZ6iqgtXwu+HeYlILr/7u2q79rZUMs3zXR+e6qMGvBQyB iGn39550ZKs89ndUK4QihxjtMXYMfKqoVkUshgB4= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1568043491-20680-2-git-send-email-peng.fan@nxp.com> References: <1568043491-20680-1-git-send-email-peng.fan@nxp.com> <1568043491-20680-2-git-send-email-peng.fan@nxp.com> Cc: "kernel@pengutronix.de" , dl-linux-imx , Anson Huang , Jacky Bai , Abel Vesa , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Leonard Crestez , Peng Fan To: "festevam@gmail.com" , "mturquette@baylibre.com" , "s.hauer@pengutronix.de" , "shawnguo@kernel.org" , Peng Fan From: Stephen Boyd Subject: Re: [PATCH V3 1/4] clk: imx: pll14xx: avoid glitch when set rate User-Agent: alot/0.8.1 Date: Tue, 17 Sep 2019 23:07:22 -0700 Message-Id: <20190918060723.61E0120856@mail.kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Peng Fan (2019-09-08 20:39:34) > From: Peng Fan >=20 > According to PLL1443XA and PLL1416X spec, > "When BYPASS is 0 and RESETB is changed from 0 to 1, FOUT starts to > output unstable clock until lock time passes. PLL1416X/PLL1443XA may > generate a glitch at FOUT." >=20 > So set BYPASS when RESETB is changed from 0 to 1 to avoid glitch. > In the end of set rate, BYPASS will be cleared. >=20 > When prepare clock, also need to take care to avoid glitch. So > we also follow Spec to set BYPASS before RESETB changed from 0 to 1. > And add a check if the RESETB is already 0, directly return 0; >=20 > Fixes: 8646d4dcc7fb ("clk: imx: Add PLLs driver for imx8mm soc") > Reviewed-by: Leonard Crestez > Signed-off-by: Peng Fan > --- Applied to clk-next