Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp6229018ybe; Tue, 17 Sep 2019 23:23:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqzj9GL7u9KWiO054e8u5EGtK00LOlZziL50UPk41qe+T8DwLhEjwszrAPokveamyh1OnPWT X-Received: by 2002:aa7:dd11:: with SMTP id i17mr8793629edv.147.1568787812335; Tue, 17 Sep 2019 23:23:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568787812; cv=none; d=google.com; s=arc-20160816; b=qSEtttn4uIdQrE3tzm/vSo1mt7VJhLfz2Kt/UU3Pkb1vwlglUecTCIomGeZo1mqnW/ Uvl55rWU28ONQ7VqY2MEYUx+S4seHeCx8X9tS51iHs1NlJ+bki222x0U2Rcc6n1JoRbN pO7lcYLX88KjnPlKGiM3Ou8KKZ9RfJjrRgotZL/LxUfVJcayI8BNhwgW547UgGQ6aHZC xmeRuGMuT6aMTXW4ce7NgZT7uw+LMsFBOaUPan1z6FBWs5qJTjzB39YyfBgggOE8qgUG ygMGkHtrz2ivsSIU5Q7H9jv6L75Zy/9KVHRhAdkVIJNLaiEfgPPp2pxdWpniJT/NR7uo gJmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:user-agent:subject:from :to:cc:references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=jNhbz67CJr/g2fdjXe+N+K8ckAY7k1eWl83twN0NrXA=; b=O6OBY+IP1uS9stUYTD9d6gJcQQF77tMTfES0jQLP9r6gXr8DsgnbFXhL/JUtVmnGTb kwt9zOxAdxZkCMY9vfhcbd1iNvFyzcKUg4b8zpm5WTxDWrVVmhcsOB85awqnS5JhFjxA 3EdqCBHyYlmbEEFp/YfTHx6Aq/Hj3YQmaXHaj7jPfCUlabVe+ESK12lbryZCa3r+IDRq z9+8G1t8uFYSbOyto4sMyYbRTLpWi1vI9Ni+uDyorAMCUHdiDRvznGt7gET8WjCCNQpc RlhFLr5PlHaIJws39hxEmoJjCTWRdC5hGFsEW3lcxUxix0j0sEWOBuGkE/dvxPTnLWTO P4vA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=i2K8gJQM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l54si2756044edb.206.2019.09.17.23.23.09; Tue, 17 Sep 2019 23:23:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=i2K8gJQM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728104AbfIRGHc (ORCPT + 99 others); Wed, 18 Sep 2019 02:07:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:34938 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725820AbfIRGHb (ORCPT ); Wed, 18 Sep 2019 02:07:31 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1A60220856; Wed, 18 Sep 2019 06:07:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568786851; bh=jNhbz67CJr/g2fdjXe+N+K8ckAY7k1eWl83twN0NrXA=; h=In-Reply-To:References:Cc:To:From:Subject:Date:From; b=i2K8gJQM0HbM2ZNZSIwPgK+a8ru9cYl2eYOub+t5Aa/Mll4ya7fal7MFOxBo3K1dg pdLVcFKnMNOcHv4rPXBY4N8/rM/YuFsCVOZ0vr/m37Lcis9s47eUYJ2fcQdBGS0Hl5 qXtjMqa4X5+nBV7I8vdwJIESc5HPNhuRphWFOQIc= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1568043491-20680-4-git-send-email-peng.fan@nxp.com> References: <1568043491-20680-1-git-send-email-peng.fan@nxp.com> <1568043491-20680-4-git-send-email-peng.fan@nxp.com> Cc: "kernel@pengutronix.de" , dl-linux-imx , Anson Huang , Jacky Bai , Abel Vesa , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Leonard Crestez , Peng Fan To: "festevam@gmail.com" , "mturquette@baylibre.com" , "s.hauer@pengutronix.de" , "shawnguo@kernel.org" , Peng Fan From: Stephen Boyd Subject: Re: [PATCH V3 3/4] clk: imx: imx8mm: fix pll mux bit User-Agent: alot/0.8.1 Date: Tue, 17 Sep 2019 23:07:30 -0700 Message-Id: <20190918060731.1A60220856@mail.kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Peng Fan (2019-09-08 20:39:44) > From: Peng Fan >=20 > pll BYPASS bit should be kept inside pll driver for glitchless freq > setting following spec. If exposing the bit, that means pll driver and > clk driver has two paths to touch this bit, which is wrong. >=20 > So use EXT_BYPASS bit here. >=20 > And drop uneeded set parent, because EXT_BYPASS default is 0. >=20 > Fixes: ba5625c3e272 ("clk: imx: Add clock driver support for imx8mm") > Suggested-by: Jacky Bai > Reviewed-by: Leonard Crestez > Signed-off-by: Peng Fan > --- Applied to clk-next