Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp6232176ybe; Tue, 17 Sep 2019 23:27:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqxx15aJKQjx4OHs62/6Qnd3i0Ycnqu2wOEFYsBR414oe+fk3kozKa8/nr2z7soQyg2ftGjx X-Received: by 2002:a17:906:4a51:: with SMTP id a17mr8002515ejv.279.1568788037519; Tue, 17 Sep 2019 23:27:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568788037; cv=none; d=google.com; s=arc-20160816; b=cXznSEZhfqhkd+JM+gCB8JlsW0mL6GMAyZnuTL1qkwF51aMmwqXvlnm2p7MtXaFTPx CgINYoaqscoWS1tAgXI+4UMeQm6H6bKVal1JVbiIEz7acPoHQ+GR9+YrjniOVj6WQhlm 813rDpCvDoMPphadPkSA9pzQwD3nSopM6dHEIC+DPuwv3OYU+Q6UExvXHpoIc3+1kHSR 1UCV4/EoxWkwFgjyMvA+K8+dGI2CqlUBpnweOvkbdx4XGdZKQzCzHF9m/rOts0w8LdCl ijhgiW6yZbyqvh48rUXMjdK8VhB9Pi9GRmeum5d1/PZe3qc+XRw6xHcEcJ8for6CQlq7 gGWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=55oy6lM52FdvlPalPoRasqf84NMRoQoVNu2UkhR14cA=; b=HzdneoDGawRtwm9ORr5css/Tvl/dWVoW125SXtAK3HGCtOxlwTvnSouHa4WB3d7tiv rVH8LjncVPbPcHHPJIEuci9tSr3+5BUUfUtzEKCp8qUYcDd/0ETAsSA4p8qktSEAjCLF MCSYWV1lF0ZacjNpM4xIXzy8PQ3autf2qKAXQnXvHsnpz4Ju2QPbcu6EsWhsnwvrOiow EXWvf3qCAs7E2Y6bV6k2dfcN8lZdlUH1YdzFTgOgNljSLYjCFNQVoOHNprfXXjMsgDEQ jg2uTdICaKvi9UEKBCTzSHkZf9CxyZ0wOT5y0JaJwP4nqsvRtSnCN+jk3B55Ci4xbtgj 5A1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=FClmb+z9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c52si2839571eda.132.2019.09.17.23.26.54; Tue, 17 Sep 2019 23:27:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=FClmb+z9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729347AbfIRGWL (ORCPT + 99 others); Wed, 18 Sep 2019 02:22:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:42006 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728577AbfIRGWJ (ORCPT ); Wed, 18 Sep 2019 02:22:09 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EE24A218AF; Wed, 18 Sep 2019 06:22:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568787728; bh=Am3LBOHvWGKg614T7SoYKCS7JrSTDbZ+TlF37TA2tKU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FClmb+z9u/3bTSBk2FQq3tRRPkmW9Kg8jMYDnRNZDsbEbhIgkmra70Ga3fViNNqPl AAJRCDI2CROpwG9ghw49v/GeUU+jCdtPwz+l44A5nMhnNN9ALK0p8XMxHgnAE5hXz+ koRWAhZRpBge340EF1dYUqMk8nVQIVuF4F8fx4cI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Xin Long , Marcelo Ricardo Leitner , Neil Horman , "David S. Miller" Subject: [PATCH 4.19 12/50] sctp: use transport pf_retrans in sctp_do_8_2_transport_strike Date: Wed, 18 Sep 2019 08:18:55 +0200 Message-Id: <20190918061224.308579712@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190918061223.116178343@linuxfoundation.org> References: <20190918061223.116178343@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xin Long [ Upstream commit 10eb56c582c557c629271f1ee31e15e7a9b2558b ] Transport should use its own pf_retrans to do the error_count check, instead of asoc's. Otherwise, it's meaningless to make pf_retrans per transport. Fixes: 5aa93bcf66f4 ("sctp: Implement quick failover draft from tsvwg") Signed-off-by: Xin Long Acked-by: Marcelo Ricardo Leitner Acked-by: Neil Horman Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/sctp/sm_sideeffect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/sctp/sm_sideeffect.c +++ b/net/sctp/sm_sideeffect.c @@ -562,7 +562,7 @@ static void sctp_do_8_2_transport_strike if (net->sctp.pf_enable && (transport->state == SCTP_ACTIVE) && (transport->error_count < transport->pathmaxrxt) && - (transport->error_count > asoc->pf_retrans)) { + (transport->error_count > transport->pf_retrans)) { sctp_assoc_control_transport(asoc, transport, SCTP_TRANSPORT_PF,