Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp6238031ybe; Tue, 17 Sep 2019 23:34:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqxRX3bjFmAF8bMP10egsnDussjJNHCFZESNLGCR+o9z+KEt3xLSmNYT66gqojthijx3TMHR X-Received: by 2002:a05:6402:6c6:: with SMTP id n6mr8355978edy.162.1568788455522; Tue, 17 Sep 2019 23:34:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568788455; cv=none; d=google.com; s=arc-20160816; b=S9dmiqPVJSetfzXzkkwJHukxbWFz0lZv0Jv+0HSvPYPQZ9ItkrB39bNpzIU8ZOKDT2 oh6p4NCKlUZoOeoMPLudTrLK1hfeHOiSssPNmw65JK//q3YoAWtkkJHTTC0kxEixwRcF 57B7VdCns0xqjK/1d2Dic9bC18j9C3JbP24vZ3KGWJDwaEUOc5fJ63wnLOB/JCfvzz7r vBEQurG8fZikB5JkBRzTZR5oKfZjCoW7YNfHBv5cx2Gyo4pwqV3zBlyJThup2Px2/vTw f+QXd1qid/E8ghUi/tQLfxPnv7un1kuZ0VruzhheZ2agQqPZOruZWsbCrfBqwzIwGqz0 AszA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=o3TtJcRH8G09qAWs9gPBmgAVDSDa80MUr9rG48cyKxA=; b=0BiVzZBt5BmIBJBpRoAcCv7EmXGp3vq7mwF6q5RyNbqSmVu0iUxAejJueXGODsPqYB emUkMlwjlHU2Ow4Q0cgbBcN4bi0l5cYIbAk/FJSBMYxp/ViuxEeZL3bKqNEdvn9pa1mV X1K6+wwe/5H7YQgzsCBIgZwgael5aTue/we3X65y14UOwVx7jc0s8SWfECjHvMB5vjHK FgqRckzWZt/Xr+rT4ayPbcD4pIC675GmlcoQUvsksQBHA7P9ohWmzdyKturcRjSKSNQu fjx0YulGa6e0Cw80dQVKFfK/mHwiles3hcI5/rogBkH67jsLcqrRMy1t0WZ0/0AfF15R tSJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=n69BJ+bu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v7si2537827edr.125.2019.09.17.23.33.52; Tue, 17 Sep 2019 23:34:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=n69BJ+bu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730108AbfIRGZZ (ORCPT + 99 others); Wed, 18 Sep 2019 02:25:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:46308 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727859AbfIRGZW (ORCPT ); Wed, 18 Sep 2019 02:25:22 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EBAA221920; Wed, 18 Sep 2019 06:25:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568787922; bh=yyMYnl9xVKxxHpTJhZhw2/F9RlZGrcbZgSK3AlEtctQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n69BJ+bupaNXrHhohn2IJ5BWlJOEwRFD4GY7TucnrstU7CSk4mINwESpl5ijq915V 6a6N6UwK0UFCSxGRHHkWBBuuFHBfcQG9Xw+I0M7Ft3nXHElrSQ+ahvB524zM7lKdux Qlyt++XRkANUJQhepa8t8BPSNoCWPMuVN4I336dM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vasily Khoruzhick , Qiang Yu Subject: [PATCH 5.2 32/85] drm/lima: fix lima_gem_wait() return value Date: Wed, 18 Sep 2019 08:18:50 +0200 Message-Id: <20190918061235.169875025@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190918061234.107708857@linuxfoundation.org> References: <20190918061234.107708857@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vasily Khoruzhick commit 21670bd78a25001cf8ef2679b378c73fb73b904f upstream. drm_gem_reservation_object_wait() returns 0 if it succeeds and -ETIME if it timeouts, but lima driver assumed that 0 is error. Cc: stable@vger.kernel.org Fixes: a1d2a6339961e ("drm/lima: driver for ARM Mali4xx GPUs") Signed-off-by: Vasily Khoruzhick Signed-off-by: Qiang Yu Link: https://patchwork.freedesktop.org/patch/msgid/20190908024800.23229-1-anarsoul@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/lima/lima_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/lima/lima_gem.c +++ b/drivers/gpu/drm/lima/lima_gem.c @@ -342,7 +342,7 @@ int lima_gem_wait(struct drm_file *file, timeout = drm_timeout_abs_to_jiffies(timeout_ns); ret = drm_gem_reservation_object_wait(file, handle, write, timeout); - if (ret == 0) + if (ret == -ETIME) ret = timeout ? -ETIMEDOUT : -EBUSY; return ret;