Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp6238108ybe; Tue, 17 Sep 2019 23:34:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqxgR18TGXGeo2MwHW08p/9sAHVOnn3xr23xatnV9QUDRLe7Yuf7KTl3yv4RON6Yk6VsiRTV X-Received: by 2002:a17:906:3113:: with SMTP id 19mr7963091ejx.176.1568788463569; Tue, 17 Sep 2019 23:34:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568788463; cv=none; d=google.com; s=arc-20160816; b=rCGYXrUfjqFu0BoB4C+HVPRGy7FjAS2YT6cIm7D2ORRTlp9zEeYUlJgtUPuHi0f7/V BHx3GHvdoG4bDP1LZboWO6L7vlbteQAjstv2Fr7rIQWKD30UDkzdwMZL2FkYlBbuvwL0 8/Saa26Podw82B1T5STPOKOhL1ZAstBx3qQqkPQzLj28JDkpID1XGyJk76sEPMYW3/OU WeqpVtHcPfO5yHn0gTGOy/gbiJobynfY1zJyUP7cXeYopFyEFHEhraIg34g4O6eQwcsO H01vnhKbf7LvYfVwCKH6Z/SrsEvQy/9Tu43/jpdoFM62kILtsj0uwqT153ABTB1jQkaD CnFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=8on3XXo3v3f8vsDrTMqGx/qNqXUtVz5tVBoWlZ71PgY=; b=li9SNHPCVos4JqQowtJaF9LYe+s5u+X8vy3VtW/mAXPAuG0v1QCv4VgBValfnmCNor Jzx6yLD5fZszIgdhIwmhtLcegTXh/SMYTpJ50M7dkRUMB4reAkba8J/r5OrxtKUIvVQ3 JHujasveIaxGsQtwBuJlvJc+Nfnd0So5lhA+2cKzM3HC9grqAU0LA1WK2fos9ZYuMlkL uK5yBL70LFkkIrxajm1Dx+i3dtxlVfuTxMn4+KMbepc6Sdt+BiilrVT5AMZiTtYY3Ilr /FKCwQUEMirrmjqeeSMo/MlCFwagdgvSjBHpHKWc7/OyjuG5llsRsMU8JaOaJoctF+dE r+nQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Kc0/f0v4"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 64si2942902eda.384.2019.09.17.23.34.00; Tue, 17 Sep 2019 23:34:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Kc0/f0v4"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730083AbfIRGZN (ORCPT + 99 others); Wed, 18 Sep 2019 02:25:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:45972 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730059AbfIRGZJ (ORCPT ); Wed, 18 Sep 2019 02:25:09 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A00F5218AF; Wed, 18 Sep 2019 06:25:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568787909; bh=nerxgIB4K0RwEScMkf7xs5pEABsAo/UmUQ5hGfz4X2E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Kc0/f0v4mphxWXr/HoqQEW18rdZLVXf5HAiJ08UpsBZa61Zt3N+9eEslkBDqLFoKg 4Ov8As+XLAdYqM+Rt/0BlD6za+6VfD48sezlAbqpwaJUNR8ZS9BgtuE3yD8/16LLTH oKaQ86dJYxiAnqhEK1CpiyVzm+ntAVK6R1s+9ayo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stefan Wahren , Ulf Hansson Subject: [PATCH 5.2 28/85] Revert "mmc: bcm2835: Terminate timeout work synchronously" Date: Wed, 18 Sep 2019 08:18:46 +0200 Message-Id: <20190918061235.046409098@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190918061234.107708857@linuxfoundation.org> References: <20190918061234.107708857@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stefan Wahren commit aea64b583601aa5e0d6ea51a0420e46e43710bd4 upstream. The commit 37fefadee8bb ("mmc: bcm2835: Terminate timeout work synchronously") causes lockups in case of hardware timeouts due the timeout work also calling cancel_delayed_work_sync() on its own. So revert it. Fixes: 37fefadee8bb ("mmc: bcm2835: Terminate timeout work synchronously") Cc: stable@vger.kernel.org Signed-off-by: Stefan Wahren Signed-off-by: Ulf Hansson Signed-off-by: Greg Kroah-Hartman --- drivers/mmc/host/bcm2835.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/mmc/host/bcm2835.c +++ b/drivers/mmc/host/bcm2835.c @@ -597,7 +597,7 @@ static void bcm2835_finish_request(struc struct dma_chan *terminate_chan = NULL; struct mmc_request *mrq; - cancel_delayed_work_sync(&host->timeout_work); + cancel_delayed_work(&host->timeout_work); mrq = host->mrq;