Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp6238862ybe; Tue, 17 Sep 2019 23:35:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqxqNPD+Dp/GkNYl8uQ8YGwN6mo2MiCEuSEGDPvC8e8jhLmD7ns1oWtbxYyXMO/iyLKltLg0 X-Received: by 2002:a05:6402:1251:: with SMTP id l17mr143535edw.270.1568788527142; Tue, 17 Sep 2019 23:35:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568788527; cv=none; d=google.com; s=arc-20160816; b=Xzbac9jSmrQyDfrv9vJmrDUpZ2NqbSzmNGL1imfX8w04DDF6+wO7aTqNXfOZ4KIQmM SmqBcIdUTAPBBYEAnnnVMJjktQpqdcgnp9MA6depExn/QjmAXvQHZN/OJ9IoPtiCRm+d QVb6bbdHcIABpjS9E55koTt36JqaPN+F3e1/CpmDf/E9TPT+PO7hNnjnpRlMa9laj9yp Jo2g2iOiaHr/j6uExT+FY6Ld494LIKLTHpGBYvdru2pEHNMtr0+9XcG7zGUI9SXXuxWb Iv8gWggqGG72n0/ctFi0ehTL6hU2Dt4ctlYSNk3XT2nSSHy8gAgASrFlbEGxLBwktcDG JPFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=NyQ57uy1NZ2j2G6ZtnfslqhIZJzaYZYGuFKhaeMBuNs=; b=Z00/vKAiiZxHfSghjyMGtSj9Y3qGzaTGwr58XiIUXwnKoJPKh0lXMTgQicjRibiPxl 05qF3jcI20jUwjj/97EmXVg75bZkYtnIGMfWFRm2bewjj4qm3qTNLPC1BkCIZdmOJrPG gI6lbG8sg6NrLyubBmR+ZqrOY3BmFje9Jqd0XSblvRVfcXZszO1V6KI19Si9kKzCEAyf qRKN1nTtzjFgWks4E2eXdtvBgWxIhWZgFut6ScCxJFF0jITrUCNIx2+3F1qKgNKCuxpq Tq/oApSOcZlXptRpgJyv61HUr10hvo9TfacuczHXlLbT47rRdoxNqf5XC5IVD24VtS0q EgsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oLZTUBsg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id se14si2371362ejb.322.2019.09.17.23.35.04; Tue, 17 Sep 2019 23:35:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oLZTUBsg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729943AbfIRGY6 (ORCPT + 99 others); Wed, 18 Sep 2019 02:24:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:45640 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729151AbfIRGY4 (ORCPT ); Wed, 18 Sep 2019 02:24:56 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8A311218AF; Wed, 18 Sep 2019 06:24:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568787896; bh=6np+q82s1Nx0TkE0BdOMt7YqZ8YXCMzUpWHwV+6xJDM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oLZTUBsgYehAenyBbNkhwS6tayxPGhyQn6L4bltg2WoSIr1KQCCRwDEQyerxuTMSa rJoGxGvJYdUO/UGP8mBAhooeHudwNEyGFhNTuY6BOo096aOmDx2C3eR/V8jsEXGGUM LJP/qXIVcHcJ7ctz35XG+i/w1S1GdzAtTxGLKEFo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wei Yongjun , Bartosz Golaszewski Subject: [PATCH 5.2 23/85] gpio: mockup: add missing single_release() Date: Wed, 18 Sep 2019 08:18:41 +0200 Message-Id: <20190918061234.890530260@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190918061234.107708857@linuxfoundation.org> References: <20190918061234.107708857@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wei Yongjun commit 59929d3a2eb6c4abafc5b61a20c98aa8728ec378 upstream. When using single_open() for opening, single_release() should be used instead of seq_release(), otherwise there is a memory leak. Fixes: 2a9e27408e12 ("gpio: mockup: rework debugfs interface") Cc: stable Signed-off-by: Wei Yongjun Signed-off-by: Bartosz Golaszewski Signed-off-by: Greg Kroah-Hartman --- drivers/gpio/gpio-mockup.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/gpio/gpio-mockup.c +++ b/drivers/gpio/gpio-mockup.c @@ -309,6 +309,7 @@ static const struct file_operations gpio .read = gpio_mockup_debugfs_read, .write = gpio_mockup_debugfs_write, .llseek = no_llseek, + .release = single_release, }; static void gpio_mockup_debugfs_setup(struct device *dev,