Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 2/3] i2c: qup: Remove dev_err() log after
 platform_get_irq*() failure
To:     Saiyam Doshi <saiyamdoshi.in@gmail.com>
Cc:     MSM <linux-arm-msm@vger.kernel.org>,
        I2C <linux-i2c@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Marc Zyngier <maz@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>
References: <20190917172120.GA11581@SD>
From:   Marc Gonzalez <marc.w.gonzalez@free.fr>
Message-ID: <4e65aeeb-40da-7856-a22e-ce7aac21ae46@free.fr>
Date:   Wed, 18 Sep 2019 11:00:32 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190917172120.GA11581@SD>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 17/09/2019 19:21, Saiyam Doshi wrote:

> The debug message after platform_get_irq() failure is redundant
> because platform_get_irq() already prints an error. Thus remove it.
> 
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
> 
> Signed-off-by: Saiyam Doshi <saiyamdoshi.in@gmail.com>
> ---
> Changes in v2:
> Updated changelog and removed unnecessary braces after if condition.
> 
>  drivers/i2c/busses/i2c-qup.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c
> index 5519c19bfd9c..ed09a59066b2 100644
> --- a/drivers/i2c/busses/i2c-qup.c
> +++ b/drivers/i2c/busses/i2c-qup.c
> @@ -1766,10 +1766,8 @@ static int qup_i2c_probe(struct platform_device *pdev)
>  		return PTR_ERR(qup->base);
> 
>  	qup->irq = platform_get_irq(pdev, 0);
> -	if (qup->irq < 0) {
> -		dev_err(qup->dev, "No IRQ defined\n");
> +	if (qup->irq < 0)
>  		return qup->irq;
> -	}

As far as I understand, platform_get_irq() == 0 is also an error condition.

I think the typical way to handle this peculiarity is:
(Maybe the IRQ maintainers will correct me)

	qup->irq = platform_get_irq(pdev, 0);
	if (qup->irq <= 0)
		return qup->irq ? : -ENXIO;

Regards.