Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp6513983ybe; Wed, 18 Sep 2019 04:56:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqxrQxodFvTgGjM38jklBdAdeNIBKOVfHaQIm5aGK4vest8VrAh3p8iry5DmLHpvfQactjao X-Received: by 2002:a17:906:3110:: with SMTP id 16mr2025905ejx.306.1568807815297; Wed, 18 Sep 2019 04:56:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568807815; cv=none; d=google.com; s=arc-20160816; b=0UcUEOFcoHQg685chZ9ryRufGGx28b6CT8Wmr+eeHHLCoBdV+ULCRZaAIfdqVzvYjY lVydw+Tp0c+gZALRh8NaKyILfVBqlWaUjGSMnULI2xaxBiJfgm3u/5L0Qm6itssUTHgq k4M/PISGsSbChOL3Drvx7XjxnjDoluWJBJ5dqmncHoZkrl1ZJcCPHt2V/9UPue4KCE4W +IWRdptf9FlQwQVEIBlLlEXU/Xe2Q/d8DNYaV9PPi0AjchToqEvkcwk5W1WUy+QN2pv8 aO/meZyuphwVQZVQF/BxiGQ5doNwljjT+lf96DuyZm9mmy4RaytK50sO1dhXjkNQTQAP NzPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=ryyc7HxeZgX9I3vBJNh5xPpDRxcwQDivEwkl5wNL7m0=; b=jQDSNIJVQAoHdRW/pUOdQ4KfxoxgZz5LAOy5Zk+E2vRoXfaCIANFaO4lCHeedMBp3J piam4JjhL0n35VGZLjcTHuUop+OtIbaM1ltLIWxCK6AVy0hRIz37fzy0CtuWgM9I20Rf gJbgqmvIsqAZcy9Zqg/xUYjY9/VuAflm2cEzyQY9njlaIImws/OrfOP5BzvFfWzS+6lI m5BA+B2F6dqsulHU4SsoLO0YMQEx8VcfxAcaJxxvYcdIZcj64bjNjOKYfi88xfyY/El+ pFdHs3LiGYV/Wd8NzEOIibrsRusazIUh0NqtK1mPcRernun71lgcVMocu2XGPhwAN3fQ piqQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x51si3059525eda.272.2019.09.18.04.56.31; Wed, 18 Sep 2019 04:56:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729399AbfIRIF2 (ORCPT + 99 others); Wed, 18 Sep 2019 04:05:28 -0400 Received: from relmlor2.renesas.com ([210.160.252.172]:22733 "EHLO relmlie6.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729339AbfIRIF2 (ORCPT ); Wed, 18 Sep 2019 04:05:28 -0400 X-IronPort-AV: E=Sophos;i="5.64,519,1559487600"; d="scan'208";a="26658158" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie6.idc.renesas.com with ESMTP; 18 Sep 2019 17:05:26 +0900 Received: from renesas-VirtualBox.ree.adwin.renesas.com (unknown [10.226.37.56]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id E139F41CA6B6; Wed, 18 Sep 2019 17:05:24 +0900 (JST) From: Gareth Williams To: Mark Brown Cc: Phil Edworthy , Geert Uytterhoeven , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Gareth Williams Subject: [PATCH v2 3/4] spi: dw: Add basic runtime PM support Date: Wed, 18 Sep 2019 09:04:35 +0100 Message-Id: <1568793876-9009-4-git-send-email-gareth.williams.jx@renesas.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1568793876-9009-1-git-send-email-gareth.williams.jx@renesas.com> References: <1568793876-9009-1-git-send-email-gareth.williams.jx@renesas.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Phil Edworthy Enable runtime PM so that the clock used to access the registers in the peripheral is turned on using a clock domain. Signed-off-by: Phil Edworthy Signed-off-by: Gareth Williams --- v2: - set spi_controller.auto_runtime_pm instead of using pm_runtime_get_sync. - Added pm_runtime_disable calls to dw_spi_remove_host and the error condition of dw_spi_add_host. --- drivers/spi/spi-dw.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c index 9a49e07..54ed6eb 100644 --- a/drivers/spi/spi-dw.c +++ b/drivers/spi/spi-dw.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include @@ -493,10 +494,13 @@ int dw_spi_add_host(struct device *dev, struct dw_spi *dws) master->dev.of_node = dev->of_node; master->dev.fwnode = dev->fwnode; master->flags = SPI_MASTER_GPIO_SS; + master->auto_runtime_pm = true; if (dws->set_cs) master->set_cs = dws->set_cs; + pm_runtime_enable(dev); + /* Basic HW init */ spi_hw_init(dev, dws); @@ -525,6 +529,7 @@ int dw_spi_add_host(struct device *dev, struct dw_spi *dws) spi_enable_chip(dws, 0); free_irq(dws->irq, master); err_free_master: + pm_runtime_disable(dev); spi_controller_put(master); return ret; } @@ -539,6 +544,9 @@ void dw_spi_remove_host(struct dw_spi *dws) spi_shutdown_chip(dws); + if (dws->master) + pm_runtime_disable(&dws->master->dev); + free_irq(dws->irq, dws->master); } EXPORT_SYMBOL_GPL(dw_spi_remove_host); -- 2.7.4