Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp6566422ybe; Wed, 18 Sep 2019 05:44:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqwwRVRJ0RZ3y1qVUDD24nll6kS7OnECjGn72xpA/croteWLif5NJ197wk3dcLF3fLX0uk4/ X-Received: by 2002:a17:906:6dc1:: with SMTP id j1mr9359956ejt.85.1568810663811; Wed, 18 Sep 2019 05:44:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568810663; cv=none; d=google.com; s=arc-20160816; b=hELz97HfgIpLV2/58cbntze+l6Rm3Hf5YgtdHSWSRoLlrnT5Yj11+4kkP2DGdMUnwq jqthJyHedvEKp/jPVqNloEx5oCm2kOa046tbnB+R8Cl8a+pPteaBF8lRCh1crCZ0/WFO +ch+akzhJJVrctAnQKY4pB0KOo4H+a94J3r3wHk1jSLtzHq4Jky6aW+2Acc7OYwSOjWC aDHRVib71jUskMCougxA3XKkQue2MwqFRgggLO03pAHuZvQVofXUBcubiHDIgnouVSD2 iLNrrewqHaa5mTdWnNTxLH9wX/a2CtkB6T1jt/feD1uhBGU6lwDJHXei4GW1elnhSymR xsqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:to:from; bh=Ll0cZE5tqxg/EZlavNEPdlEmhKLtqwNmbsUoJUSra5Y=; b=AXocyk2fmUxO2wstOBNziDzHw3ducHqtuCd5WXVkX4sZs9/w+Kh/bsdxxYjm4j0cY0 8UPvu3kLl1IWhzO9sj/dfLJCb8FaaorGIjJ4+rAK9KxdwHqdJMZr2TOwD6Fq5d9NtORW 5QFIQu5IpkbEh7W0y0svak19J2UWzrU9b4IU5G2FtqrpIZBNwVBQPw9ntWBGsHnIapYD WOVdUoI80yaOuGj1KootQlcrPNwjwy3eEPZG9nW0kKAurvcHHbb2a1vnvAmEpLqJQfQX BjA2ueh6A/8fAx4f6ZbIUhvy5Ghe+xouVwTnU7peg9aIKPRxgyFzKcZPl45p5PavoO3w cUeg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b20si41043ejk.38.2019.09.18.05.43.59; Wed, 18 Sep 2019 05:44:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727305AbfIRGso (ORCPT + 99 others); Wed, 18 Sep 2019 02:48:44 -0400 Received: from inva020.nxp.com ([92.121.34.13]:50990 "EHLO inva020.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725842AbfIRGso (ORCPT ); Wed, 18 Sep 2019 02:48:44 -0400 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 44EE11A0159; Wed, 18 Sep 2019 08:48:42 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 0435E1A025F; Wed, 18 Sep 2019 08:48:35 +0200 (CEST) Received: from localhost.localdomain (shlinux2.ap.freescale.net [10.192.224.44]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 01801402A8; Wed, 18 Sep 2019 14:48:25 +0800 (SGT) From: Shengjiu Wang To: timur@kernel.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, lars@metafoo.de Subject: [PATCH V2 2/4] ASoC: fsl_asrc: update supported sample format Date: Wed, 18 Sep 2019 14:46:49 +0800 Message-Id: X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The ASRC support 24bit/16bit/8bit input width, which is data width, not slot width. For the S20_3LE format, the data with is 20bit, slot width is 24bit, if we set ASRMCR1n.IWD to be 24bits, the result is the volume is lower than expected, it likes 24bit data right shift 4 bits So replace S20_3LE with S24_3LE in supported list and add S8 format in TX supported list Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_asrc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c index 4d3804a1ea55..584badf956d2 100644 --- a/sound/soc/fsl/fsl_asrc.c +++ b/sound/soc/fsl/fsl_asrc.c @@ -624,7 +624,7 @@ static int fsl_asrc_dai_probe(struct snd_soc_dai *dai) #define FSL_ASRC_FORMATS (SNDRV_PCM_FMTBIT_S24_LE | \ SNDRV_PCM_FMTBIT_S16_LE | \ - SNDRV_PCM_FMTBIT_S20_3LE) + SNDRV_PCM_FMTBIT_S24_3LE) static struct snd_soc_dai_driver fsl_asrc_dai = { .probe = fsl_asrc_dai_probe, @@ -635,7 +635,8 @@ static struct snd_soc_dai_driver fsl_asrc_dai = { .rate_min = 5512, .rate_max = 192000, .rates = SNDRV_PCM_RATE_KNOT, - .formats = FSL_ASRC_FORMATS, + .formats = FSL_ASRC_FORMATS | + SNDRV_PCM_FMTBIT_S8, }, .capture = { .stream_name = "ASRC-Capture", -- 2.21.0