Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp6622924ybe; Wed, 18 Sep 2019 06:33:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqxcbkBOc5KBoUvOBjD40TZGNvSeS6ke7PYhG1++s7/CsvTtuYI/wJZQ9UCrtNrY1Wug6bVN X-Received: by 2002:aa7:d98a:: with SMTP id u10mr10272287eds.61.1568813625446; Wed, 18 Sep 2019 06:33:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568813625; cv=none; d=google.com; s=arc-20160816; b=HFOYDNM3EF/FMMud6uZCFQQEcpxDj8w1Yg1kPcZsSNIZEIsAmWc4z5LWFtq1N8VzNg 8bTaO0v6bxCR45SqQ+WIGAxMr4mbKX9SlJ9nwtuQdnvdpq78ZtjQQT1GFQ0T8vGwfHC8 xUStYWBrnNKQisfwno0VbFwCYKwLUgHa3/c8bEX3QmteZu9QPwSfZIq9jqXYh3Hiyn3Z Oge5Zhh0Vloocdu84CWzjympEgCBsV+HhbymHhcWqE/4UpDWL9RED3AGSVt2JnsWV6I0 VW9MEQMGfP7E2056aSytij5dNgVKdIxrtUPxO/i9iPCluQ/pLRW5EUrhcBzYn0Fd0kxu p3dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=0a0tFoBtJmn1wlFejHCK98d+UqjJddF5dcM/AdgNjWw=; b=J7diksP/BRj5AHIVyHSPNMkzC8cZHvzSr+MG2ceHORnnQOwacLbM/n9pkJ7gxJ7kPl mHTNVGNIloVWfWVJeAlRyUeDAiwoleCQXawFWxoPQbJ3OojSke4/ZngBNv4NqDbiNZbl lL7NZFDmNu1mH5R3KLaib7iTljt6/QMH/VJe8HDrk6ppDqjZFyL9GU+zi8DVN26nAZLz rcDsMzXswcir4L4thHKrUay/wrmYo/7iOp7ZvC57zwTXRRSwMEietDJ9GR9aF3dheMJc 2aOBAa/FcU2DrCrRP9TDJuHjWp4Kuo0AW8scJJR4AzFrZRxG6h/XS0b4OBKJtbEjfADD XeYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b26si470922edy.108.2019.09.18.06.33.21; Wed, 18 Sep 2019 06:33:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730847AbfIRM1j (ORCPT + 99 others); Wed, 18 Sep 2019 08:27:39 -0400 Received: from mail-sz.amlogic.com ([211.162.65.117]:56694 "EHLO mail-sz.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728539AbfIRM1h (ORCPT ); Wed, 18 Sep 2019 08:27:37 -0400 X-Greylist: delayed 903 seconds by postgrey-1.27 at vger.kernel.org; Wed, 18 Sep 2019 08:27:32 EDT Received: from droid12-sz.software.amlogic (10.28.8.22) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server id 15.1.1591.10; Wed, 18 Sep 2019 20:13:27 +0800 From: Xingyu Chen To: Philipp Zabel , Kevin Hilman CC: Rob Herring , Jerome Brunet , Neil Armstrong , Hanjie Lin , Xingyu Chen , Jianxin Pan , , , Subject: [PATCH 3/3] reset: add support for the Meson-A1 SoC Reset Controller Date: Wed, 18 Sep 2019 20:12:29 +0800 Message-ID: <1568808749-1196-1-git-send-email-xingyu.chen@amlogic.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.28.8.22] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The number of RESET registers and offset of RESET_LEVEL register for Meson-A1 are different from previous SoCs, In order to describe these differences, we introduce the struct meson_reset_param. Signed-off-by: Xingyu Chen Signed-off-by: Jianxin Pan --- drivers/reset/reset-meson.c | 35 ++++++++++++++++++++++++++++------- 1 file changed, 28 insertions(+), 7 deletions(-) diff --git a/drivers/reset/reset-meson.c b/drivers/reset/reset-meson.c index 5242e06..d9541c1 100644 --- a/drivers/reset/reset-meson.c +++ b/drivers/reset/reset-meson.c @@ -64,12 +64,16 @@ #include #include -#define REG_COUNT 8 #define BITS_PER_REG 32 -#define LEVEL_OFFSET 0x7c + +struct meson_reset_param { + int reg_count; + int level_offset; +}; struct meson_reset { void __iomem *reg_base; + const struct meson_reset_param *param; struct reset_controller_dev rcdev; spinlock_t lock; }; @@ -95,10 +99,12 @@ static int meson_reset_level(struct reset_controller_dev *rcdev, container_of(rcdev, struct meson_reset, rcdev); unsigned int bank = id / BITS_PER_REG; unsigned int offset = id % BITS_PER_REG; - void __iomem *reg_addr = data->reg_base + LEVEL_OFFSET + (bank << 2); + void __iomem *reg_addr; unsigned long flags; u32 reg; + reg_addr = data->reg_base + data->param->level_offset + (bank << 2); + spin_lock_irqsave(&data->lock, flags); reg = readl(reg_addr); @@ -130,10 +136,21 @@ static const struct reset_control_ops meson_reset_ops = { .deassert = meson_reset_deassert, }; +static const struct meson_reset_param meson8b_param = { + .reg_count = 8, + .level_offset = 0x7c, +}; + +static const struct meson_reset_param meson_a1_param = { + .reg_count = 3, + .level_offset = 0x40, +}; + static const struct of_device_id meson_reset_dt_ids[] = { - { .compatible = "amlogic,meson8b-reset" }, - { .compatible = "amlogic,meson-gxbb-reset" }, - { .compatible = "amlogic,meson-axg-reset" }, + { .compatible = "amlogic,meson8b-reset", .data = &meson8b_param}, + { .compatible = "amlogic,meson-gxbb-reset", .data = &meson8b_param}, + { .compatible = "amlogic,meson-axg-reset", .data = &meson8b_param}, + { .compatible = "amlogic,meson-a1-reset", .data = &meson_a1_param}, { /* sentinel */ }, }; @@ -151,12 +168,16 @@ static int meson_reset_probe(struct platform_device *pdev) if (IS_ERR(data->reg_base)) return PTR_ERR(data->reg_base); + data->param = of_device_get_match_data(&pdev->dev); + if (!data->param) + return -ENODEV; + platform_set_drvdata(pdev, data); spin_lock_init(&data->lock); data->rcdev.owner = THIS_MODULE; - data->rcdev.nr_resets = REG_COUNT * BITS_PER_REG; + data->rcdev.nr_resets = data->param->reg_count * BITS_PER_REG; data->rcdev.ops = &meson_reset_ops; data->rcdev.of_node = pdev->dev.of_node; -- 2.7.4