DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=j6BBlfIuCxqAvAviryK84NpzF1y3kdxdDZw+GpA/Rj4KKsKuE7rV+eSt6lXVo6XKPv2PxWudSKIo/RUUicg7pmTweIbAIusjQsyeFdx5dqDk8d6c+ZjHo3eRAebntHe61KqJeEG3YMMXS4qW1XKaLpiKHVDXkJ223rfjdQTeeWM=
Message-ID: <84144f020512290006x71d2c245s5e148fae15720d59@mail.gmail.com>
Date: Thu, 29 Dec 2005 10:06:15 +0200
From: Pekka Enberg <penberg@cs.helsinki.fi>
To: cai <junjiec@gmail.com>
Subject: Re: [RFC][fat] use mpage_readpage when cluster size is page-alignment
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
       linux-kernel <linux-kernel@vger.kernel.org>
In-Reply-To: <43B3844A.5050401@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Content-Disposition: inline
References: <ca992f110512272356l379dccc5k6288c28411ff7af4@mail.gmail.com>
	 <87u0ctwf93.fsf@devron.myhome.or.jp> <43B3844A.5050401@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 843
Lines: 20

Hi,

On 12/29/05, cai <junjiec@gmail.com> wrote:
> it should work, but maybe some performance loses if the
> cluster size is not page-alignment, for example, 4 sector/cluster
> in a 4KB/page system.
> because it will fall back to the block_read_full_page when
> non-adjacent block found in do_mpage_readpage, i think.
> the same applies to mpage_readpages too.

I am not sure I am following you. Shouldn't do_mpage_readpage work for
all adjacent blocks regardless of whether block size is page-aligned
or not? What's is the performance problem you're thinking of?

                            Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/