Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 18 Sep 2019 17:45:02 +0300
From:   tinywrkb <tinywrkb@gmail.com>
To:     Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc:     Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
        Baruch Siach <baruch@tkos.co.il>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, Fabio Estevam <festevam@gmail.com>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        open list <linux-kernel@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        NXP Linux Team <linux-imx@nxp.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Shawn Guo <shawnguo@kernel.org>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s
 max-speed
Message-ID: <20190918144502.GA2795497@arch-dsk-01>
References: <20190910155507.491230-1-tinywrkb@gmail.com>
 <20190910185033.GD9761@lunn.ch>
 <87muf6oyvr.fsf@tarshish>
 <20190915135652.GC3427@lunn.ch>
 <20190917124101.GA1200564@arch-dsk-01>
 <20190917125434.GH20778@lunn.ch>
 <20190917133253.GA1210141@arch-dsk-01>
 <20190917223013.GC25745@shell.armlinux.org.uk>
 <20190917224347.GD25745@shell.armlinux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190917224347.GD25745@shell.armlinux.org.uk>
User-Agent: Mutt/1.12.1 (2019-06-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Sep 17, 2019 at 11:43:47PM +0100, Russell King - ARM Linux admin wrote:
> On Tue, Sep 17, 2019 at 11:30:13PM +0100, Russell King - ARM Linux admin wrote:
> > On Tue, Sep 17, 2019 at 04:32:53PM +0300, tinywrkb wrote:
> > > Here's the output of # mii-tool -v -v eth0 
> > > 
> > > * linux-test-5.1rc1-a2703de70942-without_bad_commit
> > > 
> > > Using SIOCGMIIPHY=0x8947
> > > eth0: negotiated 100baseTx-FD flow-control, link ok
> > >   registers for MII PHY 0:
> > >     3100 796d 004d d072 15e1 c5e1 000f 0000
> > >     0000 0000 0800 0000 0000 0000 0000 a000
> > >     0000 0000 0000 f420 082c 0000 04e8 0000
> > >     3200 3000 0000 063d 0000 0000 0000 0000
> > 
> > I'll also mention some other discrepencies that I've just spotted in
> > this register set.
> > 
> > The BMSR is 0x796d.  Bit 2 is the link status, which is indicating
> > that link is up.  Bit 5 indicates negotiation complete, which it
> > claims it is.
> > 
> > The PHY has a second status register at 0x11 which gives real time
> > information.  That is 0x0000.  Bit 10 indicates link up, and is
> > indicating that the link is down.  Bit 11 is saying that the speed
> > and duplex is not resolved either.
> > 
> > So, there's contradictory information being reported by this PHY.
> > 
> > This brings up several questions:
> > 1. what is the _true_ state of the link?  Is the link up or down?
> > 
> > 2. what does the link partner think is the current link state and
> >    results of negotiation?
> > 
> > 3. should we be reading the register at 0x11 to determine the
> >    negotiation results and link state (maybe logically anding the
> >    present state with the BMSR link state)?
> > 
> > 
> > Compare that to a correctly functioning AR8035 such as I have in my
> > cubox-i4 connected to a Netgear GS116 switch:
> > 
> >    3100 796d 004d d072 15e1 c5e1 000d 2001
> >    0000 0200 3c00 0000 0000 4007 b29a a000
> >    0862 bc1c 0000 0000 082c 0000 07e8 0000
> >    3200 3000 0000 063e 0000 0005 2d47 8100.

My Cubox-i4 (no issue getting an IP address and GbE) is connected to the
same switch as the Cubox-i2 (the one affected by this bug).
mii-tool output for my Cubox-i4:

Using SIOCGMIIPHY=0x8947
  eth0: negotiated 1000baseT-FD flow-control, link ok
    registers for MII PHY 4:
      3100 796d 004d d072 15e1 c5e1 000d 0000
      0000 0200 3800 0000 0000 0000 0000 a000
      0000 0000 0000 0000 082c 0000 04e8 0000
      3200 3000 0000 063e 0000 0000 0000 0000
    product info: vendor 00:13:74, model 7 rev 2
    basic mode:   autonegotiation enabled
    basic status: autonegotiation complete, link ok
    capabilities: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
    advertising:  1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD flow-control
    link partner: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD flow-control

> > 
> > BMSR is again 0x796d.  The PHY specific status register this time
> > is 0xbc1c, which indicates 1G, full duplex, resolved, link up, no
> > smartspeed downgrade, tx/rx pause.
> > 
> > The register at 0x10 is a control register, which is strangely also
> > different between our two.  Apparently in your PHY configuration,
> > auto-MDI crossover mode is disabled, you are forced to MDI mode.
> > On hardware reset, this register contains 0x0862, as per my
> > example above, but yours is zero.
> > 
> > I don't think the difference in register 0x10 can be explained away
> > by operation of the smartspeed feature - so maybe my theory about
> > the advertisement registers being cleared by the PHY is wrong.  The
> > question is: how is 0x10 getting reset to zero in your setup?  Maybe
> > something has corrupted the configuration of the PHY in ways that
> > Linux doesn't know how to reprogram?
> > 
> > Have you tried power-cycling the cubox-i?

Yes, it doesn't help.

> 
> Hopefully one last thing, which will explain why you may not be able
> to get an IP address even with some of these tweaks I've been getting
> you to try.  Do you have either none or both of these commits in your
> kernel?
> 
> 0672d22a1924 ("ARM: dts: imx: Fix the AR803X phy-mode")
> 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode")
> 
> I think you'll have the latter but not the former.  You will need the
> former if you have the latter.
> 

I was checked-out at 5502b218e001 ("net: phy: use
phy_resolve_aneg_linkmode in genphy_read_status") so I was missing both.


> Could you try this patch instead - it seems that the PHY needs to be
> soft-reset for the write to take effect, and _even_ for the clearance
> of the bit to become visible in the register.
> 
> I'm not expecting this on its own to solve anything, but it should at
> least mean that the at803x doesn't modify the advertisement registers
> itself.  It may mean that the link doesn't even come up without forcing
> the advertisement via the ethtool command I mentioned before.
> 
> Thanks.
> 
>  drivers/net/phy/at803x.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
> index b3893347804d..69a58c0e6b42 100644
> --- a/drivers/net/phy/at803x.c
> +++ b/drivers/net/phy/at803x.c
> @@ -296,6 +296,16 @@ static int at803x_config_init(struct phy_device *phydev)
>         if (ret < 0)
>                 return ret;
> 
> +       /* Disable smartspeed */
> +       ret = phy_modify(phydev, 0x14, BIT(5), 0);
> +       if (ret < 0)
> +               return ret;
> +
> +       /* Must soft-reset the PHY for smartspeed disable to take effect */
> +       ret = genphy_soft_reset(phydev);

With the smartspeed disabled + soft reset patch against v5.1-rc1 +
cherry-pick the missing 0672d22a1924 ("ARM: dts: imx: Fix the AR803X
phy-mode") I'm finally getting an IP address.

Note that I do need the genphy soft reset without it I don't get an IP
address.

Also tested v5.3 with the patch and it does work.

I'm adding the output for v5.3 with this patch.

# mii-tool -v -v eth0
  Using SIOCGMIIPHY=0x8947
  eth0: negotiated 100baseTx-FD flow-control, link ok
    registers for MII PHY 0:
      3100 796d 004d d072 15e1 45e1 0007 0000
      0000 0200 0000 0000 0000 0000 0000 a000
      0000 0000 0000 f400 080c 0000 04e8 0000
      3200 3000 0000 063d 0000 0000 0000 0000
    product info: vendor 00:13:74, model 7 rev 2
    basic mode:   autonegotiation enabled
    basic status: autonegotiation complete, link ok
    capabilities: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
    advertising:  1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD flow-control
    link partner: 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD flow-control

# ethtool eth0
  Settings for eth0:
  	Supported ports: [ TP MII ]
  	Supported link modes:   10baseT/Half 10baseT/Full
  	                        100baseT/Half 100baseT/Full
  	                        1000baseT/Full
  	                        1000baseX/Full
  	Supported pause frame use: Symmetric
  	Supports auto-negotiation: Yes
  	Supported FEC modes: Not reported
  	Advertised link modes:  10baseT/Half 10baseT/Full
  	                        100baseT/Half 100baseT/Full
  	                        1000baseT/Full
  	                        1000baseX/Full
  	Advertised pause frame use: Symmetric
  	Advertised auto-negotiation: Yes
  	Advertised FEC modes: Not reported
  	Link partner advertised link modes:  10baseT/Half 10baseT/Full
  	                                     100baseT/Half 100baseT/Full
  	Link partner advertised pause frame use: Symmetric
  	Link partner advertised auto-negotiation: Yes
  	Link partner advertised FEC modes: Not reported
  	Speed: 100Mb/s
  	Duplex: Full
  	Port: MII
  	PHYAD: 0
  	Transceiver: internal
  	Auto-negotiation: on
  	Supports Wake-on: d
  	Wake-on: d
  	Link detected: yes

# journalctl -b | egrep -i 'phy|eth|fec'|grep -v usb
  kernel: Booting Linux on physical CPU 0x0
  kernel: libphy: Fixed MDIO Bus: probed
  kernel: libphy: fec_enet_mii_bus: probed
  kernel: fec 2188000.ethernet eth0: registered PHC device 0
  kernel: Atheros 8035 ethernet 2188000.ethernet-1:00: attached PHY driver [Atheros 8035 ethernet] (mii_bus:phy_addr=2188000.ethernet-1:00, irq=POLL)
  kernel: Atheros 8035 ethernet 2188000.ethernet-1:00: PHY advertising (00,00000200,000022ef) more modes than genphy supports, some modes not advertised.
  kernel: fec 2188000.ethernet eth0: Link is Up - 100Mbps/Full - flow control rx/tx
  kernel: IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
  systemd-networkd[364]: eth0: Gained carrier
  systemd-networkd[364]: eth0: DHCPv4 address 192.168.15.101/24 via 192.168.15.1
  systemd-networkd[364]: eth0: Gained IPv6LL
  systemd-networkd[364]: eth0: Configured

> I think this thread is a good illustration why breaking existing DT
> compatibility - even for the sake of fixing a bug - is just bad news.
> 
> -- 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
> According to speedtest.net: 11.9Mbps down 500kbps up