Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp6807601ybe; Wed, 18 Sep 2019 09:21:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqz4r2e7zcv4pagS9tLKKdwMw6CqYH0fH5OaRLaDZ2S/ip1bM1ybK8SkS6CiDk4STe8gyzZ1 X-Received: by 2002:a50:b6c8:: with SMTP id f8mr11384569ede.33.1568823664417; Wed, 18 Sep 2019 09:21:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568823664; cv=none; d=google.com; s=arc-20160816; b=EnwDwAvjYAa0cgQQhLNRgSaGzGPd6dZqnmdqbDsCa5HqgaIrKEi+xww4IPY91Zb0Dk 1iLaU60SS20ST2Ws3A9ZBUKmmMdAnOTieU+bjG8a1SySGWO0tlGU9mjb/EyMJsLJn+cm f1jz7s09hfpmxl64MFBsGX68PcXtHbRf/kQqeRUpk/hsMvUQ/MZFWn1zN1zgY2pyGFTr vrxwF+J6S54eKKyDmM+Qui33jhml8HHD3a9D5kVk8Pc6KJI1Gn7CsHDH+7d171Z4gF87 3BE2BPUacXFj/YuoDL/OPRSVcrKdVlTnehGiwJepPXxbsYJt79vGwBfaVbeGl/we1DBS pZVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=T9Z9pB8moRT0dy0AOdQbY2bbpUqXWxaBpQbE3e39Oic=; b=mp6dEdgViifoWK1adydPMSn5tkaN30K3RtfdbByz87JlXV7SfQg7/K9G+mWugT2tlS UEIUV2Z9eVZFFE2kTDB2BALLxgHnRuaIc8TbJZhrqTlc1Eokz6UlI4TjZqzbbBqLOJiJ astVc2rWx6nVXm9BTUVsBT/oZAzIN3k2KkhcDIl6abtBVD2T85ZDqUfIT42Et3/gl686 jHXd3Dh82YwCBJYZX3ShqXuZRvq38JDfp6E1i7thL+ov6rcokxrcDyt5b11VvIU3wNAu C6l1PPqb+GxQjJopBkL0m0iKUmT0Ofux1Uo3Jo3UZWPpwhfj4LoDgpqNFtluPHjdwYbR BmUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0YZh2szI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b26si802419edy.108.2019.09.18.09.20.26; Wed, 18 Sep 2019 09:21:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0YZh2szI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729561AbfIRLFw (ORCPT + 99 others); Wed, 18 Sep 2019 07:05:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:55322 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726277AbfIRLFv (ORCPT ); Wed, 18 Sep 2019 07:05:51 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4F02021920; Wed, 18 Sep 2019 11:05:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568804750; bh=cfR8cp9RXeCZCrpG8ViPCQUuSx8Z3CiXOPGljSApjEA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0YZh2szIeQm27pXuTKLTHYih2e1HECMwYocnHTSG9EoPMofO3/COjdSNlWDhwV1tJ m8rytbtGAGoOHCTrH8gziPc9Ms+RY7KfdFmcqxaLBjr0cUv3Kc2eGEFQpgnE+BAzFA u2rg867+6ogshkqIuzNJLXQuGaDpWN2vuBZnyWco= Date: Wed, 18 Sep 2019 13:05:48 +0200 From: Greg KH To: Ju Hyung Park Cc: Dan Carpenter , devel@driverdev.osuosl.org, linkinjeon@gmail.com, Valdis Kletnieks , Sergey Senozhatsky , Namjae Jeon , linux-kernel@vger.kernel.org, alexander.levin@microsoft.com, sergey.senozhatsky@gmail.com, linux-fsdevel@vger.kernel.org, sj1557.seo@samsung.com Subject: Re: [PATCH] staging: exfat: add exfat filesystem code to Message-ID: <20190918110548.GA1894362@kroah.com> References: <004401d56dc9$b00fd7a0$102f86e0$@samsung.com> <20190918061605.GA1832786@kroah.com> <20190918063304.GA8354@jagdpanzerIV> <20190918082658.GA1861850@kroah.com> <20190918092405.GC2959@kadam> <20190918100803.GD2959@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 18, 2019 at 07:46:25PM +0900, Ju Hyung Park wrote: > On Wed, Sep 18, 2019 at 7:09 PM Dan Carpenter wrote: > > Use Kconfig. > > Not just that. > There are a lot of non-static functions that's not marked ex/sdfat-specific. > (which we would have to clean it up eventually) Then clean them up :) > Even with sdFAT base, there are some non-static functions named as exfat. Then just force both filesystems to only be built as a module and all should be fine, right? > Figuring out a solution for this is pretty pointless imho when one of > the drivers will be dropped soon(ish) anyways. Given we only have one filesytem that is submitted in patch form, I think people are making a lot of noise over nothing :) thanks, greg k-h