Subject: Re: [PATCH] ipw2200 stack reduction
From: Zhu Yi <yi.zhu@intel.com>
To: Jens Axboe <axboe@suse.de>
Cc: jketreno@linux.intel.com, Linux Kernel <linux-kernel@vger.kernel.org>
In-Reply-To: <20051228212934.GA2772@suse.de>
References: <20051228212934.GA2772@suse.de>
Content-Type: text/plain
Organization: Intel Corp.
Date: Thu, 29 Dec 2005 17:07:08 +0800
Message-Id: <1135847228.9670.69.camel@debian.sh.intel.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 993
Lines: 27

On Wed, 2005-12-28 at 22:29 +0100, Jens Axboe wrote:
> The reason is the host_cmd structure is large (500 bytes). All other
> functions currently using ipw_send_cmd() suffer from the same problem.
> This patch introduces ipw_send_cmd_simple() for commands with no data
> transfer, and ipw_send_cmd_pdu() for commands with a data payload.

Hi Jens,

Thanks for point this out and provide the patch. One comment:

> +static struct host_cmd *ipw_host_cmd_get(u8 command, u8 len)
>  {
> ...
> +       cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);

This will still alloc 500 bytes for each command. I think if we want to
dynamically alloc the struct, we can split the struct to head and
payload and alloc the payload according to the real size.

Thanks,
-yi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/