Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp6895249ybe; Wed, 18 Sep 2019 10:47:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqy12+0y+x39G308w5fKA8UWUTo/wlfpJZyyAV3g3CPe388QcT/e9yyqtOBuT5kNr+2GV85u X-Received: by 2002:a05:6402:160d:: with SMTP id f13mr11760666edv.227.1568828837353; Wed, 18 Sep 2019 10:47:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568828837; cv=none; d=google.com; s=arc-20160816; b=INhSUPFjYeB+ZyoqXlSWg89RDz8su8IMzv41h8Zdd6KtOr5IRZwaOAl4vzFSOZAnlD LT6iv1FvrtloOBLzRkY9Kp6GWSkle3ssWMlh4kC6sTbBsUjb+L4bwkawS2amB1ciOLXN qbWkfUSwRUSXIGbWBMuTcbVgwApKmTcUMq98fJshvh+yBy7+/pb7Z3RmROGu6CBgNZSN MnCUBH+d6vfqxs4kYGgJYTFVjA1xIMTQfwNQ0q+aipnCRNiC+I4j7RevvbgxpMMOAq8p lXa1lJBfLFSeAQTUPitDhETf3VkBqvXeBWQ/FzV28Juxk59CEzOWWgOJn6IAJ/FGZmoS ImDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature; bh=3Yblg+LB3V/R3GdNlbQif00/TPj0swNUNYsErjlgIhk=; b=Qs5EcSS74nK8gWuWPYxFl2ZV2AhLJfPj4VLmrkaQ3Ickhv1n/CHZiNbZVymj6p7Kle Ga3Lp7DOmwFznL5ZV9kvK49p5Hn3VHP9XXuTCEil+QFnHxLhJnAZ0z78BNw2Lx6+Fd7G tUvABv+9DxIKDNqOnVfY1nnvoejx+erNcCRCj8+j21lWTA2kG7NhA1+IpbcVm/E5/Ge/ 9hLl1ssm6lz5qLHEb1j/k4RAcW5413SNmOhH64NfI8vyjGdYlsf9+EUi46PK1yllDuJh zn/vykgQ4M+mbJSWHZedtxghAUNHiWdfE8/gxNU7TuLTKULWarOOMc2tAuM7kchdqrZj g+Iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HXFUoMVf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k1si3722995ede.255.2019.09.18.10.46.52; Wed, 18 Sep 2019 10:47:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HXFUoMVf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387420AbfIRR2j (ORCPT + 99 others); Wed, 18 Sep 2019 13:28:39 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:44061 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729319AbfIRR2i (ORCPT ); Wed, 18 Sep 2019 13:28:38 -0400 Received: by mail-pl1-f195.google.com with SMTP id q15so257108pll.11; Wed, 18 Sep 2019 10:28:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=3Yblg+LB3V/R3GdNlbQif00/TPj0swNUNYsErjlgIhk=; b=HXFUoMVf9oYz5skz3MXc8uOX2c+LVWUkc+AnYLuxa+VPe4GMYiTSJZRTduFYB90vYA wsF/clRsQJpZgHxDCYENhzvfpsJuWYpdZswM/OE2TpT7C74RKshiWkUGMlwWq5ERjR8U dbozY19G4vKTB+A+M9xrLHMkmqzurVlBzXt5gglIlxmkFp4pjw5TIo3rdSakni6zodzg RnaKIm4r9H2WCyRfgZ6B52RR09/dnQ6S+Ri4h91KhOl/oDT/037dTsuM1m+157PenJor U//lr+7bYy+A5b9MWMO4lUqBqNvjZghw0wfCegy+lZNzsPsHtTUQlZPEC8SNspurvWfJ keZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=3Yblg+LB3V/R3GdNlbQif00/TPj0swNUNYsErjlgIhk=; b=Qlnaxp7Gr9ixmXCkl4meMd5/u7bIr2gPI2r7P6E7c6Eo4LxYeRulah7+Nygp3Yxlf3 ceto7gRDGR5mKLT8OuGlQdArD3L4/WDNQSYZPzv7pD04S66DHwrkdlQCNRzgfCbBKnzv ZnbzsuhJe12b1tC6mV2il/iHbGuxYQXTePaH2ijr6w899rPBe6zzL7yu8ajT00S0yrx2 tXpzI3Vw3jDP3GK0rsS+DN8HFhMjQiuwJ6nAyUFCzRXlFVxP5WbMiY1Ds4W6g74f/F6Z RDbd5QqGxyQwopxTiUTBdFnlLIx6JkktYh2DFnkz0T8NWVnQL/Yw7OoZ+RGlfUJUSHbt 3EOQ== X-Gm-Message-State: APjAAAUBWJWqdT1HfQbJEkno6zwVoJAP28tarNJOrp8J0x+O9cqnMGRd hPkI/kXaFT34M88RrvqgQgd2htq6 X-Received: by 2002:a17:902:bd41:: with SMTP id b1mr5374116plx.174.1568827717447; Wed, 18 Sep 2019 10:28:37 -0700 (PDT) Received: from SD ([2405:204:828a:aaec:f0de:d7f9:abdf:1568]) by smtp.gmail.com with ESMTPSA id q42sm3385855pja.16.2019.09.18.10.28.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2019 10:28:36 -0700 (PDT) Date: Wed, 18 Sep 2019 22:58:23 +0530 From: Saiyam Doshi To: ludovic.desroches@microchip.com, ulf.hansson@linaro.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] mmc: host: atmel-mci: assign false/true to bool variable Message-ID: <20190918172823.GA28786@SD> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use false/true instead of 0/1 in bool variable assignment. This fixes below coccicheck warning. "WARNING: Assignment of 0/1 to bool variable" Generated by: scripts/coccinelle/misc/boolinit.cocci More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Saiyam Doshi --- drivers/mmc/host/atmel-mci.c | 50 ++++++++++++++++++------------------ 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c index c26fbe5f2222..91088b1712ae 100644 --- a/drivers/mmc/host/atmel-mci.c +++ b/drivers/mmc/host/atmel-mci.c @@ -706,7 +706,7 @@ static void atmci_timeout_timer(struct timer_list *t) host->mrq->cmd->error = -ETIMEDOUT; host->cmd = NULL; } - host->need_reset = 1; + host->need_reset = true; host->state = STATE_END_REQUEST; smp_wmb(); tasklet_schedule(&host->tasklet); @@ -1610,7 +1610,7 @@ static void atmci_command_complete(struct atmel_mci *host, else if (host->mrq->data && (host->mrq->data->blksz & 3)) { if (host->caps.need_blksz_mul_4) { cmd->error = -EINVAL; - host->need_reset = 1; + host->need_reset = true; } } else cmd->error = 0; @@ -2396,45 +2396,45 @@ static void atmci_get_cap(struct atmel_mci *host) dev_info(&host->pdev->dev, "version: 0x%x\n", version); - host->caps.has_dma_conf_reg = 0; - host->caps.has_pdc = 1; - host->caps.has_cfg_reg = 0; - host->caps.has_cstor_reg = 0; - host->caps.has_highspeed = 0; - host->caps.has_rwproof = 0; - host->caps.has_odd_clk_div = 0; - host->caps.has_bad_data_ordering = 1; - host->caps.need_reset_after_xfer = 1; - host->caps.need_blksz_mul_4 = 1; - host->caps.need_notbusy_for_read_ops = 0; + host->caps.has_dma_conf_reg = false; + host->caps.has_pdc = true; + host->caps.has_cfg_reg = false; + host->caps.has_cstor_reg = false; + host->caps.has_highspeed = false; + host->caps.has_rwproof = false; + host->caps.has_odd_clk_div = false; + host->caps.has_bad_data_ordering = true; + host->caps.need_reset_after_xfer = true; + host->caps.need_blksz_mul_4 = true; + host->caps.need_notbusy_for_read_ops = false; /* keep only major version number */ switch (version & 0xf00) { case 0x600: case 0x500: - host->caps.has_odd_clk_div = 1; + host->caps.has_odd_clk_div = true; /* Fall through */ case 0x400: case 0x300: - host->caps.has_dma_conf_reg = 1; - host->caps.has_pdc = 0; - host->caps.has_cfg_reg = 1; - host->caps.has_cstor_reg = 1; - host->caps.has_highspeed = 1; + host->caps.has_dma_conf_reg = true; + host->caps.has_pdc = false; + host->caps.has_cfg_reg = true; + host->caps.has_cstor_reg = true; + host->caps.has_highspeed = true; /* Fall through */ case 0x200: - host->caps.has_rwproof = 1; - host->caps.need_blksz_mul_4 = 0; - host->caps.need_notbusy_for_read_ops = 1; + host->caps.has_rwproof = true; + host->caps.need_blksz_mul_4 = false; + host->caps.need_notbusy_for_read_ops = true; /* Fall through */ case 0x100: - host->caps.has_bad_data_ordering = 0; - host->caps.need_reset_after_xfer = 0; + host->caps.has_bad_data_ordering = false; + host->caps.need_reset_after_xfer = false; /* Fall through */ case 0x0: break; default: - host->caps.has_pdc = 0; + host->caps.has_pdc = false; dev_warn(&host->pdev->dev, "Unmanaged mci version, set minimum capabilities\n"); break; -- 2.20.1