Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] x86/mm: Remove set_pages_x() and set_pages_nx()
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Christoph Hellwig <hch@lst.de>,
        Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
References: <20190918164121.30006-1-Larry.Finger@lwfinger.net>
 <20190918164518.GA19222@lst.de>
 <b4fa6ab6-ab30-fc05-0f9f-93c41e7e8c79@lwfinger.net>
 <CAHk-=wji2fMDpSwvR4U8FkKBx8=eZtg3CmWtH7hACzeHbBei8A@mail.gmail.com>
From:   Larry Finger <Larry.Finger@lwfinger.net>
Message-ID: <bd5684ee-afaf-a9ba-6c32-15d2aa94733c@lwfinger.net>
Date:   Wed, 18 Sep 2019 13:17:13 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <CAHk-=wji2fMDpSwvR4U8FkKBx8=eZtg3CmWtH7hACzeHbBei8A@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 9/18/19 12:53 PM, Linus Torvalds wrote:
> On Wed, Sep 18, 2019 at 10:50 AM Larry Finger <Larry.Finger@lwfinger.net> wrote:
>>
>> Is there approved way for pages to be set to be executable by an external module
>> that would not be a security issue?
> 
> Point to what external module and why.
> 
> Honestly, the likely answer is simply "no". Why would an external
> module ever need to make something executable that isn't read-only
> code? That's pretty fundamental. Marking data executable is fairly
> questionable these days.
> 
> Instead, what might work is to have some higher-level concept that we
> actually trust, and that isn't about making data executable, but about
> doing something reasonable.
> 
> See the difference? Making things executable is not ok, but perhaps a
> "alternative runtime code sequence" is ok.
> 
>                  Linus


Linus,

Yes, I do see the difference.

The external module is vboxdrv, which is part of VirtualBox. The setting of 
pages to be executable appears to have been added in kernel 2.4.20.

I am now testing with the former calls to set_pages_x() and set_pages_nx() 
disabled. Thus far, VMs seem to be running OK. I will contact Oracle to discuss 
the matter with them and see if there is some special case that requires this 
facility. If there is one, then they will need to discuss it with you and Christoph.

Larry