Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp285926ybe; Wed, 18 Sep 2019 17:19:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqxDQNT1v6lrdhmMB1aOPz2fcCNjlLcvprpoTtgfyMBuB6tESuBzIHYuocB+EQvt5Wrg/4zr X-Received: by 2002:a50:ef12:: with SMTP id m18mr13144923eds.18.1568852356927; Wed, 18 Sep 2019 17:19:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568852356; cv=none; d=google.com; s=arc-20160816; b=pmNwJ8XhakEd4HuMyUWvAvlK6qkecGi5+G5tW4en+eozs00VKT93SRVVPCkEWgJ8Jp bdepfQ81FBfV0+q6nK2SP8n3OQsXPVDxs6BnrUNnH5pk/Q+lDDYt2FARWXZUzOwwTzRK VF/yWxLzfV0JupLhBGbhBgO6QTGJnpt5VKaoJ1oXIXxlzIf+Dl+aTozvNMU2J9UC8BfE fcNL7aHogSSv24/bAdNhhFmxXyNRUCPwWrZ8b+cQvFIav8mPQvQ/wsfN06IhRf9mMDvE 5qZjURj0UcYtolkxEHgClo8YTOW9vRT51P8vESEvCwCDpA+RJcrG//cWfQSWIujjlfpX Ijww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=4jFcf9iaa7Tt4QrvMrWEeq0CzGPxx9DksNwganDUQw0=; b=mESXhTpOyD4ouvpMky0azjX6vtk0vQpUC3+VCJ4SqcE9BihdkoToRp3POGA/qnCjS1 HUanfNo9DHIkud/rNbqT8HH0KAT10wDk0kRWojXkWE7S7yaRol8uk6rPPzF42Gll2xtv +WVhWSJmFMgErzAX2//BlKqksEbZ4tZXyGmxjL1FYqu4F0ZwMfLFipGSsLAIrSTj67wJ DF+8U65ReSSgdfYOU7vXcW7ipqmvYcC823uArWJz9kUF6qg6vtN0hxiUbNkeo4zOgN/7 HwDhZG1WLCXzAeG6+M7oRa2Uk9yVW3VlqC0Ot49s4c/6BgL7YlDWmb2aolehPP5YmmA+ pcjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=AHzxOc1w; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s14si4637547edc.83.2019.09.18.17.18.53; Wed, 18 Sep 2019 17:19:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=AHzxOc1w; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730457AbfISAJx (ORCPT + 99 others); Wed, 18 Sep 2019 20:09:53 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:40056 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726714AbfISAJw (ORCPT ); Wed, 18 Sep 2019 20:09:52 -0400 Received: by mail-pf1-f194.google.com with SMTP id x127so1033616pfb.7 for ; Wed, 18 Sep 2019 17:09:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4jFcf9iaa7Tt4QrvMrWEeq0CzGPxx9DksNwganDUQw0=; b=AHzxOc1w8Ea6pHo+1TvR/i0feaAwaavrGAD9fcT7m8YnFkOJx3p43rpMLW2m/wHb0C c/cxBpUKn5fQNkhvjHMXRO+SDzjOurEm+Ge47N94fybQ6OHOH7/eDiQcIB3Fjmb/FIrY d0jlclUlTAsDoP/XloLOW3tg2nHBY8nSbSrmg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4jFcf9iaa7Tt4QrvMrWEeq0CzGPxx9DksNwganDUQw0=; b=deNQk27T/360Wye7RciLAnoC2W79dbrrGk/NcfnFycIvvuuF1RxRCb2P1qnfPQT/w8 O64MsXnhg0MsHHIlNilhiG4ujRFHPrq5zj63P/EEfSIOQ3KhI6RJs/cY+BtoUMiyx3Xf JBDOgq3JkOBwSeKqygCIYfgWprtDl0jmJ9D/izMUvVmfn/rmu0UvFpm67foxFI9YPGVu crRZJp8qJmT3SHYqotfGMAnUNf3j6TNm9G9n0cVP1LeJ4/Nult16TbOIco/hSe9ViTpr 2/w0UhDJIV6wNkFIoKVR+3mhTBCOcjGi/XCnK4ZjHxC1BO6oK+woLRZ2LZ1nnsISGBZD Zn1g== X-Gm-Message-State: APjAAAXcfImBGHY54MCuoybzDZf5uk/7uG0ADjSBpOD4PTn90uaAezT/ rNhDvpYV+xsBpCa03tWnT2eyUmb5w8o= X-Received: by 2002:a17:90a:d791:: with SMTP id z17mr603695pju.41.1568851792121; Wed, 18 Sep 2019 17:09:52 -0700 (PDT) Received: from localhost ([2620:15c:202:1:75a:3f6e:21d:9374]) by smtp.gmail.com with ESMTPSA id k31sm3890132pjb.14.2019.09.18.17.09.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Sep 2019 17:09:51 -0700 (PDT) From: Matthias Kaehlcke To: MyungJoo Ham , Kyungmin Park , Chanwoo Choi Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Kaehlcke Subject: [PATCH] devfreq: Make log message more explicit when devfreq device already exists Date: Wed, 18 Sep 2019 17:09:46 -0700 Message-Id: <20190919000946.158454-1-mka@chromium.org> X-Mailer: git-send-email 2.23.0.237.gc6a4ce50a0-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Before creating a new devfreq device devfreq_add_device() checks if there is already a devfreq dev associated with the requesting device (parent). If that's the case the function rejects to create another devfreq dev for that parent and logs an error. The error message is very unspecific, make it a bit more explicit. Signed-off-by: Matthias Kaehlcke --- drivers/devfreq/devfreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index ab22bf8a12d6..0e2dd734ab58 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -625,7 +625,7 @@ struct devfreq *devfreq_add_device(struct device *dev, devfreq = find_device_devfreq(dev); mutex_unlock(&devfreq_list_lock); if (!IS_ERR(devfreq)) { - dev_err(dev, "%s: Unable to create devfreq for the device.\n", + dev_err(dev, "%s: devfreq device already exists!\n", __func__); err = -EINVAL; goto err_out; -- 2.23.0.237.gc6a4ce50a0-goog