Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp341728ybe; Wed, 18 Sep 2019 18:30:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqyaKOMDpPrad9Bls/BpZP4qaYzfMi7AOr2C056Eo1aepI62cKmiElO2AHiOAGaU+Ezgzr8Y X-Received: by 2002:a50:cf8b:: with SMTP id h11mr1748405edk.236.1568856656952; Wed, 18 Sep 2019 18:30:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568856656; cv=none; d=google.com; s=arc-20160816; b=pD4oLeCtd86HC2FcVU82DZmF0Mipx9GxiRZGWK8UgacoQKgHRlUISrUWFEtivo00Ic 65Mo6d0l/PxGufHGVbIZKlAFMXr98kYMz9GQuQ+LZA9PyHARUhi5yu4/FpR/KA5XaPpj x5HUzJThPeeWI8rhc/nQtc9b9NJ8DjVpNpMJNCsF0Nz1tVbI1Ndvq2i7gNkqigfgP5tT wwa9663DzD4LiH8DzvqWUcjJLcmDZdLQSu6KtUm4wPZC3hXO0EBvs3xpXMBk67GSI7PQ vbt03KEj096dq/ZnD3Xw9xfj3j/prrumLZ3TJYAcJ1p0JRazx98FikwXK7ojkfEvaUL+ 56Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:user-agent:organization:references:in-reply-to:date:cc :to:from:subject; bh=b++RDnp1w8ycjov978HnT4RAgaw9AvZIvrWejbn73cM=; b=D/d9A1aHeWv2xkSk/lOkbfya84G2wV+kLOn0A2qDkGHyYTxORSr7TqNNPz7cDzXWwR hpUhzfjpkWQ673jToHZkssg+UlWOg5x/Ma4VCDqtdmMuNAKyAOPY00eHgCRhq/jvIoGn McboehAWkizioDFdX4K+uHt90SY9ScHdVcLzaNZcd1bWcpC/5SIorMfWyjXQTe0S/5I8 s2jBgvmcRr2A6IaNQIb+3658Rspp/96wmp8pOfL0jfLVkejKvrvVLemOuxkgZlXiPfJQ 5X5IU4XefloH34bY9/ueyw3y6iZW2heKBfwgD0GtwDseIJ+lMBBh0m5CKSAitQjhFqxT GjZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k16si3844423ejc.134.2019.09.18.18.30.33; Wed, 18 Sep 2019 18:30:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387671AbfISBZH (ORCPT + 99 others); Wed, 18 Sep 2019 21:25:07 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:11754 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387648AbfISBZH (ORCPT ); Wed, 18 Sep 2019 21:25:07 -0400 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x8J1NpDw067250 for ; Wed, 18 Sep 2019 21:25:06 -0400 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0a-001b2d01.pphosted.com with ESMTP id 2v3vdndtf1-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 18 Sep 2019 21:25:05 -0400 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 19 Sep 2019 02:24:56 +0100 Received: from b06avi18626390.portsmouth.uk.ibm.com (9.149.26.192) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 19 Sep 2019 02:24:52 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x8J1OPOK19464672 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 19 Sep 2019 01:24:25 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BC5964C050; Thu, 19 Sep 2019 01:24:51 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 23A444C040; Thu, 19 Sep 2019 01:24:51 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 19 Sep 2019 01:24:51 +0000 (GMT) Received: from adsilva.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id 9697AA01EB; Thu, 19 Sep 2019 11:24:49 +1000 (AEST) Subject: Re: [PATCH 4/5] ocxl: Add functions to map/unmap LPC memory From: "Alastair D'Silva" To: "Alastair D'Silva" Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Frederic Barrat , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , Thomas Gleixner , =?ISO-8859-1?Q?C=E9dric?= Le Goater , Allison Randal , Vaibhav Jain , Mahesh Salgaonkar , Anju T Sudhakar , David Gibson , Nicholas Piggin , Masahiro Yamada , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Thu, 19 Sep 2019 11:24:49 +1000 In-Reply-To: <20190917014307.30485-5-alastair@au1.ibm.com> References: <20190917014307.30485-1-alastair@au1.ibm.com> <20190917014307.30485-5-alastair@au1.ibm.com> Organization: IBM Australia Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.4 (3.32.4-1.fc30) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19091901-0016-0000-0000-000002ADD4F7 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19091901-0017-0000-0000-0000330E8198 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-09-19_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1909190010 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2019-09-17 at 11:43 +1000, Alastair D'Silva wrote: > From: Alastair D'Silva > > Add functions to map/unmap LPC memory > > Signed-off-by: Alastair D'Silva > --- > drivers/misc/ocxl/config.c | 4 +++ > drivers/misc/ocxl/core.c | 50 > +++++++++++++++++++++++++++++++ > drivers/misc/ocxl/link.c | 4 +-- > drivers/misc/ocxl/ocxl_internal.h | 10 +++++-- > include/misc/ocxl.h | 18 +++++++++++ > 5 files changed, 82 insertions(+), 4 deletions(-) > > diff --git a/drivers/misc/ocxl/config.c b/drivers/misc/ocxl/config.c > index c8e19bfb5ef9..fb0c3b6f8312 100644 > --- a/drivers/misc/ocxl/config.c > +++ b/drivers/misc/ocxl/config.c > @@ -568,6 +568,10 @@ static int read_afu_lpc_memory_info(struct > pci_dev *dev, > afu->special_purpose_mem_size = > total_mem_size - lpc_mem_size; > } > + > + dev_info(&dev->dev, "Probed LPC memory of %#llx bytes and > special purpose memory of %#llx bytes\n", > + afu->lpc_mem_size, afu->special_purpose_mem_size); > + > return 0; > } > > diff --git a/drivers/misc/ocxl/core.c b/drivers/misc/ocxl/core.c > index fdfe4e0a34e1..eb24bb9d655f 100644 > --- a/drivers/misc/ocxl/core.c > +++ b/drivers/misc/ocxl/core.c > @@ -210,6 +210,55 @@ static void unmap_mmio_areas(struct ocxl_afu > *afu) > release_fn_bar(afu->fn, afu->config.global_mmio_bar); > } > > +int ocxl_map_lpc_mem(struct ocxl_afu *afu) > +{ > + struct pci_dev *dev = to_pci_dev(afu->fn->dev.parent); > + > + if ((afu->config.lpc_mem_size + afu- > >config.special_purpose_mem_size) == 0) > + return 0; > + > + afu->lpc_base_addr = ocxl_link_lpc_online(afu->fn->link, dev); > + if (afu->lpc_base_addr == 0) > + return -EINVAL; > + > + if (afu->config.lpc_mem_size) { > + afu->lpc_res.start = afu->lpc_base_addr + afu- > >config.lpc_mem_offset; > + afu->lpc_res.end = afu->lpc_res.start + afu- > >config.lpc_mem_size - 1; > + } > + > + if (afu->config.special_purpose_mem_size) { > + afu->special_purpose_res.start = afu->lpc_base_addr + > + afu- > >config.special_purpose_mem_offset; > + afu->special_purpose_res.end = afu- > >special_purpose_res.start + > + afu- > >config.special_purpose_mem_size - 1; > + } > + > + return 0; > +} > +EXPORT_SYMBOL(ocxl_map_lpc_mem); > + > +struct resource *ocxl_afu_lpc_mem(struct ocxl_afu *afu) > +{ > + return &afu->lpc_res; > +} > +EXPORT_SYMBOL(ocxl_afu_lpc_mem); > + > +static void unmap_lpc_mem(struct ocxl_afu *afu) > +{ > + struct pci_dev *dev = to_pci_dev(afu->fn->dev.parent); > + > + if (afu->lpc_res.start || afu->special_purpose_res.start) { > + void *link = afu->fn->link; > + > + ocxl_link_lpc_offline(link, dev); > + > + afu->lpc_res.start = 0; > + afu->lpc_res.end = 0; > + afu->special_purpose_res.start = 0; > + afu->special_purpose_res.end = 0; > + } > +} > + > static int configure_afu(struct ocxl_afu *afu, u8 afu_idx, struct > pci_dev *dev) > { > int rc; > @@ -250,6 +299,7 @@ static int configure_afu(struct ocxl_afu *afu, u8 > afu_idx, struct pci_dev *dev) > > static void deconfigure_afu(struct ocxl_afu *afu) > { > + unmap_lpc_mem(afu); > unmap_mmio_areas(afu); > reclaim_afu_pasid(afu); > reclaim_afu_actag(afu); > diff --git a/drivers/misc/ocxl/link.c b/drivers/misc/ocxl/link.c > index 2874811a4398..9e303a5f4d85 100644 > --- a/drivers/misc/ocxl/link.c > +++ b/drivers/misc/ocxl/link.c > @@ -738,7 +738,7 @@ int ocxl_link_add_lpc_mem(void *link_handle, u64 > size) > } > EXPORT_SYMBOL_GPL(ocxl_link_add_lpc_mem); > > -u64 ocxl_link_lpc_map(void *link_handle, struct pci_dev *pdev) > +u64 ocxl_link_lpc_online(void *link_handle, struct pci_dev *pdev) > { > struct ocxl_link *link = (struct ocxl_link *) link_handle; > > @@ -759,7 +759,7 @@ u64 ocxl_link_lpc_map(void *link_handle, struct > pci_dev *pdev) > return link->lpc_mem; > } > > -void ocxl_link_lpc_release(void *link_handle, struct pci_dev *pdev) > +void ocxl_link_lpc_offline(void *link_handle, struct pci_dev *pdev) > { > struct ocxl_link *link = (struct ocxl_link *) link_handle; > > diff --git a/drivers/misc/ocxl/ocxl_internal.h > b/drivers/misc/ocxl/ocxl_internal.h > index db2647a90fc8..5656a4aab5b7 100644 > --- a/drivers/misc/ocxl/ocxl_internal.h > +++ b/drivers/misc/ocxl/ocxl_internal.h > @@ -52,6 +52,12 @@ struct ocxl_afu { > void __iomem *global_mmio_ptr; > u64 pp_mmio_start; > void *private; > + u64 lpc_base_addr; /* Covers both LPC & special purpose memory > */ > + struct bin_attribute attr_global_mmio; > + struct bin_attribute attr_lpc_mem; The bin_attributes are not needed here. > + struct resource lpc_res; > + struct bin_attribute attr_special_purpose_mem; > + struct resource special_purpose_res; > }; > > enum ocxl_context_status { > @@ -170,7 +176,7 @@ extern u64 ocxl_link_get_lpc_mem_sz(void > *link_handle); > * @link_handle: The OpenCAPI link handle > * @pdev: A device that is on the link > */ > -u64 ocxl_link_lpc_map(void *link_handle, struct pci_dev *pdev); > +u64 ocxl_link_lpc_online(void *link_handle, struct pci_dev *pdev); > > /** > * Release the LPC memory device for an OpenCAPI device > @@ -181,6 +187,6 @@ u64 ocxl_link_lpc_map(void *link_handle, struct > pci_dev *pdev); > * @link_handle: The OpenCAPI link handle > * @pdev: A device that is on the link > */ > -void ocxl_link_lpc_release(void *link_handle, struct pci_dev *pdev); > +void ocxl_link_lpc_offline(void *link_handle, struct pci_dev *pdev); > > #endif /* _OCXL_INTERNAL_H_ */ > diff --git a/include/misc/ocxl.h b/include/misc/ocxl.h > index 06dd5839e438..a1897737908d 100644 > --- a/include/misc/ocxl.h > +++ b/include/misc/ocxl.h > @@ -212,6 +212,24 @@ int ocxl_irq_set_handler(struct ocxl_context > *ctx, int irq_id, > > // AFU Metadata > > +/** > + * Map the LPC system & special purpose memory for an AFU > + * > + * Do not call this during device discovery, as there may me > multiple > + * devices on a link, and the memory is mapped for the whole link, > not > + * just one device. It should only be called after all devices have > + * registered their memory on the link. > + * > + * afu: The AFU that has the LPC memory to map > + */ > +extern int ocxl_map_lpc_mem(struct ocxl_afu *afu); > + > +/** > + * Get the physical address range of LPC memory for an AFU > + * afu: The AFU associated with the LPC memory > + */ > +extern struct resource *ocxl_afu_lpc_mem(struct ocxl_afu *afu); > + > /** > * Get a pointer to the config for an AFU > * -- Alastair D'Silva Open Source Developer Linux Technology Centre, IBM Australia mob: 0423 762 819