Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp493799ybe; Wed, 18 Sep 2019 22:01:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqxIv5zs8OENi4EVNm+gwmv68STVkbsYrHCQQx31iU413ug31Wm6c/hxwbdq5gXH3JWJiVpD X-Received: by 2002:a17:906:5584:: with SMTP id y4mr12545857ejp.89.1568869280044; Wed, 18 Sep 2019 22:01:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568869280; cv=none; d=google.com; s=arc-20160816; b=np0Lh4mwKlR5I5KXu13oeUcPfewK4FzFWjOANwnziXDKAlOII++ZUCWZrSZzZDsUtv 8YS0Bk1hyzmIoP5qE8rogJJXr2ftOi+injTGPt+IjKTYNImO9aR1f5VRyuSuE4+5+Asx YjdG1S57e2n2q5ZcTU1VHFOqkA1j9DFfS9AISjN4AREAdQhdVmhYqJlexORCJsVh/3yU 4GMjLfDoZTshoIvPoVNsnLp+i+3p1V2ENMJJEtxlSx8Yod9r2/jS6yTCX3P8Cb9jkARo pXYXgzfBAHc9B1vVA//X42aHvp/LWXhQqDQQqFt+I8p0KIVAUUqbzgGK6aSLBIWdqXBU Q28Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Fq+RpFCn2McWuMg3C5OlmcYZSlU9P8enqlr/h4VhVAg=; b=l20gnRBiL4xu62h8ImnUnUlizSByAwgJ1fuGsTBkDDiOyraJJcF0vyeisyd4LAT5WD nOEaQmHv5u4ranu/IyFaEnVQKzaEV1pbZCAltA8dBQrgdY1cx/vBIXg8lXVq/yO2hkYK eH60rVZEGoQvXqF30ekQXLGoTHtjDVEgF94fM/6ie4OoDS97yJOsPosHEgIIPqsW/6W5 N80t/h2fgqjCDziQIlZmpuzqUQ4IOcNlsFVT1QIqjm251qC6sVCwyO8B2OQ1gqHwSmCF XP7qQKodhacnBuyxsyeOsIlCZXLt4eetuNVrKmbOpReKehR5WiCeLrH0MpmQlcw+nomU T7FQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AvugnqvM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f31si5174395ede.253.2019.09.18.22.00.56; Wed, 18 Sep 2019 22:01:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AvugnqvM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387779AbfISB0Z (ORCPT + 99 others); Wed, 18 Sep 2019 21:26:25 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:39001 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387767AbfISB0Z (ORCPT ); Wed, 18 Sep 2019 21:26:25 -0400 Received: by mail-wr1-f68.google.com with SMTP id r3so1266228wrj.6 for ; Wed, 18 Sep 2019 18:26:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Fq+RpFCn2McWuMg3C5OlmcYZSlU9P8enqlr/h4VhVAg=; b=AvugnqvMBEU2/e4eEo1SBrNXBDNXJgxlc+8OulchbPWmdEAonz0hLIBLOVLlL9G+q6 F0DT9/X4lY65BMyqV6XI7DiNNDQF9bm1hFV4roW8v/5Q4SFZEtwjpk+X0dSaeb5g6rAF NBDKiBJ8in6K9vJGs3YiBBKvICzIsloJLgxrz0dmtAuExPQyOEZ7wkXAaN37jOvsH3Ct MfqejGKk9X4FVBLosvLumd0vUakjx3eG2Wco6D2tThQL6rsG02giNV2o62u3WzZqDQeq Js3I5VuDMmddVuCG+N2ye4LcOj/X1bocqfx84VXMYFO5KItYOd06OB8sI9DVZdp8Dfvf 1Ejg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Fq+RpFCn2McWuMg3C5OlmcYZSlU9P8enqlr/h4VhVAg=; b=ECPvc5M96HiSHTudQijuJB3fZMPMugDuE9lZToG/CIX8c+jU5piXWeu1N2aSdk30A9 y7U8uUfkso19gquX2ZTf6WhfMc1OkKoJlZ4XjUZNYzBC2PeZ00UFYDX9at0GHH8T39tR fPQuojA8eYUDLbjtgQjC/9u/QqqXbmsbR3TfZjLZ2KcFlI+bPKJnv7jXG0keF7JOzStI j081wHnQckk2JIxKmvIq9PjpQOUzOUMj04hjphw6G1PNCtYCy/GOSEx39IhfboFOL6sV CnDwMa1HogmwzdqZA1v+LeB1jNGxZjhWtAiXpcw87ZSo+DeVSu7OoJ7XL6u0Yp80Aas6 c8tw== X-Gm-Message-State: APjAAAVfj7PY4x2z1k0VzQCI1j5gcZ6ftfkrsZZ6iFYjQtxfEH4gSj7j Bk4K2TlPLBbJN1xCkwm451c= X-Received: by 2002:adf:9083:: with SMTP id i3mr5434855wri.310.1568856382862; Wed, 18 Sep 2019 18:26:22 -0700 (PDT) Received: from archlinux-threadripper ([2a01:4f8:222:2f1b::2]) by smtp.gmail.com with ESMTPSA id f13sm4400000wmj.17.2019.09.18.18.26.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2019 18:26:22 -0700 (PDT) Date: Wed, 18 Sep 2019 18:26:20 -0700 From: Nathan Chancellor To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Davidlohr Bueso , Andrew Morton , Nick Desaulniers , Ilie Halip , David Bolvansky Subject: Re: [PATCH] hugetlbfs: hugetlb_fault_mutex_hash cleanup Message-ID: <20190919012620.GA72561@archlinux-threadripper> References: <20190919011847.18400-1-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190919011847.18400-1-mike.kravetz@oracle.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 18, 2019 at 06:18:47PM -0700, Mike Kravetz wrote: > A new clang diagnostic (-Wsizeof-array-div) warns about the calculation > to determine the number of u32's in an array of unsigned longs. Suppress > warning by adding parentheses. > > While looking at the above issue, noticed that the 'address' parameter > to hugetlb_fault_mutex_hash is no longer used. So, remove it from the > definition and all callers. > > No functional change. > > Reported-by: Nathan Chancellor > Signed-off-by: Mike Kravetz Thanks for the patch! Reviewed-by: Nathan Chancellor