Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Saurav Kashyap <skashyap@marvell.com>
To:     Austin Kim <austindh.kim@gmail.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "QLogic-Storage-Upstream@cavium.com" 
        <QLogic-Storage-Upstream@cavium.com>
Subject: RE: [PATCH] scsi: qedf: Remove always false 'tmp_prio < 0' statement
Thread-Topic: [PATCH] scsi: qedf: Remove always false 'tmp_prio < 0' statement
Thread-Index: AQHVbsZy+GTAtfgAMkWKAgWFGPs49KcysVLA
Date:   Thu, 19 Sep 2019 08:52:11 +0000
Message-ID: <MN2PR18MB252777FF9E6A250332E70661D2890@MN2PR18MB2527.namprd18.prod.outlook.com>
References: <20190919075548.GA112801@LGEARND20B15>
In-Reply-To: <20190919075548.GA112801@LGEARND20B15>
Accept-Language: en-GB, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 14b2db94-206e-4005-0a2e-08d73cdea90c
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Sep 2019 08:52:11.0800
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AejeRIinHCnv79huZltpVgxwnkEWHxvE+My92gDQAJBGck4WxpsCOkEUJE7sQdC40LxLsRc64wr3/0py4P2hGg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3165
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8
 definitions=2019-09-19_03:2019-09-18,2019-09-19 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: linux-scsi-owner@vger.kernel.org <linux-scsi-owner@vger.kernel.org>=
 On
> Behalf Of Austin Kim
> Sent: Thursday, September 19, 2019 1:26 PM
> To: jejb@linux.ibm.com; martin.petersen@oracle.com
> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; QLogic-Stor=
age-
> Upstream@cavium.com; austindh.kim@gmail.com
> Subject: [PATCH] scsi: qedf: Remove always false 'tmp_prio < 0' statement
>=20
> Since tmp_prio is declared as u8, the following statement is always false=
.
>    tmp_prio < 0
>=20
> So remove 'always false' statement.
>=20
> Signed-off-by: Austin Kim <austindh.kim@gmail.com>
> ---
>  drivers/scsi/qedf/qedf_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.=
c index
> 1659d35..59ca98f 100644
> --- a/drivers/scsi/qedf/qedf_main.c
> +++ b/drivers/scsi/qedf/qedf_main.c
> @@ -596,7 +596,7 @@ static void qedf_dcbx_handler(void *dev, struct
> qed_dcbx_get *get, u32 mib_type)
>  		tmp_prio =3D get->operational.app_prio.fcoe;
>  		if (qedf_default_prio > -1)
>  			qedf->prio =3D qedf_default_prio;
> -		else if (tmp_prio < 0 || tmp_prio > 7) {
> +		else if (tmp_prio > 7) {
>  			QEDF_INFO(&(qedf->dbg_ctx), QEDF_LOG_DISC,
>  			    "FIP/FCoE prio %d out of range, setting to %d.\n",
>  			    tmp_prio, QEDF_DEFAULT_PRIO);
> --
> 2.6.2

Hi Austin,
Thanks for the patch.

Acked-by: Saurav Kashyap <skashyap@marvell.com>