Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Robert Richter <rrichter@marvell.com>
To:     Hanna Hawa <hhhawa@amazon.com>
CC:     "bp@alien8.de" <bp@alien8.de>,
        "mchehab@kernel.org" <mchehab@kernel.org>,
        "james.morse@arm.com" <james.morse@arm.com>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dwmw@amazon.co.uk" <dwmw@amazon.co.uk>,
        "benh@amazon.com" <benh@amazon.com>,
        "ronenk@amazon.com" <ronenk@amazon.com>,
        "talel@amazon.com" <talel@amazon.com>,
        "jonnyc@amazon.com" <jonnyc@amazon.com>,
        "hanochu@amazon.com" <hanochu@amazon.com>
Subject: Re: [PATCH v2 1/2] edac: Add an API for edac device to report for
 multiple errors
Thread-Topic: [PATCH v2 1/2] edac: Add an API for edac device to report for
 multiple errors
Thread-Index: AQHVbrQuVYp3+gdDsUucx/uYgcDYxA==
Date:   Thu, 19 Sep 2019 06:33:42 +0000
Message-ID: <20190919063334.x2rfk33swyjqur3q@rric.localdomain>
References: <20190912145305.21008-1-hhhawa@amazon.com>
 <20190912145305.21008-2-hhhawa@amazon.com>
In-Reply-To: <20190912145305.21008-2-hhhawa@amazon.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [31.208.96.227]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9d2a81a4-15fe-4833-d7be-08d73ccb509b
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:MN2PR18MB3328;
x-ms-traffictypediagnostic: MN2PR18MB3328:
x-microsoft-antispam-prvs: <MN2PR18MB3328E7B8FA7AA40D4E9D2408D9890@MN2PR18MB3328.namprd18.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-forefront-prvs: 016572D96D
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(346002)(136003)(39860400002)(366004)(396003)(376002)(189003)(199004)(86362001)(6436002)(7416002)(9686003)(66476007)(14454004)(486006)(6512007)(66556008)(6486002)(52116002)(256004)(76176011)(66446008)(81166006)(81156014)(66946007)(2906002)(64756008)(229853002)(478600001)(4744005)(53546011)(99286004)(386003)(6246003)(1076003)(6506007)(8936002)(4326008)(26005)(7736002)(305945005)(66066001)(11346002)(476003)(25786009)(102836004)(5660300002)(3846002)(6116002)(186003)(316002)(446003)(6916009)(71200400001)(71190400001)(54906003)(8676002);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR18MB3328;H:MN2PR18MB3408.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: TdscTdLt6jhcQAVrBJ8O9K/x340FNpdFm+0+yiImJCEoxfAUuiCeKhc/eKjdeLiG93NQZrS5fDzMeUbq5+6j7R/lH82PgLGUw+0rQuR5HwG0jWDQeMv9Uvhx9cQY/4O1PpKJmMYX8BNdb7VzzfaK3elJ+Tm72epBqkdSs05oPqFmdpqtQXminuoQnDD+L/r67TwzqidFrBSsoli6Pmhdw45w39Vc3aZDmg92gT5C5FE/HoAH40Zo3peWBL+2FQ0Jfkt1+uF0MPrRY2u/L4KSCQ/1fAPuWefVQ1Pxtz57zBFJ0CaN7FvuLhr7cOUXWo2ekcOeKWlemLmX/UmpkVUz6gqkjw3xgj0KPFIqsTuo9XRLnRjq+lWbd5pTIcR/B+9K7Ktoh0nRNwK5tMvhn4+2iErXeSrrTR+iQwNMp06ZVbo=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <149A30E28A77A04BB6CEC51434FF7CB6@namprd18.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d2a81a4-15fe-4833-d7be-08d73ccb509b
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Sep 2019 06:33:42.6181
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7YR87Oy8nqytHLLqRH1m2Clm7wbSrYijEUpCqO+Y+h1HzkeIuTsyi/4h2QQyKEYyDHnnWTqQTBrWiEZc3b5hiQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3328
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8
 definitions=2019-09-19_02:2019-09-18,2019-09-19 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12.09.19 15:53:04, Hanna Hawa wrote:
> Add an API for EDAC device to report multiple errors with same type.
>=20
> Signed-off-by: Hanna Hawa <hhhawa@amazon.com>
> ---
>  drivers/edac/edac_device.c | 91 ++++++++++++++++++++++++++++++++++++++
>  drivers/edac/edac_device.h | 40 +++++++++++++++++
>  2 files changed, 131 insertions(+)
>=20
> diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c
> index 65cf2b9355c4..78ac44103acc 100644
> --- a/drivers/edac/edac_device.c
> +++ b/drivers/edac/edac_device.c
> @@ -643,3 +643,94 @@ void edac_device_handle_ue(struct edac_device_ctl_in=
fo *edac_dev,
>  			block ? block->name : "N/A", msg);
>  }
>  EXPORT_SYMBOL_GPL(edac_device_handle_ue);
> +
> +void __edac_device_handle_ce(struct edac_device_ctl_info *edac_dev,
> +			     unsigned int count, int inst_nr, int block_nr,
> +			     const char *msg)
> +{

Please do not add a copy here, instead modify the existing function
and share the code with both, old and new functions.

Thanks,

-Robert