Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp873329ybe; Thu, 19 Sep 2019 05:18:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqwIE4WC6/6cp2FFOG3l8Ngdfh4ZJu+jlrSVxMeGfv6yq5+yvSdlNLDeuaZRS8rBnDqcsr9U X-Received: by 2002:aa7:dc49:: with SMTP id g9mr7059115edu.1.1568895496763; Thu, 19 Sep 2019 05:18:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568895496; cv=none; d=google.com; s=arc-20160816; b=QGG6c+TGdCoNHExjXtHl0rGunZLWQjhaT7+/jttSw7gn6EQwI5dUtRd/+X4dt6qz9z ivXsyWyEI609WcAEkOzG7OyUAeEG8KGnGnh1qDpm+UEO6wIok1nnZMoVP5FxDy9LL+Vp DH6iLSReJAFAwCbXaTPOS7u+IzMrnU8EEi+1basJcrBsmM+DisDNUm4naeJtbjGtdAr5 bhzu0mVhnf1Pg5Q9xZzPWAjJkbF/fDN9TKbGr3RBgQUQxqybVrXo/XvL/VpaZ2t4eFCF FiPzytJ+Rlobosr/fI3jcURERHTJ6PR6uq7mdBNUjaGCjqoqNJWiqcuyA2jiCV9Mw8+H HqtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=eQmwDVMrkMZNK+NaxwrEEeXUJDCFd2KfycrdemjLtdc=; b=VYxpawNEGJWrpZNBaKfwQ68aiP2KjG/+KmwbVFBeXezSjVGS95tByvxzFkDyB/rWm+ uL1dVKgDU9JGwpzDvmg/lnuNztR4l98F1CHGjUE6FFsELJDEY9aSeHPT9naHeqixzIRX SknQhwv1qSGOwx9rD5TMJRDmXmuPkEbx4wNvLM8AcFjXrcUdRLwL9tuBfj+cg2vIzLQu 5lmaF1gznk6Q0tFe12U8Wv0mcHtEppoi+YNvupI3/meAgQrdo4EIBQIdETtckkz3YmSL fMkLMme1uqCb2AB7mJFnWbN7rMZnwSHoZkAtM55lEzdJ/lCUESBB3M1Xk0qGsBy0TC4B //ag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z8si4974357edp.17.2019.09.19.05.17.53; Thu, 19 Sep 2019 05:18:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389077AbfISKX3 (ORCPT + 99 others); Thu, 19 Sep 2019 06:23:29 -0400 Received: from mx1.emlix.com ([188.40.240.192]:57538 "EHLO mx1.emlix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388940AbfISKX3 (ORCPT ); Thu, 19 Sep 2019 06:23:29 -0400 Received: from mailer.emlix.com (unknown [81.20.119.6]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.emlix.com (Postfix) with ESMTPS id 3D78B6038C; Thu, 19 Sep 2019 12:23:27 +0200 (CEST) From: Philipp Puschmann To: linux-kernel@vger.kernel.org Cc: yibin.gong@nxp.com, fugang.duan@nxp.com, l.stach@pengutronix.de, dan.j.williams@intel.com, vkoul@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, dmaengine@vger.kernel.or, linux-arm-kernel@lists.infradead.org, Philipp Puschmann Subject: [PATCH v2 0/3] Fix UART DMA freezes for i.MX SOCs Date: Thu, 19 Sep 2019 12:23:16 +0200 Message-Id: <20190919102319.23368-1-philipp.puschmann@emlix.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190911144943.21554-1-philipp.puschmann@emlix.com> References: <20190911144943.21554-1-philipp.puschmann@emlix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For some years and since many kernel versions there are reports that RX UART DMA channel stops working at one point. So far the usual workaround was to disable RX DMA. This patches fix the underlying problem. When a running sdma script does not find any usable destination buffer to put its data into it just leads to stopping the channel being scheduled again. As solution we manually retrigger the sdma script for this channel and by this dissolve the freeze. While this seems to work fine so far, it may come to buffer overruns when the channel - even temporary - is stopped. This case has to be addressed by device drivers by increasing the number of DMA periods. This patch series was tested with the current kernel and backported to kernel 4.15 with a special use case using a WL1837MOD via UART and provoking the hanging of UART RX DMA within seconds after starting a test application. It resulted in well known "Bluetooth: hci0: command 0x0408 tx timeout" errors and complete stop of UART data reception. Our Bluetooth traffic consists of many independent small packets, mostly only a few bytes, causing high usage of periods. Changelog v2: - adapt title (this patches are not only for i.MX6) - improve some comments and patch descriptions - add a dma_wb() around BD_DONE flag - add Reviewed-by tags - split off "serial: imx: adapt rx buffer and dma periods" Philipp Puschmann (3): dmaengine: imx-sdma: fix buffer ownership dmaengine: imx-sdma: fix dma freezes dmaengine: imx-sdma: drop redundant variable drivers/dma/imx-sdma.c | 32 ++++++++++++++++++++++---------- 1 file changed, 22 insertions(+), 10 deletions(-) -- 2.23.0