Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750865AbVL2Q6c (ORCPT ); Thu, 29 Dec 2005 11:58:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750867AbVL2Q6c (ORCPT ); Thu, 29 Dec 2005 11:58:32 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:49126 "EHLO mx3.mail.elte.hu") by vger.kernel.org with ESMTP id S1750862AbVL2Q6b (ORCPT ); Thu, 29 Dec 2005 11:58:31 -0500 Date: Thu, 29 Dec 2005 17:58:11 +0100 From: Ingo Molnar To: Christoph Hellwig , Jes Sorensen , Christoph Hellwig , linux-kernel@vger.kernel.org, torvalds@osdl.org Subject: Re: [patch] updates XFS mutex patch Message-ID: <20051229165811.GA23502@elte.hu> References: <20051229144824.GC18833@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051229144824.GC18833@infradead.org> User-Agent: Mutt/1.4.2.1i X-ELTE-SpamScore: 0.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=0.0 required=5.9 tests=AWL autolearn=no SpamAssassin version=3.0.3 0.0 AWL AWL: From: address is in the auto white-list X-ELTE-VirusStatus: clean Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 774 Lines: 19 * Christoph Hellwig wrote: > It's say just switch XFS to the one-arg mutex_init variant. > > And ingo. please add the mutex_t typedef, analogue to spinlock_t it's > a totally opaqueue to the users type, so it really should be a > typedef. After that the XFS mutex.h can just go away. that's not possible, due to DEFINE_MUTEX() and due to struct mutex being embedded in other structures. I dont think we want to lose that property of struct semaphore, and only restrict mutex usage to pointers. Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/