Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp1016821ybe; Thu, 19 Sep 2019 07:26:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqz9NC5LsGo5+/vcWFj9CSCOmOogBRHrtftYP8XJk9JzdqWA+MrruAvxuhl0I0i7/UhvNuGl X-Received: by 2002:a50:8d5e:: with SMTP id t30mr16510132edt.112.1568903179846; Thu, 19 Sep 2019 07:26:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568903179; cv=none; d=google.com; s=arc-20160816; b=OiCAjvphFVtlB3YwBsdMnr8yK01CpsHvKsAxt2b7kVcRjbuafKhh1tjBNAim+aICw7 vnP88QQvTwNt6XIb0bWyOQha/A70DJsm69tAufRMjK6BOqbbnK4J0E2iLwcLehL3kxal Z71S8fA+XHU/3ThwAAh4V5vC5mtlv76BH/TNH8uuCXPyT/G15qlWnaLEcb5J84vrRWw9 vqzu4/czNzH153uW8cUq7zimAXzieZ7PG+S1eo6allIUs6lGhrFjRDiwJRZd2zGF6ed9 VvRtkfPuccieUcTJGvq0pocxkNGXpyUbhWnaax3gU4A5CNZoBIxVV6Vy8SyVAow5cM1O DLZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=hRUP4eMT0Z8S+j9d3vgXo4N9nN9wYUB+voNus6KKuKo=; b=0oFMbfT4opEAEAnn6+PWtwQag7CuY1ozJP8lkjTV5LQgzyrlTA69HQsnZqM51TweUo sE5Q6oOkNNBAAdAA8adwMQrQQVEmPNj+FTPEtpgikyKakeNrU/TojSGoa+GWSB31gHzv WDn/PFfwYG+g+QfXMuVnGtK0rSfR6L6HWM4MzlrgHl84Ts9b4a4oqMqvzKk5n3GTlRA5 F1yGbalxSP5nwMKpHisqcSNXeMdk/yYmkObCWXoAektRiz6cvM0bQB7qz8Zo3+OTEr2i 7vO89+YTKAxfvWzq92QRcoBFpk+41e5pdnye2X8LXHrfDrsjbpjrWDPZWTtA8i42h3r9 rtaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e16si4718113ejj.372.2019.09.19.07.25.56; Thu, 19 Sep 2019 07:26:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388634AbfISKpc (ORCPT + 99 others); Thu, 19 Sep 2019 06:45:32 -0400 Received: from mx1.emlix.com ([188.40.240.192]:57696 "EHLO mx1.emlix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387520AbfISKpb (ORCPT ); Thu, 19 Sep 2019 06:45:31 -0400 Received: from mailer.emlix.com (unknown [81.20.119.6]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.emlix.com (Postfix) with ESMTPS id D889B603CA; Thu, 19 Sep 2019 12:45:29 +0200 (CEST) From: Philipp Puschmann To: linux-kernel@vger.kernel.org Cc: yibin.gong@nxp.com, fugang.duan@nxp.com, l.stach@pengutronix.de, dan.j.williams@intel.com, vkoul@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, dmaengine@vger.kernel.or, linux-arm-kernel@lists.infradead.org, Philipp Puschmann Subject: [PATCH v3 0/3] Fix UART DMA freezes for i.MX SOCs Date: Thu, 19 Sep 2019 12:45:23 +0200 Message-Id: <20190919104526.29851-1-philipp.puschmann@emlix.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190919102319.23368-1-philipp.puschmann@emlix.com> References: <20190919102319.23368-1-philipp.puschmann@emlix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For some years and since many kernel versions there are reports that RX UART DMA channel stops working at one point. So far the usual workaround was to disable RX DMA. This patches fix the underlying problem. When a running sdma script does not find any usable destination buffer to put its data into it just leads to stopping the channel being scheduled again. As solution we manually retrigger the sdma script for this channel and by this dissolve the freeze. While this seems to work fine so far, it may come to buffer overruns when the channel - even temporary - is stopped. This case has to be addressed by device drivers by increasing the number of DMA periods. This patch series was tested with the current kernel and backported to kernel 4.15 with a special use case using a WL1837MOD via UART and provoking the hanging of UART RX DMA within seconds after starting a test application. It resulted in well known "Bluetooth: hci0: command 0x0408 tx timeout" errors and complete stop of UART data reception. Our Bluetooth traffic consists of many independent small packets, mostly only a few bytes, causing high usage of periods. Changelog v3: - fixes typo in dma_wmb - add fixes tags Changelog v2: - adapt title (this patches are not only for i.MX6) - improve some comments and patch descriptions - add a dma_wb() around BD_DONE flag - add Reviewed-by tags - split off "serial: imx: adapt rx buffer and dma periods" Philipp Puschmann (3): dmaengine: imx-sdma: fix buffer ownership dmaengine: imx-sdma: fix dma freezes dmaengine: imx-sdma: drop redundant variable drivers/dma/imx-sdma.c | 32 ++++++++++++++++++++++---------- 1 file changed, 22 insertions(+), 10 deletions(-) -- 2.23.0