Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp1071973ybe; Thu, 19 Sep 2019 08:13:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqwe2IwqDaVtV+OT9xFghYMpyrXG0/F0JjRJwd4qiwfrLREemojIqcT+X3eTY7V55pb/iEiw X-Received: by 2002:a17:906:1ed6:: with SMTP id m22mr3280597ejj.135.1568906020059; Thu, 19 Sep 2019 08:13:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568906020; cv=none; d=google.com; s=arc-20160816; b=h5B08Iq4rDezZ/SNCZFfsnGGpx06uUO/OBuOqOdTmXhjuEaqdLlG1ImsHI6V+Uns5O T4LKORTbT2thyHPSHrVrSnitLl3wMZ5547ms5eiOS/9VaHYd/JgKa5cL6fDZNDQBovIq iqBsdLUpm+UbQcET8ieRsug3oZ5K4mBPIbxuRzyuW4omcbw+d1LJI31xrlf4cGH7SRCb wVi5n2rtxv9izOff3UuVFfJuupCX3bofUNduB4F9b2OkAVv8Vj45366jU8+AekJgRdPd QwajMJocIcsWa1O5vAQwkbSdUM2xWVr0X/9CBSJ+4rG7ByJ7bninO9iBtTqZ05xS+Zgy 7BLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:openpgp:from:references:cc:to:subject; bh=MbQHLwl0QWeEWDZcAff1CP8yXbk7gKqityUpjCpPH0I=; b=sLrvXZmnjOmvHD/9LrnQshwd9cZMfi4L9mLoix4A5WT4lLcMdAtN0WrjSY2cEIX+at 1qDBjt4HkV+IZj8l01aY3ZvTWVfkWVd/u0tdlxEqZW7vfbYLJ7EavtbWKfwkrX5NGzI9 8i782XWY6C/ARDvlOdGIUFOIJf8aCZ9+agb/OGs3y6mX/RY4kMUHGexvnFoJRDDJs4H2 ka0gp3vupNJ4C+CucAqxOQRgdhefFwPsEMLuKUl5DjTsLfvTAiT6+xa6Jso3I9o7Xu78 9kKg4Ni+iycx9hTweD1jQjFuZu5IJvBmcIG+PYO2oDwL8ayCpeIWqZkWpHxGHl8/05yb EqsA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 64si5807935eda.384.2019.09.19.08.13.16; Thu, 19 Sep 2019 08:13:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390036AbfISLmf (ORCPT + 99 others); Thu, 19 Sep 2019 07:42:35 -0400 Received: from mx1.emlix.com ([188.40.240.192]:57994 "EHLO mx1.emlix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388688AbfISLmf (ORCPT ); Thu, 19 Sep 2019 07:42:35 -0400 Received: from mailer.emlix.com (unknown [81.20.119.6]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.emlix.com (Postfix) with ESMTPS id 5A998603CA; Thu, 19 Sep 2019 13:42:33 +0200 (CEST) Subject: Re: [PATCH v3 1/3] dmaengine: imx-sdma: fix buffer ownership To: Fabio Estevam Cc: linux-kernel , Robin Gong , Fugang Duan , Lucas Stach , Dan Williams , Vinod , Shawn Guo , Sascha Hauer , Sascha Hauer , NXP Linux Team , dmaengine@vger.kernel.or, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" References: <20190919102319.23368-1-philipp.puschmann@emlix.com> <20190919104526.29851-1-philipp.puschmann@emlix.com> <20190919104526.29851-2-philipp.puschmann@emlix.com> From: Philipp Puschmann Openpgp: preference=signencrypt Message-ID: Date: Thu, 19 Sep 2019 13:42:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Fabio, Am 19.09.19 um 13:37 schrieb Fabio Estevam: > Hi Philipp, > > On Thu, Sep 19, 2019 at 7:45 AM Philipp Puschmann > wrote: >> >> BD_DONE flag marks ownership of the buffer. When 1 SDMA owns the >> buffer, when 0 ARM owns it. When processing the buffers in >> sdma_update_channel_loop the ownership of the currently processed >> buffer was set to SDMA again before running the callback function of >> the buffer and while the sdma script may be running in parallel. So >> there was the possibility to get the buffer overwritten by SDMA before >> it has been processed by kernel leading to kind of random errors in the >> upper layers, e.g. bluetooth. >> >> Fixes: broken since start > > The Fixes tag requires a commit ID like this: > > Fixes: 1ec1e82f2510 ("dmaengine: Add Freescale i.MX SDMA support") > > Same applies to the other patch. > oh okay, thanks. I will fix this with v4. Regards, Philipp