Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of arm.com: DNS Timeout)
From:   Mihail Atanassov <Mihail.Atanassov@arm.com>
To:     "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
CC:     nd <nd@arm.com>, Daniel Vetter <daniel@ffwll.ch>,
        Liviu Dudau <Liviu.Dudau@arm.com>,
        "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>,
        Brian Starkey <Brian.Starkey@arm.com>,
        David Airlie <airlied@linux.ie>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/komeda: Fix FLIP_COMPLETE timestamp on CRTC enable
Thread-Topic: [PATCH] drm/komeda: Fix FLIP_COMPLETE timestamp on CRTC enable
Thread-Index: AQHVbu5XybbezBNH+kaEyHcWelehf6czE10A
Date:   Thu, 19 Sep 2019 14:43:35 +0000
Message-ID: <1731001.VqgqlKjhFN@e123338-lin>
References: <20190919132759.18358-1-mihail.atanassov@arm.com>
In-Reply-To: <20190919132759.18358-1-mihail.atanassov@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
Authentication-Results-Original: spf=none (sender IP is )
 smtp.mailfrom=Mihail.Atanassov@arm.com; 
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: da97205d-5078-4e06-f260-08d73d0fc7ac
X-MS-Office365-Filtering-HT: Tenant
X-Microsoft-Antispam-Untrusted: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:VI1PR08MB4206;
X-MS-TrafficTypeDiagnostic: VI1PR08MB4206:|VI1PR08MB4206:|AM0PR08MB3794:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS: <AM0PR08MB3794CA8DA7A6D4DE9D1B15EF8F890@AM0PR08MB3794.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
x-ms-oob-tlc-oobclassifiers: OLM:7691;OLM:7691;
x-forefront-prvs: 016572D96D
X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(7916004)(366004)(346002)(39860400002)(396003)(136003)(376002)(189003)(199004)(256004)(6916009)(81156014)(81166006)(7736002)(8676002)(54906003)(8936002)(478600001)(14454004)(486006)(11346002)(305945005)(2351001)(86362001)(476003)(71190400001)(64756008)(3846002)(25786009)(102836004)(6486002)(229853002)(6436002)(5640700003)(99286004)(4326008)(6246003)(66556008)(5660300002)(76176011)(33716001)(66476007)(66066001)(446003)(71200400001)(2501003)(386003)(6116002)(6506007)(66946007)(6512007)(66446008)(26005)(52116002)(2906002)(186003)(9686003)(316002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR08MB4206;H:VI1PR08MB4078.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Message-Info-Original: Buht71Y+RSTNYcfHzmMTQyCAc91Ht9wmJyNCscTA+sIfCqwpp7aV2FuXVU3DGh49vIC3PSSZxhcAF4zkYxppy0jQ/GJcTP2kGhd71FIcnIDz1lQ/+7xxJVSXXMjGHdslRy5jn2e6Fi5t427Wt19X2AflV3mN47pzEsNRKLlEmaEhVucJFdO8yJRIii1zHvkB69ikB0criqDQ0Q+n4EmOAOPM05XE2QLe6KZ3BE/JJzv5LmlL1NNcjfapYUNGUwotE4kIRbS6dgE89l+yS6cxpS31WThAcn+7YUoXKZ9hL5zx6P018xMODU8eYjl8yZ9V9D4vm/seE1Trgk/Br3Pt5sxCKb0FqxuSSQrxA8hqnGfCI2qLJYoqtIbZO10qlE+uin9lJkBQ0AqiMVlg35n9unzlAg/5dwaDljPVaX1IrFg=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <DD02967929B48648A4B3100FECF50639@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4206
Original-Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=Mihail.Atanassov@arm.com; 
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(7916004)(39860400002)(136003)(346002)(396003)(376002)(189003)(199004)(2501003)(229853002)(478600001)(22756006)(99286004)(5660300002)(4326008)(316002)(36906005)(9686003)(6116002)(3846002)(97756001)(6506007)(386003)(63350400001)(26826003)(70586007)(2351001)(76176011)(23726003)(305945005)(25786009)(86362001)(2906002)(70206006)(336012)(47776003)(11346002)(5640700003)(6512007)(476003)(446003)(356004)(6486002)(54906003)(50466002)(8746002)(8676002)(126002)(76130400001)(186003)(8936002)(66066001)(33716001)(46406003)(102836004)(486006)(7736002)(26005)(6246003)(14454004)(81166006)(6862004)(81156014);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR08MB3794;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:TempError;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;MX:1;A:1;
X-MS-Office365-Filtering-Correlation-Id-Prvs: deb039be-0761-4974-8241-08d73d0fc05d
X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(710020)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:AM0PR08MB3794;
NoDisclaimer: True
X-Forefront-PRVS: 016572D96D
X-Microsoft-Antispam-Message-Info: IEOtOMYO0cscpmuK8gDoIm2El4jJtHehaIJeT1k5Ib7D3s8D1L1YkZYCs5FP+vAf0P/hLfK9CbnwL0BsUTqj+QHRKdqoRu3u+apjzPmnuCVNBqdv+gRafaXRfcE+BgSU6VhNoe3OSlAWpFhsPP8xNOSLJsBX47zy/ZULIlGIi+h52lOm7CrHVKx27DVhnONyVO2McIAqQ2VbVaIofr1nveipuhDd5Wxe2pMh+NkDSOWc1GusgX3CMCCHyqSc79JB9/qlFOXUkGp3yKiwY8cXgDEerqsyrMVoOL9aTycMAF4dodvtRV0j7m6deR4w3xkhCBfaFPZ9sD3q30niAFUt0AMzRvn5pGeGh4IB/T8UB1mvilYUs1keEswajiNvR6bpqP06pszUNyekthyXIvugSE77IidOyyoYsvMIyZAGO4I=
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2019 14:43:47.9017
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: da97205d-5078-4e06-f260-08d73d0fc7ac
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3794
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday, 19 September 2019 14:30:02 BST Mihail Atanassov wrote:
> When initially turning a crtc on, drm_reset_vblank_timestamp will
> set the vblank timestamp to 0 for any driver that doesn't provide
> a ->get_vblank_timestamp() hook.
>=20
> Unfortunately, the FLIP_COMPLETE event depends on that timestamp,
> and the only way to regenerate a valid one is to have vblank
> interrupts enabled and have a valid in-ISR call to
> drm_crtc_handle_vblank.
>=20
> Wrap the call to komeda_crtc_do_flush in ->atomic_enable() with a
> drm_crtc_vblank_{get,put} pair so we can have a vblank ISR prior to
> the FLIP_COMPLETE ISR (or more likely, they'll get handled in the same
> ISR, which is equally valid).
>=20
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Liviu Dudau <Liviu.Dudau@arm.com>
> Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> ---
>  drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c b/drivers/g=
pu/drm/arm/display/komeda/komeda_crtc.c
> index f4400788ab94..87420a767bc4 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c
> @@ -258,7 +258,9 @@ komeda_crtc_atomic_enable(struct drm_crtc *crtc,
>  {
>  	komeda_crtc_prepare(to_kcrtc(crtc));
>  	drm_crtc_vblank_on(crtc);
> +	WARN_ON(drm_crtc_vblank_get(crtc));
>  	komeda_crtc_do_flush(crtc, old);
> +	drm_crtc_vblank_put(crtc);
>  }
> =20
>  static void
>=20

Please ignore, this doesn't work (page flips after 5 seconds don't get
an updated timestamp because of the delayed vsync disable). I'll push
a v2 soon where vsync on/off tracks crtc enable/disable.

--=20
Mihail