Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roman Gushchin <guro@fb.com>
To:     Suleiman Souhlal <suleiman@google.com>
CC:     "linux-mm@kvack.org" <linux-mm@kvack.org>,
        Michal Hocko <mhocko@kernel.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        Kernel Team <Kernel-team@fb.com>,
        "Shakeel Butt" <shakeelb@google.com>,
        Vladimir Davydov <vdavydov.dev@gmail.com>,
        "Waiman Long" <longman@redhat.com>
Subject: Re: [PATCH RFC 00/14] The new slab memory controller
Thread-Topic: [PATCH RFC 00/14] The new slab memory controller
Thread-Index: AQHVZDNwmo4dH7vFVEWbwj6k0KVokaczFt4AgAAtegA=
Date:   Thu, 19 Sep 2019 16:22:09 +0000
Message-ID: <20190919162204.GA20035@castle.dhcp.thefacebook.com>
References: <20190905214553.1643060-1-guro@fb.com>
 <CABCjUKByipk2e1Hh1_PwC+p2Fig=6RMfd0zBeVQtyn5Y48gYXQ@mail.gmail.com>
In-Reply-To: <CABCjUKByipk2e1Hh1_PwC+p2Fig=6RMfd0zBeVQtyn5Y48gYXQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [2620:10d:c090:180::2154]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 8ae0c3e5-52ac-4181-7783-08d73d1d8529
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:BN8PR15MB2785;
x-ms-traffictypediagnostic: BN8PR15MB2785:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BN8PR15MB27853480DBCB7973719FDBE7BE890@BN8PR15MB2785.namprd15.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-forefront-prvs: 016572D96D
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(136003)(376002)(346002)(396003)(39860400002)(199004)(189003)(229853002)(81156014)(8676002)(81166006)(8936002)(33656002)(25786009)(52116002)(66946007)(66556008)(64756008)(66446008)(66476007)(6512007)(9686003)(6246003)(6486002)(476003)(102836004)(386003)(11346002)(486006)(446003)(305945005)(7736002)(99286004)(2906002)(53546011)(6506007)(76176011)(6436002)(186003)(46003)(478600001)(6916009)(86362001)(14454004)(6116002)(256004)(14444005)(71200400001)(71190400001)(1076003)(316002)(5660300002)(54906003)(4326008);DIR:OUT;SFP:1102;SCL:1;SRVR:BN8PR15MB2785;H:BN8PR15MB2626.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: s3R4daHs6UuPiiA3vXVjRYjOztCej7R1GSbO1CLV2vro+S+k5Q4q0fepYkhxN6NW4dxSNvYve1jBMKs+1SXzmfouBP36+zMzXYA6MENTanefqlgbUDGgT1xnSxew2EXK/eV/SCKnYAXRydMXshwo1bl6s+cC2RN9QlZgximHFS/y8DArJ6lg+il+ZNSRLT/YxTT9qYwBjSmnPl21fT+hjjewUqI4x4+vkLqAT1auhOIQ5oGY60P01UYSzncNx9KsBpsjBIAnNEdjw0TJ4rH+OuARcdhEkjG4kLUPsBcs2DI1Y43Snw6X8j04s+ttiQjfziihQSywi/MjEr/pXCWl21ylQ4oLuh8anTAXcC5xzDgxrGyF81miD0EdBnZNsZo5toIDFeJ1S40xo2M6lwDd7Vd6Bq6fui0SPbZNcSQkFCk=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5537AB22E3CBB44585ED0BA0E1094AF5@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ae0c3e5-52ac-4181-7783-08d73d1d8529
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Sep 2019 16:22:09.8095
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jggdSNW8TS5PxzhTLeMNvNZ6+M7mSeqDWB2mS66PQ9J/5eThco2WuMb83eu8RsU6
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR15MB2785
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8
 definitions=2019-09-19_05:2019-09-19,2019-09-19 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 mlxscore=0 malwarescore=0
 suspectscore=0 bulkscore=0 mlxlogscore=611 adultscore=0 phishscore=0
 spamscore=0 clxscore=1011 impostorscore=0 priorityscore=1501
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-1908290000 definitions=main-1909190146
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 19, 2019 at 10:39:18PM +0900, Suleiman Souhlal wrote:
> On Fri, Sep 6, 2019 at 6:57 AM Roman Gushchin <guro@fb.com> wrote:
> > The patchset has been tested on a number of different workloads in our
> > production. In all cases, it saved hefty amounts of memory:
> > 1) web frontend, 650-700 Mb, ~42% of slab memory
> > 2) database cache, 750-800 Mb, ~35% of slab memory
> > 3) dns server, 700 Mb, ~36% of slab memory
>=20
> Do these workloads cycle through a lot of different memcgs?

Not really, those are just plain services managed by systemd.
They aren't restarted too often, maybe several times per day at most.

Also, there is nothing fb-specific. You can take any new modern
distributive (I've tried Fedora 30), boot it up and look at the
amount of slab memory. Numbers are roughly the same.

>=20
> For workloads that don't, wouldn't this approach potentially use more
> memory? For example, a workload where everything is in one or two
> memcgs, and those memcgs last forever.
>

Yes, it's true, if you have a very small and fixed number of memory cgroups=
,
in theory the new approach can take ~10% more memory.

I don't think it's such a big problem though: it seems that the majority
of cgroup users have a lot of them, and they are dynamically created and
destroyed by systemd/kubernetes/whatever else.

And if somebody has a very special setup with only 1-2 cgroups, arguably
kernel memory accounting isn't such a big thing for them, so it can be simp=
le
disabled. Am I wrong and do you have a real-life example?

Thanks!

Roman