Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp513575ybj; Thu, 19 Sep 2019 18:28:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqzXE9t82n6mPwoQPKXEvGOtZFqz0+FJlLeZc11H6sfA+oPqrmkvpcNfUHll1bd7TiWCDTq6 X-Received: by 2002:aa7:ce88:: with SMTP id y8mr19695149edv.145.1568942898870; Thu, 19 Sep 2019 18:28:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568942898; cv=none; d=google.com; s=arc-20160816; b=P7rIemN9in2e2QYuYUp+cDK78gw0kxthYJMleqjBtr2AuKS+ZK8Gaqvz+ZscrrsvrP IVqD5sQgrQlqhGTHlCLlli2yAeGnvNsr422WarjZEdPp9lbxUgG+rlOJs/LteCWF1xF4 v3s9u/EjZYHzHH6FUkWUTXDkzjfPByDGi0OaNdqldS1ycRyGrmJb+2kH7XqnnzNwbHp5 ge/Okhg2UtI7tRcdE4zSfbUwPkLVzLuEUq8s2acqoxwWIwNCCkcH2R6SaQbWlDMVohFR BCWZqHcHmj7zUpMFQn4VfK3PceJnM7tLxgrYLrblDcpeXhTbYHOU/NX67pjyFPHJaJBu URxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=uLWwabobIGrhgS4JRVKWILNgGXZ4lrzO2MqnCn7tKGo=; b=N9YnLERbCeApvDXaKopuP+aNjWNPTbE+AZ1+OasvrvwdB8jTTP3LyFd6WK1AQHHXUB KAaaORmVhfopSzJ5Zf14Vjw+bUqPowOpC2WRM5UnJRABvlA43Y6NfgqQwTsiPQ3J2Ktq M6Sf3VJBH+TbMRUktzbAQvd3jaTemkHttCmwXfizktDOFDmVgWPn02r17WHjelLtsOvB 95ubGnp1LZflMheuFmXihcUrAoSiGSQRNsSu6c7y7B7V7ho3u+2uTZbArtmE3ZnenlkK DFnvVC7d3PsvECivOBozc2K4iQw0K/KZTlP3Fmx8EHGxh+yKU+z0gnjY/9Q5bScThAsE IQ8w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 29si220046eje.235.2019.09.19.18.27.55; Thu, 19 Sep 2019 18:28:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391843AbfISRHQ (ORCPT + 99 others); Thu, 19 Sep 2019 13:07:16 -0400 Received: from verein.lst.de ([213.95.11.211]:42808 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390733AbfISRHQ (ORCPT ); Thu, 19 Sep 2019 13:07:16 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id B3C0968BE1; Thu, 19 Sep 2019 19:07:11 +0200 (CEST) Date: Thu, 19 Sep 2019 19:07:11 +0200 From: Christoph Hellwig To: Linus Torvalds Cc: "Darrick J. Wong" , "Darrick J. Wong" , linux-fsdevel , linux-xfs , Dave Chinner , Linux Kernel Mailing List , Eric Sandeen , Christoph Hellwig , Andreas Gruenbacher , Bob Peterson , cluster-devel Subject: Re: [GIT PULL] iomap: new code for 5.4 Message-ID: <20190919170711.GA9065@lst.de> References: <20190917152140.GU2229799@magnolia> <20190919034502.GJ2229799@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 19, 2019 at 10:03:30AM -0700, Linus Torvalds wrote: > It's just that we've survived three decades without that list_pop(), > and I don't want to make our header files even bigger and more complex > unless we actually have multiple real users. I personally surived with it, but really hated writing the open coded list_for_each_entry + list_del or while list_first_entry_or_null + ┐ist_del when I could have a nice primitive for it. I finally decided to just add that helper..