Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp870788ybj; Fri, 20 Sep 2019 01:08:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqwlz1NpNz364KGprtZvRcUHWK1jDs37gzHK5peJUgf6M9iLZ8uQoEv9kltIwswH2zdnVzpf X-Received: by 2002:a05:6402:120e:: with SMTP id c14mr20455072edw.272.1568966901920; Fri, 20 Sep 2019 01:08:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568966901; cv=none; d=google.com; s=arc-20160816; b=OV8lsr+S3RY7j00+Vyi9PUFTjkSyRsyI+GxEoJt4joLBcTo6k5vouFgqNUJCJwsmyV zALV5RFVohbYJ0Gbz8CCLE0bw2aoUWJosNu/QoOo8lTiUtkw4Iv42EEBlG7Q13TAxeE9 9ll6io2RqnUuNONLZ1tkOOxF/eONnPA4onGwKLavdHXJyindwblHxGwm5uzkvR+ED9fx KGRqiXXxMbt/Ne80myQQQNdnRQGeMJA9BGK8TrjV3sP1TEpZBqnQFXBlXQH1fLQB1stf vxg8R/Pwh/LnfiHpB6yv+dqw1soWlKBAEN3une+Djl2wasyD0h8Uetsw5Q5u3i3UKk21 JzNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/eEXxx8tNsywgFZRdTPU11J/+33IL0D+s3lfjh9BQQ0=; b=iFMaJBJs/lQGIIuYMSGz26+jha6PyRVMwRcT1VZbPlPNUxd9FEs5x3QAQO7FFyY5S3 Om89N7M6ednsBNnzn2C912fQoqX3xVlONj7xOgE+Tvd3jKjUvb7Nwhcv0VrdFljav3Iz yqCwtPVi5Wm3jYibx2uEUYfAEEuwT8tvZmP3xDmN7T1uAFPtTM7BVN4evF2C6ykd7WDx XrM0S+p+QqVGMdfTlvYiv1HyflGszGER+r7ECRDJ+b8nEzVRuFvkyiOBzm7jXRYpIwQk cHH80FAhcZN+1EzKcpZKBaJ34MaeeF2ZK7PwCLcVXMnx0ZiyHGG68fKr95uF59cW5AzF Tkxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YPCW0hgU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ck18si628482ejb.300.2019.09.20.01.07.58; Fri, 20 Sep 2019 01:08:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YPCW0hgU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393246AbfISWHe (ORCPT + 99 others); Thu, 19 Sep 2019 18:07:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:45236 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393235AbfISWHc (ORCPT ); Thu, 19 Sep 2019 18:07:32 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6539B21907; Thu, 19 Sep 2019 22:07:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568930851; bh=hnqkJNqeU0GZH+MoozhkmudYBgC7N8oYscP95+s0Whg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YPCW0hgUHljNZsu+3kFauwDF4yrvbPfNSr6RM7fi3DrJytcz5v4gwIOkDh5+4Niej 2uRhx+jnsjlBiIvCHpFPmRu6o1YY81zEOGlyNnTkDJiytRU8O6AlGcg0HT8IC2nAIX jQ1D4OY5YEVPlXukTE8ZCZvMrvJge6QdbGINFynU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Darrick J. Wong" , Trond Myklebust Subject: [PATCH 5.2 010/124] nfs: disable client side deduplication Date: Fri, 20 Sep 2019 00:01:38 +0200 Message-Id: <20190919214819.539230985@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190919214819.198419517@linuxfoundation.org> References: <20190919214819.198419517@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Darrick J. Wong commit 9026b3a973b0b0b73c15ba40aff87cd0959fd0f3 upstream. The NFS protocol doesn't support deduplication, so turn it off again. Fixes: ce96e888fe48e ("Fix nfs4.2 return -EINVAL when do dedupe operation") Signed-off-by: Darrick J. Wong Signed-off-by: Trond Myklebust Signed-off-by: Greg Kroah-Hartman --- fs/nfs/nfs4file.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) --- a/fs/nfs/nfs4file.c +++ b/fs/nfs/nfs4file.c @@ -187,7 +187,11 @@ static loff_t nfs42_remap_file_range(str bool same_inode = false; int ret; - if (remap_flags & ~(REMAP_FILE_DEDUP | REMAP_FILE_ADVISORY)) + /* NFS does not support deduplication. */ + if (remap_flags & REMAP_FILE_DEDUP) + return -EOPNOTSUPP; + + if (remap_flags & ~REMAP_FILE_ADVISORY) return -EINVAL; /* check alignment w.r.t. clone_blksize */