Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp891388ybj; Fri, 20 Sep 2019 01:32:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqzfRqCUSfKxg1x/2voRn3osUqiBJHNX756ayg+ZCkWMOr9vaDf0lRxy8q8efCX7TGGTsGi4 X-Received: by 2002:a17:906:7e56:: with SMTP id z22mr15513414ejr.294.1568968343218; Fri, 20 Sep 2019 01:32:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568968343; cv=none; d=google.com; s=arc-20160816; b=j5MNImX7/X/0sZ+8YUjDlNTGY02vB9x37gm1sPzKQlu5F8z5LrM8MpSf7+czHAp+V2 +ovHR4IthuQzisYoGn0p5ubStyFU0E8KxWpnh9TZtjjdYS3wG3C0IL/8pqRvLVwup54U 3qq8mcXVRUx0cC8+IjE+m0B3cIxlQD2/pLIVDJz8Ot/eNzfhHQ5CCxIsc49U6DtH7G6S K/CUiJcb6xTj01XEW3rOPrAh4v5leSoMRSemxeV6OUIYG6JZD9Hinkw+TuklDCSSPm08 zEB18prfVSxIbQ5v3GP8StfNyc+jFGXTTunDtDJww4jol0fHUKigE/qDkHoyb2VqcJRb MBmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Vj77cw5ZNWr0A4tRaiqMcvrjjzElkIRPttXWUatlXbw=; b=sGu3zEKJgaL2DNpfp+EWngLo4JkKZDuIxk138h9XsaJsCQkmyIBcOZ07t2tUv8cYAl oMxk87Q/MEC1Dh8hBiWXe1K68+Oj2wOY7RwkPT3V/UyMV2KMWs+KebG6EP7YH4D5eLtw p+RuWnpIX+y9sXqmZ2/v22x0JWrxzRTH8DNvAtbOpgNnTJ2IatrVEq9HsyuII8nsojUV avFE9SngUa/YnALYUREqkKbbWJg9MknvEnfh9QltHkbTwG2B0teytsLx7YX2JVV2caIT uTz1GsDHfNz28t7l/bDG6w7ky+foSN8WVAZNBMWh1s4qjCvUDyfg/r/GCjuEMpmYg3Vx S7eQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lUs0Rpw7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e21si839921edb.164.2019.09.20.01.32.00; Fri, 20 Sep 2019 01:32:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lUs0Rpw7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393257AbfISWHg (ORCPT + 99 others); Thu, 19 Sep 2019 18:07:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:45270 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393248AbfISWHf (ORCPT ); Thu, 19 Sep 2019 18:07:35 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1397A218AF; Thu, 19 Sep 2019 22:07:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568930854; bh=9gc/Zm1Jj1ppxAEBa09tR3HducYwUO/bNUYg07C8ndk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lUs0Rpw7acQzysr9UT33L1xcGnf1F2Cx675Mfh+CRMCxMZp0o2+aQ5kih+n/42fH3 Uxu4GtNIAUeFHiGdsNymxGApMasap+u+bQO8kYy0digiRlDPpex/K190HQoG7T16ja Qlp/axpbTge3hDm98ZXXd1lvyUsrGQdryXinHsHA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Aneesh Kumar K.V" , Michael Ellerman Subject: [PATCH 5.2 011/124] powerpc/mm/radix: Use the right page size for vmemmap mapping Date: Fri, 20 Sep 2019 00:01:39 +0200 Message-Id: <20190919214819.570071312@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190919214819.198419517@linuxfoundation.org> References: <20190919214819.198419517@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Aneesh Kumar K.V commit 89a3496e0664577043666791ec07fb731d57c950 upstream. We use mmu_vmemmap_psize to find the page size for mapping the vmmemap area. With radix translation, we are suboptimally setting this value to PAGE_SIZE. We do check for 2M page size support and update mmu_vmemap_psize to use hugepage size but we suboptimally reset the value to PAGE_SIZE in radix__early_init_mmu(). This resulted in always mapping vmemmap area with 64K page size. Fixes: 2bfd65e45e87 ("powerpc/mm/radix: Add radix callbacks for early init routines") Signed-off-by: Aneesh Kumar K.V Signed-off-by: Michael Ellerman Signed-off-by: Greg Kroah-Hartman --- arch/powerpc/mm/book3s64/radix_pgtable.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) --- a/arch/powerpc/mm/book3s64/radix_pgtable.c +++ b/arch/powerpc/mm/book3s64/radix_pgtable.c @@ -515,14 +515,6 @@ void __init radix__early_init_devtree(vo mmu_psize_defs[MMU_PAGE_64K].shift = 16; mmu_psize_defs[MMU_PAGE_64K].ap = 0x5; found: -#ifdef CONFIG_SPARSEMEM_VMEMMAP - if (mmu_psize_defs[MMU_PAGE_2M].shift) { - /* - * map vmemmap using 2M if available - */ - mmu_vmemmap_psize = MMU_PAGE_2M; - } -#endif /* CONFIG_SPARSEMEM_VMEMMAP */ return; } @@ -587,7 +579,13 @@ void __init radix__early_init_mmu(void) #ifdef CONFIG_SPARSEMEM_VMEMMAP /* vmemmap mapping */ - mmu_vmemmap_psize = mmu_virtual_psize; + if (mmu_psize_defs[MMU_PAGE_2M].shift) { + /* + * map vmemmap using 2M if available + */ + mmu_vmemmap_psize = MMU_PAGE_2M; + } else + mmu_vmemmap_psize = mmu_virtual_psize; #endif /* * initialize page table size