Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp934634ybj; Fri, 20 Sep 2019 02:21:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqxodso+oDNlvtJQWUJeHCbR8fo80k0+x2qe79GE/tuDK7Cpi5gFmoBRKYX70EDKpCFArqmI X-Received: by 2002:aa7:db43:: with SMTP id n3mr20320195edt.136.1568971284489; Fri, 20 Sep 2019 02:21:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568971284; cv=none; d=google.com; s=arc-20160816; b=faqo9O9a3zCniS0+Ka4l/qVApfKOEq98nRUiapE+TIw/0gOOfSGmDYyKWmfCnm8d7J 0sk/ih3QEEMYwkZEGGKGryzropeHziSsM2oRkIgB0cqc+QzchUSrTobydXAHYcP59UrJ PxJLY06wt3M93IDCNp5pMd67ADvhd6tGSizAl52Fp1leV/m294npQEMNt5/AHyuBJeBP CclMkQGUOQ2XaECRaeEi9cm6Me0iYq4MyVKFr1JwzeLxd5Ww7SUJvdq/z2y3q/4QHlGJ jKaN20fhSzxtze15QsqwvDCR/cYUD/pPNz5KvDJerWqEP8K5o4WYdFzobJRurN6YC6Nu rCMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=cqev5nI90lwzu2qsM+gbx9Hjyd+si1udMYe50xTHCKc=; b=q31Spj0k+B5W7u1KLRIuMwRT1zg2gzYmdr87dyqHqVZG3xq77MG45nhMrdNm0e9M37 9F/ikgRHhuup7hNYf8Glsnhh2SOyQ1Xb+e1gIJmROqLFbtuIPkUHFmnnT6ObP/vCXU6v tO4AAsh7nvlnkHiNiCGGUlgnenTH9rHz63IhMaDlQhJzICV/rtaNfb+gcDnlnY1uLq7w IzuNOK3c/lLy1xtuAfWSRmoLjO+FJ4qvaJWGM2iJd5rh8L2Hjg7gbIwtGaySquQzRsWU Ap7LsXldkXMpecsbWKuS2DVheKh1/G4gAwkKFUgFRkijH+7PaAYpDsiX57HYJU8qJ5Y8 j44Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vS3nVAfY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p13si1055836edi.410.2019.09.20.02.21.01; Fri, 20 Sep 2019 02:21:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vS3nVAfY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405748AbfISWKo (ORCPT + 99 others); Thu, 19 Sep 2019 18:10:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:49164 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405738AbfISWKm (ORCPT ); Thu, 19 Sep 2019 18:10:42 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B6CA821929; Thu, 19 Sep 2019 22:10:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568931042; bh=+PpyBe9AIAsblW3JyysaNGodo98udWJcx/rWMlVM3eg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vS3nVAfYq0487Q19v1mH3KTdQfSXJvRh6bUVvFUQQ/xBY1u82Wucf/8v1PGH0eEO4 DoX1h8JOyc5edNVqTH6z0usksN6wV+OQwRpw3/vZPp9Ur7hmGMrW4XelM7TTD34LXb HSdUnnbZwpPL6lcWpiNkNpTJc1XRmdLMgMevLU54= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jan Stancek , Naresh Kamboju , Trond Myklebust , Sasha Levin Subject: [PATCH 5.2 074/124] NFSv2: Fix write regression Date: Fri, 20 Sep 2019 00:02:42 +0200 Message-Id: <20190919214821.693331447@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190919214819.198419517@linuxfoundation.org> References: <20190919214819.198419517@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Trond Myklebust [ Upstream commit d33d4beb522987d1c305c12500796f9be3687dee ] Ensure we update the write result count on success, since the RPC call itself does not do so. Reported-by: Jan Stancek Reported-by: Naresh Kamboju Signed-off-by: Trond Myklebust Tested-by: Jan Stancek Signed-off-by: Sasha Levin --- fs/nfs/proc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/nfs/proc.c b/fs/nfs/proc.c index ec79d2214a78c..0f7288b94633b 100644 --- a/fs/nfs/proc.c +++ b/fs/nfs/proc.c @@ -616,8 +616,10 @@ static int nfs_proc_pgio_rpc_prepare(struct rpc_task *task, static int nfs_write_done(struct rpc_task *task, struct nfs_pgio_header *hdr) { - if (task->tk_status >= 0) + if (task->tk_status >= 0) { + hdr->res.count = hdr->args.count; nfs_writeback_update_inode(hdr); + } return 0; } -- 2.20.1